Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): change element wrapping core/EmptyState children #1462

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jul 12, 2024

Problem

The elements in the login page are rendered wrongly since #1441. That's because the Flex component used for wrapping the core/EmptyState children. It is missing the "direction" prop for telling it to layout children vertically instead of horizontally. Moreover, it looks like a Stack element is a better choice for this case.

Solution

Adapt core/EmptyState for using an <Stack hasGutter> instead of a <Flex> configured to behave almost the same.

Testing

  • Tested manually

Screenshots

Before After
Screenshot from 2024-07-12 13-29-04 Screenshot from 2024-07-12 13-27-23

They are in a flex container that was laying out them horizontally
instead of vertically. The issue was quite notable in the login screen.
Using PF/Stack instead of a PF/Flex configured to (almost) the same than
the former.
@dgdavid dgdavid merged commit 0d3874b into master Jul 12, 2024
2 checks passed
@dgdavid dgdavid deleted the fix-login branch July 12, 2024 12:31
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants