Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CI integration test #1491

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Updated CI integration test #1491

merged 2 commits into from
Jul 23, 2024

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jul 23, 2024

Problem

  • The old integration test did not work and has been disabled

Solution

  • Switch the test from Playwright to Puppeteer

Testing

  • The test run is green now
  • If the test fails the screenshot and the HTML page dump is included in the uploaded artifacts archive

run: podman exec agama bash -c "cd /checkout/playwright && SKIP_LOGIN=true playwright test --trace on --project chromium"
- name: Run the Puppeteer tests
# run the test
run: podman exec agama bash -c "cd /var/log/puppeteer &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cd looks kind of strange. should not agama-integration-tests script ensure that artifacts will be in correct place itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script itself saves the log to ./log/ so it's up to the caller where the logs will be saved.

In this case we use /var/log as it is already used for the YaST logs, but it could be anywhere else.

@lslezak lslezak merged commit bd2f35d into master Jul 23, 2024
@lslezak lslezak deleted the puppeteer_ci branch July 23, 2024 08:57
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants