fix(storage): avoid segmentation fault when generating actions #1419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The generation of the storage actions was fixed to avoid a segmentation fault while accessing to the
CompoundAction
objects, see #1410. But there is still a chance to reference to an actiongraph removed by the ruby GC.The actiongraph object could be dropped by the garbage collector while iterating the list of compound actions.
Solution
Keep a reference to the actiongraph, ensuring the actiongraph object is not removed while generating the list of actions.
Note: once the list of actions is generated, the actiongraph is not needed anymore because the
Action
objects do not keep a reference to the source compound action, see #1410.