Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less strict nokogiri dependency #1534

Merged
merged 2 commits into from
Aug 12, 2024
Merged

less strict nokogiri dependency #1534

merged 2 commits into from
Aug 12, 2024

Conversation

jreidinger
Copy link
Contributor

Problem

TW has nokogiri 1.16 and SLFO has 1.15. Due to our strict dependencies we cannot build against both.

Solution

nokogiri follows semver, so it should be safe to depends only on minor version and not on patch level.

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just for completeness, this is an improvement over #1518, which fixed the problem for Factory but broke things for SLE-16 (and Leap 16)

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the Gemfile.lock file be updated to reflect the change?

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again. Now better with Gemfile.lock.

@ancorgs ancorgs merged commit e8579a9 into master Aug 12, 2024
4 checks passed
@ancorgs ancorgs deleted the less_strict_nokogiri branch August 12, 2024 12:14
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants