Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Y2Storage proposal for Agama #1552

Merged
merged 21 commits into from
Aug 27, 2024
Merged

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Aug 22, 2024

In order to implement the unattended behavior for storage described at auto_storage.md, we decided we need a new kind of proposal since we want to achieve things that would be impossible with Y2Storage::GuidedProposal or Y2Storage::AutoinstProposal.

This introduces a new Y2Storage::AgamaProposal that combines components from the mentioned existing proposals.

Replaces #1448

@coveralls
Copy link

Coverage Status

coverage: 72.214% (+0.9%) from 71.319%
when pulling 4211435 on ancorgs:storage_merge2
into 55fabd7 on openSUSE:master.

@ancorgs ancorgs mentioned this pull request Aug 22, 2024
@ancorgs ancorgs marked this pull request as ready for review August 22, 2024 12:35
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joseivanlopez

This comment was marked as resolved.

@ancorgs
Copy link
Contributor Author

ancorgs commented Aug 27, 2024

Only a changelog entry is missing.

I was thinking about that.

This only introduces changes under the hood, nothing that would be really visible or usable by the users yet.

This will become relevant (like really usable by someone) when this other pull request is merged #1471 So the changelog entry belongs to there.

@ancorgs ancorgs merged commit 46f89e2 into agama-project:master Aug 27, 2024
3 checks passed
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants