chore(release): 2.96.0 #27132

aws-cdk-automation · 2023-09-13T15:41:40Z

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.95.0/CHANGELOG.md)

Use the `error.name` field to disambiguate errors in custom resource handlers. Instanceof has errors if the service team has not correctly modeled their errors which leads to ambiguity when detecting and handling specific errors returned from the service. In addition to running integ tests (besides eks), I verified that all of the error class constructors we were previously referencing do in fact have the matching hardcoded `name` field defined. IE <img width="538" alt="image" src="https://github.com/aws/aws-cdk/assets/7221111/5495d744-592c-4332-bbc1-2fa3f6527bdd"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…#27049) It will be easier to reuse SDKv3 related code from this other location. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Currently, the description regarding default value for `completionWindow` is incorrect. https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_backup.BackupPlanRuleProps.html#completionwindow > Type: Duration (optional, default: 8 hours) Correct value is 7 days (10080 minutes). Closes #27050 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…t8Array (#27065) The SDKv3 has changed the input representation of `blob` types from `string | Buffer | Uint8Array` to `Uint8Array`. That means all places where customers were passing in `strings` now fail to pass the right kind of value. Similar to #27034, but for `AwsCustomResource`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…it time (#27068) This PR updates the wait time of the `delete-existing-record-set-handler` from 60 to 1800 seconds. Commit 399b6bb upgraded the handler to use the AWS SDK V3 (was V2) and made the following change: ``` - await route53.waitFor('resourceRecordSetsChanged', { Id: changeResourceRecordSets.ChangeInfo.Id }).promise(); + await waitUntilResourceRecordSetsChanged({ client: route53, maxWaitTime: 60 }, { Id: changeResourceRecordSets?.ChangeInfo?.Id }) ``` The V2 `route53.waitFor` waits for 1800 seconds (see [reference](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Route53.html#waitFor-property)) > `Waits for the resourceRecordSetsChanged state by periodically calling the underlying [Route53.getChange()](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Route53.html#getChange-property) operation every 30 seconds (at most 60 times).` The new explicit configuration was set to 60 seconds which is too short and caused timeouts and failure in our cloudformation stacks Supersedes and closes #27060 Co-authored-by: Tom Roshko [hi@pistazie.rocks](mailto:hi@pistazie.rocks) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…is instead of scope (#27075) `CfnGlobalTable` in the constructor of `TableV2` was incorrectly using `scope` instead of `this`. As a result, `TableV2` was not generating correct logical IDs. Closes #27062 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…onds (#27076) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

graduates the alpha module. All users of any `ManagedComputeEnvironment` who left `updateToLatestImageVersion` unspecified will see it default to `undefined` instead of `true`. *If you use `FargateComputeEnvironment`, this upgrade may cause deployment errors; destroy the Fargate CE and recreate it to resolve this, if encountered.* Related: #27054. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.95.1/CHANGELOG.md)

Add support for selecting Amazon Linux 2023 ECS Optimized images. Reference: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_AMI.html Closes #26988. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

… contributing guide (#27072) The new markdown syntax is from [here](https://github.com/orgs/community/discussions/16925) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…gate (#27081) Currently, CDK document includes the following description. https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs-readme.html#environment-variables > Support for environment files is restricted to the EC2 launch type for files hosted on S3. However, this is out of date. Fargate has been [supported environment files](https://aws.amazon.com/jp/blogs/containers/latest-updates-to-aws-fargate-for-amazon-ecs/), and this restriction on CDK had been already removed by #11820. This PR removes the out of date description from document. Closes #18226 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Updated the type annotations to use the primitive `boolean` type instead of the object wrapper `Boolean`. This change aligns with TypeScript's recommended naming conventions and provides clearer type indications. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

We were finding blob parameter types in structures and lists, but had forgotten about maps and unions (such as used in DynamoDB). Include those as well. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Since the conversion of SDKv2 to SDKv3 of the `AwsCustomResource`, this custom resource was broken with the following error: ``` SerializationException: STRING_VALUE can not be converted to an Integer ``` The reason is that SDKv2 used to accept strings and coerce them to numbers wherever necessary, but SDKv3 does not do this anymore. Update the Custom Resource usage to no longer stringify the numbers. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…ry (#27092) #27009 introduced support for `Uint8Array` if users want to send data with the same types as those declared in the SDK v3 API. But existing tests, that use strings, will break. Apply type coercion when necessary. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…Endpoints (#27093) This also tests the usage of AwsCustomResource to describe security groups. Manually tested the unhappy path: If not SG can be found, the stack deployment fails as expected. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Changing the table structure to include an initial `TableBase` abstract class, allowing different tables of different data sources to be created from. Initially there are two, `S3Table` and `ExternalTable`. - `S3Table`: The current table structure that has been used throughout the previous versions of the CDK - `ExternalTable`: The new glue table that will be used to store metadata about external data sources. This subclass will contain an `externalDataLocation` property to explicitly specify the `Location` property of the underlying `CfnTable` L1 construct - `Table`: This is now `@deprecated` to shift the usage towards `S3Table` Closes #24741. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

AWS Service Spec packages to latest versions.

…27096) The source code in `custom-resource-handlers` was not included in the `npm pack` and thus unavailable to customers. This PR includes it. Tested by running `npm pack` and confirming its existence and also testing it the resulting package on a local cdk app. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Upgrades remaining runtime versions from `NODEJS_16_X` (which enters EOL on 2023-09-11 and will enter Lambda's Deprecation Phase 1 on Mar 11 2024) to NODEJS_18_X. Also updates remaining unit & integration tests to use NODEJS_LATEST or NODEJS_18_X. Most tests will reference the lambda runtime version via a new centralized configuration. Updated a number of test handlers to use SDKv3 and cleaned-up some duplicated, unused handler files. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Adding an integ test for this custom resource with our new rule that each custom resource needs at least one integ test. There is nothing to assert here, since the custom resource calls an AWS api to return a string. Asserting it with the same api call seems redundant. Instead, I'm going with supplying a cfnOutput to the console, which shows the string is zookeeper related. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

) Experimental custom resource handlers should be airlifted to their experimental modules only. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…rce (#27106) Adding an integ test for this custom resource with our new rule that each custom resource needs at least one integ test. This integ test is asserting that one scram secret per user is being registered with the cluster when SASL/SCRAM authentication is used. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…of aws-stepfunctions (#27110) `definition` in Construct Props of `sfn.StateMachine` is already deprecated and `definitionBody` is recommended. README and docs still use `definition` in examples, and it's misleading for users. I replaced `definition` with `definitionBody` and `sfn.DefinitionBody.fromChainable(...)` in them. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…itory (#27115) It is not clear whether we can use image digest on `ContainerImage.fromEcrRepository`. Change the property name from `tag` to `tagOrDigest` to clarify the ability to use image digest. Also add document about the parameter format. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Adding an integ test for this custom resource with our new rule that each custom resource needs at least one integ test. Adding this test for the custom resource to test out AWS Amplify app. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Adds integration test for using cross-region reference custom resource handlers. Currently cross region multi-stack tests in `IntegTest` are not super well supported so assertions aren't a great option but a successful stack deploy and delete does indicate success of the CRs currently. Closes #27069 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

For technical reasons, the way we were importing `minimatch` works in the current version of TypeScript, but is actually illegal according to the ESM spec. This poses problems when running `aws-cdk-lib` through `esbuild`. Update to a different import style that is correct in both. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

I found a legit zip [here](https://github.com/aws/aws-cdk/blob/d8acc8aa07867be1b1b3cad05b67dab2d7bc3252/packages/%40aws-cdk/aws-codepipeline-actions/test/assets/nodejs.zip). Closes #27117. <img width="1211" alt="Screenshot 2023-09-12 at 6 46 22 PM" src="https://github.com/aws/aws-cdk/assets/3310356/1de56fcf-1f99-4095-b2d9-1668bd443a9f"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

With Triggers a user can invoke a Lambda Function during every stack deployment. When we migrated the handler code to SDKv3, we overlooked that the return payload from the invoked lambda function is now a `Uint8Array`, and not a string anymore. In the error case, we attempt to `JSON.parse()` the error payload which then resulted in a list of bytes being returned to the user. Updated the handler test case to use correct mocks, including returning a payload that is a Uint8Array. Closes #27113 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@peterwoodworth

…runtime (#27109) This PR addresses an issue encountered when setting up an AWS CDK pipeline where unresolved token values for the `repoString` parameter led to a runtime error. The updated docstring now explicitly mentions that the `repoString` must be resolvable at runtime and that unresolved tokens are intended to be a runtime error Closes #27100. Thanks to @peterwoodworth for the quick assessment and the proposed solution to the problem. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@iliapolo

…7122) This PR fixes an issue where our assertions handler will fail when logging the response of an API call if the response body is a Blob. Specifically, the following error is thrown: ``` Converting circular structure to JSON --> starting at object with constructor 'TLSSocket' | property 'parser' -> object with constructor 'HTTPParser' --- property 'socket' closes the circle (RequestId: 50c1b6cd-47d2-494f-baf1-d22646cd4e5f) ``` The fix for this issue was to call the `transformToString` method on the response body. This is mentioned in aws-sdk-js-v3 [`UPGRADE.md`](https://github.com/aws/aws-sdk-js-v3/blob/main/UPGRADING.md?plain=1#L573-L576) as the solution for `Lambda::Invoke`. Its unclear why `S3::GetObject` isn't mentioned as well, but it works for that too. However, instead of explicitly extracting the `Body` property from a response, we now recursively traverse the response and detect any such blob types that should be converted to strings - this should protect us against any other APIs that may exhibit this behavior. > `transformToString` is implemented as part of the [`SdkStreamMixin` interface](https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-smithy-types/Interface/SdkStreamMixin/). Included in this PR is a fix for `aws-s3-deployment/test/integ.bucket-deployment-substitution.ts` which was previously failing with the error shown above. Co-authored by: @iliapolo Co-authored by: @vinayak-kukreja Co-authored by: @scanlonp Closes #27114 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2023-09-13T16:05:07Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 4c2130c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2023-09-13T16:05:42Z

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot and others added 30 commits September 7, 2023 23:11

chore(merge-back): 2.95.0 (#27057)

ffd4b7d

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.95.0/CHANGELOG.md)

chore: move AwsCustomResource to the custom resource handlers package (…

4eb3aed

…#27049) It will be easier to reuse SDKv3 related code from this other location. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

fix(custom-resources): maxwaittime reduced to 60 seconds from 300 sec…

c3a4b7b

…onds (#27076) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Merge branch 'main' into merge-back/2.95.1

47143dd

chore(merge-back): 2.95.1 (#27079)

7161005

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.95.1/CHANGELOG.md)

feat: update AWS Service Spec (#27095)

4942658

AWS Service Spec packages to latest versions.

chore: github actions do not accept node18 (#27104)

74c9b6a

clueleaf and others added 9 commits September 12, 2023 13:25

chore(release): 2.96.0

4c2130c

aws-cdk-automation added auto-approve pr/no-squash This PR should be merged instead of squash-merging it labels Sep 13, 2023

github-actions bot added the p2 label Sep 13, 2023

aws-cdk-automation requested a review from a team September 13, 2023 15:41

github-actions bot approved these changes Sep 13, 2023

View reviewed changes

aws-cdk-automation had a problem deploying to test-pipeline September 13, 2023 15:43 — with GitHub Actions Failure

mergify bot merged commit e6322aa into v2-release Sep 13, 2023
25 of 26 checks passed

mergify bot deleted the bump/2.96.0 branch September 13, 2023 16:06

github-actions bot mentioned this pull request Oct 1, 2023

Monthly PRs metrics report - Sep 2023 #27368

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(release): 2.96.0 #27132

chore(release): 2.96.0 #27132

aws-cdk-automation commented Sep 13, 2023 •

edited

Loading

aws-cdk-automation commented Sep 13, 2023

mergify bot commented Sep 13, 2023

chore(release): 2.96.0 #27132

chore(release): 2.96.0 #27132

Conversation

aws-cdk-automation commented Sep 13, 2023 • edited Loading

aws-cdk-automation commented Sep 13, 2023

AWS CodeBuild CI Report

mergify bot commented Sep 13, 2023

aws-cdk-automation commented Sep 13, 2023 •

edited

Loading