fix: update visibility to support parent overflow:clip without height/width #29778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jennifer-shehane
previously requested changes
Jul 2, 2024
There was a problem hiding this comment.
@senpl The visibility spec is failing in Firefox for this PR. Please address.
|
Fixed for firefox. Fix is now not that general but still fix reported issue. |
|
We've decided to prioritize looking into these visibility fixes in Quarter 4 of this year, when we intend to spend time on Cypress 14 release. It will ease any concerns we have around releasing breaking changes with these fixes and also help us plan the proper time to review these. Tracking here: #29925 |
|
Updated the base branch to go against release/14.0.0 |
jennifer-shehane
requested review from
mschile
and removed request for
jennifer-shehane
mschile
changed the title
ryanthemanuel
approved these changes
Nov 20, 2024
AtofStryker
approved these changes
Dec 2, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
overflow:clip was added in Chrome 90 and was never incorporated back into the visibility logic. Added
clipto theOVERFLOW_PROPSto correctly handle visibility checks.Note: this PR does not address the overflow-clip-margin property which has limited support in browsers.
Steps to test
Verify when a parent element has
overflow:clipand no height/width, a child element now returns ashidden.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?