breaking: remove logic around min supported browsers #30462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: remove logic around min supported browsers
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-browser-version-warnings
|
| Run status |
|
| Run duration | 21m 24s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
1327
|
Skipped
|
0
|
Passing
|
29368
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.11%
|
|
|---|---|
|
Untested elements
|
189
|
|
Tested elements
|
166
|
Accessibility
92.55%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
896
|
ryanthemanuel
approved these changes
Oct 28, 2024
mschile
approved these changes
Oct 28, 2024
…cypress-io/cypress into remove-browser-version-warnings
mschile
approved these changes
Nov 1, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With Cypress 14, we're updated our browser support stance to no longer be hardcoded minimum browser versions, but to support the last 3 major versions for Chrome, Firefox, and Edge. See #29977
This PR removes the logic in the App around handling the minimum versions of the browsers - and logic to show warnings to users when their browser is below that version.
Additionally, this removes the
minSupportedVersionfromCypress.browser, but you can see from the documentation that these properties were never externally documented: https://docs.cypress.io/api/cypress-api/browserSteps to test
How has the user experience changed?
Users of very very old browsers that weren't supported will no longer see a warning on those versions.
PR Tasks
cypress-documentation?type definitions?