Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade electron to 32.2.0 #30394

Merged
merged 98 commits into from
Oct 29, 2024

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Oct 10, 2024

Additional details

There are several things to call out in this upgrade:

Steps to test

How has the user experience changed?

PR Tasks

@ryanthemanuel ryanthemanuel marked this pull request as ready for review October 10, 2024 17:59
Copy link

cypress bot commented Oct 10, 2024

cypress    Run #57967

Run Properties:  status check passed Passed #57967  •  git commit 32ea2510e5: Merge branch 'release/14.0.0' into ryanm/chore/electron-upgrade
Project cypress
Branch Review ryanm/chore/electron-upgrade
Run status status check passed Passed #57967
Run duration 17m 05s
Commit git commit 32ea2510e5: Merge branch 'release/14.0.0' into ryanm/chore/electron-upgrade
Committer Ryan Manuel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 26
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 770
View all changes introduced in this branch ↗︎
UI Coverage  67.07%
  Untested elements 25  
  Tested elements 55  
Accessibility  96.17%
  Failed rules  0 critical   4 serious   1 moderate   0 minor
  Failed elements 203  

@AtofStryker AtofStryker self-requested a review October 24, 2024 17:54
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanthemanuel
Copy link
Collaborator Author

@ryanthemanuel I believe we can remove this line of code: develop/cli/lib/exec/spawn.js#L46 since this was fixed here: electron/electron#35961

@jennifer-shehane updated here: 609dee4 (#30394)

cli/CHANGELOG.md Outdated Show resolved Hide resolved
cypress-bot[bot] and others added 3 commits October 28, 2024 18:16
@ryanthemanuel ryanthemanuel merged commit 9fda261 into release/14.0.0 Oct 29, 2024
127 of 129 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/chore/electron-upgrade branch October 29, 2024 19:55
@jennifer-shehane jennifer-shehane mentioned this pull request Oct 30, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants