Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check_network_version script does not clean used docker containers #2084

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Aug 26, 2024

Issue being fixed or feature implemented

check_network_version script does not delete docker containers after use

What was done?

Added --rm to docker invocation.

How Has This Been Tested?

Run locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov previously approved these changes Aug 30, 2024
@shumkov shumkov changed the base branch from v1.2-dev to master September 4, 2024 13:17
lklimek and others added 21 commits September 4, 2024 15:53
Co-authored-by: Lukasz Klimek <842586+lklimek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants