Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to features/source-generators #47492

Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into features/source-generators.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout merges/master-to-features/source-generators
git reset --hard upstream/features/source-generators
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-features/source-generators --force

sharwell and others added 30 commits August 27, 2020 16:38
* Remove IActiveStatementSpanTracker

* ActiveStatementSpanProvider

Co-authored-by: Tomas Matousek <tomat@microsoft.com>
…ActionsSource.cs

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
* Don't load generators that target net framework explicitly.

* Do lookup based on TargetFrameworkAttribute rather than mscorlib reference

* PR feedback:
- Remove test resources and create generators on the fly
- Reword some text

* Build the compilation manually, rather than importing createCompilation
Cache semantic classifications and display from the cache while a solution is loading.
Clean up redundant code action filtering
Disable API analysis if telemetry is disabled
Make VerifyForwardedTypes asynchronous
* upstream/master: (220 commits)
  Don't load generators that target net framework explicitly. (#47100)
  Update src/Features/Core/Portable/UnifiedSuggestions/UnifiedSuggestedActionsSource.cs
  Clean up redundant code action filtering
  Remove IActiveStatementSpanTracker (#46826)
  Disable API analysis if telemetry is disabled
  Update src/Workspaces/Remote/ServiceHub/Services/CodeAnalysis/CodeAnalysisService_SemanticClassificationCache.cs
  Doc
  Compress two values.
  PR feedback
  Revert
  Revert
  Lint
  Fix formatting
  Fire and forget
  Fix mangling
  Ensure that local functions are also marked as invalid if their containing methods are generic.
  Fix dependency graph for AnalyzerRunner
  Add AnalyzerRunner target for net5.0
  Make VerifyForwardedTypes asynchronous
  Fix bug when "End statement" is used in single-line if (#47062)
  ...
Remove unnecessary initialize request to liveshare server from livesh…
Fix CodeLens data point invalidation
Bail out early before getting SyntaxTree
Update remaining references to MyGet with Azure DevOps
Fixes #47214
Verified the issue repros prior to the fix and is resolved after this change.
* Add XAML LSP handlers for formatting and auto insert and update existing handlers to minimize breaking changes going forward.

* TextDocument => DocumentId

* Switch to object initializer
It fails in CI and it's not obvious why yet, so let's not hold up
everything on that.
333fred and others added 19 commits September 4, 2020 13:34
* Adjusted small nits
* Fixed release-only baseline.
…ions. (#47422)

Nameof's subexpressions do not require receivers, so this prevents us from having to handle that.
Fixes #46593
…xit of a decision dag (#47407)

in the face of multiple when clauses, for the purpose of constructing the "not exhaustive" diagnostic.
Fixes #47164
Use static lambdas to better express intent concisely
* Remove TODO from public documentation

* Update SyntaxNode.cs

* Update src/Compilers/Core/Portable/Syntax/SyntaxNode.cs

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
Issue Errors on calls to UnmanagedCallersOnly-attributed methods
Fix and un-skip PropertySubPatternCompletionProviderTests and GenerateVariableTests
Serialize document states without loading text
@ghost
Copy link

ghost commented Sep 6, 2020

Hello @dotnet-bot!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit c341528 into features/source-generators Sep 6, 2020
@ghost ghost deleted the merges/master-to-features/source-generators branch September 6, 2020 17:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.