Update error decoder URL #27240

rickhanlonii · 2023-08-17T21:14:51Z

Updates the error decoder to the URL for the new docs site.

Switches the domain from reactjs.org to react.dev
Switches to put the error code in the URL for SSG
All params are still in the query

Example without args:

Before: https://reactjs.org/docs/error-decoder.html?invariant=200
After: https://react.dev/errors/200

Example with args:

Before: https://reactjs.org/docs/error-decoder.html?invariant=124?args[]=foo&args[]=bar
After: https://react.dev/errors/124?args[]=foo&args[]=bar

Requires: reactjs/react.dev#6214

react-sizebot · 2023-08-17T21:22:02Z

Comparing: 5c60736...e42d72b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	+0.03%	176.19 kB	176.24 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	+0.03%	178.29 kB	178.34 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.89 kB	571.94 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.65 kB	555.70 kB	=	97.63 kB	97.62 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.production.min.js	+1.65%	2.73 kB	2.78 kB	=	1.16 kB	1.15 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.production.min.js	+1.65%	2.73 kB	2.78 kB	=	1.16 kB	1.15 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.production.min.js	+1.65%	2.73 kB	2.78 kB	=	1.16 kB	1.15 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.min.js	+1.29%	3.49 kB	3.53 kB	=	1.24 kB	1.24 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.min.js	+1.28%	3.52 kB	3.56 kB	=	1.26 kB	1.26 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.min.js	+1.28%	3.52 kB	3.57 kB	=	1.26 kB	1.26 kB
oss-stable-semver/react-dom/umd/react-dom-server-rendering-stub.production.min.js	+1.24%	3.63 kB	3.68 kB	=	1.34 kB	1.34 kB
oss-stable/react-dom/umd/react-dom-server-rendering-stub.production.min.js	+1.23%	3.66 kB	3.70 kB	=	1.36 kB	1.36 kB
oss-experimental/react-dom/umd/react-dom-server-rendering-stub.production.min.js	+1.23%	3.66 kB	3.71 kB	=	1.36 kB	1.36 kB
oss-stable-semver/react-dom/cjs/react-dom-server-rendering-stub.production.js	+0.78%	8.97 kB	9.04 kB	+0.27%	2.24 kB	2.24 kB
oss-stable/react-dom/cjs/react-dom-server-rendering-stub.production.js	+0.78%	8.99 kB	9.06 kB	+0.22%	2.26 kB	2.27 kB
oss-experimental/react-dom/cjs/react-dom-server-rendering-stub.production.js	+0.78%	9.00 kB	9.07 kB	+0.22%	2.26 kB	2.27 kB
oss-stable-semver/react/cjs/react.react-server.production.min.js	+0.67%	6.72 kB	6.77 kB	=	2.89 kB	2.89 kB
oss-stable/react/cjs/react.react-server.production.min.js	+0.67%	6.75 kB	6.79 kB	=	2.92 kB	2.91 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.production.js	+0.66%	10.58 kB	10.65 kB	+0.19%	3.12 kB	3.13 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.production.js	+0.66%	10.58 kB	10.65 kB	+0.19%	3.12 kB	3.13 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.production.js	+0.66%	10.58 kB	10.65 kB	+0.19%	3.12 kB	3.13 kB
oss-experimental/react/cjs/react.react-server.production.min.js	+0.49%	9.25 kB	9.29 kB	=	3.76 kB	3.75 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.min.js	+0.42%	10.43 kB	10.48 kB	=	4.02 kB	4.01 kB
oss-stable/react-client/cjs/react-client-flight.production.min.js	+0.42%	10.43 kB	10.48 kB	=	4.02 kB	4.01 kB
oss-experimental/react-client/cjs/react-client-flight.production.min.js	+0.38%	11.62 kB	11.67 kB	=	4.35 kB	4.35 kB
facebook-www/ReactServer-prod.modern.js	+0.36%	14.17 kB	14.22 kB	=	3.83 kB	3.82 kB
oss-stable-semver/react/cjs/react.react-server.production.js	+0.25%	28.26 kB	28.33 kB	+0.08%	8.50 kB	8.51 kB
oss-stable/react/cjs/react.react-server.production.js	+0.25%	28.29 kB	28.36 kB	+0.07%	8.53 kB	8.54 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against e42d72b

packages/shared/formatProdErrorMessage.js

Updates the error decoder to the URL for the new docs site. - Switches the domain from reactjs.org to react.dev - Switches to put the error code in the URL for SSG - All params are still in the query Example without args: - Before: `https://reactjs.org/docs/error-decoder.html?invariant=200` - After: ` https://react.dev/errors/200` Example with args: - Before: `https://reactjs.org/docs/error-decoder.html?invariant=124?args[]=foo&args[]=bar ` - After: ` https://react.dev/errors/124?args[]=foo&args[]=bar` Requires: reactjs/react.dev#6214 --------- Co-authored-by: Jan Kassens <jkassens@meta.com> DiffTrain build for [b300304](b300304)

Updates the error decoder to the URL for the new docs site. - Switches the domain from reactjs.org to react.dev - Switches to put the error code in the URL for SSG - All params are still in the query Example without args: - Before: `https://reactjs.org/docs/error-decoder.html?invariant=200` - After: ` https://react.dev/errors/200` Example with args: - Before: `https://reactjs.org/docs/error-decoder.html?invariant=124?args[]=foo&args[]=bar ` - After: ` https://react.dev/errors/124?args[]=foo&args[]=bar` Requires: reactjs/react.dev#6214 --------- Co-authored-by: Jan Kassens <jkassens@meta.com>

Updates the error decoder to the URL for the new docs site. - Switches the domain from reactjs.org to react.dev - Switches to put the error code in the URL for SSG - All params are still in the query Example without args: - Before: `https://reactjs.org/docs/error-decoder.html?invariant=200` - After: ` https://react.dev/errors/200` Example with args: - Before: `https://reactjs.org/docs/error-decoder.html?invariant=124?args[]=foo&args[]=bar ` - After: ` https://react.dev/errors/124?args[]=foo&args[]=bar` Requires: reactjs/react.dev#6214 --------- Co-authored-by: Jan Kassens <jkassens@meta.com> DiffTrain build for commit b300304.

rickhanlonii requested a review from sophiebits August 17, 2023 21:14

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 17, 2023

rickhanlonii mentioned this pull request Aug 17, 2023

Feat: error-decoder reactjs/react.dev#6214

Merged

rickhanlonii force-pushed the rh/error-url branch from de927e6 to 980f60b Compare August 17, 2023 21:47

prabodhmeshram reviewed Aug 21, 2023

View reviewed changes

packages/shared/formatProdErrorMessage.js Show resolved Hide resolved

rickhanlonii added 2 commits January 12, 2024 17:27

Update error decoder URL

39a4400

Fix tests

b7efd53

rickhanlonii force-pushed the rh/error-url branch from 5949944 to b7efd53 Compare January 12, 2024 22:27

kassens approved these changes Jan 17, 2024

View reviewed changes

kassens and others added 4 commits January 17, 2024 11:30

Merge branch 'main' into rh/error-url

0d9daba

Fix decode error message

e310da0

rm log

0d415bb

Fix regex again

e42d72b

rickhanlonii force-pushed the rh/error-url branch from 8b8d984 to e42d72b Compare January 18, 2024 01:29

rickhanlonii merged commit b300304 into facebook:main Jan 18, 2024
36 checks passed

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update error decoder URL #27240

Update error decoder URL #27240

rickhanlonii commented Aug 17, 2023

react-sizebot commented Aug 17, 2023 •

edited

Loading

Update error decoder URL #27240

Update error decoder URL #27240

Conversation

rickhanlonii commented Aug 17, 2023

react-sizebot commented Aug 17, 2023 • edited Loading

Critical size changes

Significant size changes

react-sizebot commented Aug 17, 2023 •

edited

Loading