Convert ReactDOMOption to createRoot #28002

eps1lon · 2024-01-19T12:34:45Z

No description provided.

eps1lon · 2024-01-19T12:35:19Z

packages/react-dom/src/__tests__/ReactDOMOption-test.js

+      ],
+      {withoutStack: 1},
+    );
+    option = container.firstChild.firstChild;


The entire markup is now replaced with client rendering so we need to capture the newly created option

Oh I guess I should actually read the comment huh

react-sizebot · 2024-01-19T12:38:22Z

Comparing: feed8f3...88556a8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.24 kB	176.24 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.34 kB	178.34 kB	=	55.52 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.94 kB	571.94 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.70 kB	555.70 kB	=	97.62 kB	97.62 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 88556a8

rickhanlonii · 2024-01-19T15:38:23Z

scripts/jest/matchers/toWarnDev.js

@@ -86,7 +86,8 @@ const createMatcherFor = (consoleMethod, matcherName) =>
        // doesn't match the number of arguments.
        // We'll fail the test if it happens.
        let argIndex = 0;
-        format.replace(/%s/g, () => argIndex++);
+        // console.* could have been called with a non-string e.g. `console.error(new Error())`


I don't follow.

This comment supposed to explain why we need a string cast here. We used to assume console.error was always called with a string as its first argument. But when I migrated the test in this PR, it crashed at this line because format was not actually a string.

DiffTrain build for commit 206934f.

Convert ReactDOMOption to createRoot

c7afadd

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 19, 2024

eps1lon commented Jan 19, 2024

View reviewed changes

Make toErrorDev assertion agnostic to test matrix

88556a8

eps1lon force-pushed the test/create-root/ReactDOMOption branch from e58df2b to 88556a8 Compare January 19, 2024 13:06

eps1lon marked this pull request as ready for review January 19, 2024 13:19

rickhanlonii approved these changes Jan 19, 2024

View reviewed changes

eps1lon merged commit 206934f into facebook:main Jan 22, 2024
36 checks passed

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

eps1lon deleted the test/create-root/ReactDOMOption branch February 18, 2024 15:54

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert ReactDOMOption to createRoot (facebook#28002)

cbafb7f

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert ReactDOMOption to createRoot (#28002)

3c15716

DiffTrain build for commit 206934f.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ReactDOMOption to createRoot #28002

Convert ReactDOMOption to createRoot #28002

eps1lon commented Jan 19, 2024

eps1lon Jan 19, 2024

rickhanlonii Jan 20, 2024

react-sizebot commented Jan 19, 2024 •

edited

Loading

rickhanlonii Jan 19, 2024

eps1lon Jan 19, 2024

Convert ReactDOMOption to createRoot #28002

Convert ReactDOMOption to createRoot #28002

Conversation

eps1lon commented Jan 19, 2024

eps1lon Jan 19, 2024

Choose a reason for hiding this comment

rickhanlonii Jan 20, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 19, 2024 • edited Loading

Critical size changes

Significant size changes

rickhanlonii Jan 19, 2024

Choose a reason for hiding this comment

eps1lon Jan 19, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 19, 2024 •

edited

Loading