Convert describeComponentFrame to createRoot

[eps1lon]

Not gated in yarn test packages/shared/__tests__/describeComponentFrame-test.js --env production -r=www-classic

[react-sizebot]

Comparing: feed8f3...1b4f905

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.24 kB	176.24 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.34 kB	178.34 kB	=	55.52 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.94 kB	571.94 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.70 kB	555.70 kB	=	97.62 kB	97.62 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 1b4f905

[rickhanlonii]

for (let i = 0; i < fileNames.length; i++) {

or

for (let [i, fileName] of fileNames.entries()) {

?

[eps1lon]

fileNames is an object so a basic for loop would also be awkward. We already had precedent below to iterate over fileNames with for-in and manual increments.

for-of would trigger lint violations and while it's likely a false-positive for tests, I just stuck with what's already there. But I agree that for-in with increments is pretty unorthodox.