Clean up legacy render from ReactTestUtilsAct-test #28091

jackpope · 2024-01-25T18:39:54Z

No description provided.

react-sizebot · 2024-01-25T18:45:33Z

Comparing: a41ebfc...1ce5609

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.34 kB	176.34 kB	=	54.93 kB	54.93 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.44 kB	178.44 kB	=	55.57 kB	55.57 kB
facebook-www/ReactDOM-prod.classic.js	=	572.79 kB	572.79 kB	=	100.80 kB	100.80 kB
facebook-www/ReactDOM-prod.modern.js	=	556.55 kB	556.55 kB	=	97.88 kB	97.88 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 1ce5609

jackpope · 2024-01-25T19:47:07Z

packages/react-dom/src/__tests__/ReactTestUtilsAct-test.js

-    );
-  }
-
-  // and then in legacy mode


This test previously ran against both legacy and concurrent modes. It doesn't seem to me that we need to maintain legacy coverage against act for now but I can move the cases into a separate internal test if folks think otherwise.

Co-authored-by: Jack Pope <jackpope@meta.com>

Co-authored-by: Jack Pope <jackpope@meta.com>

Co-authored-by: Jack Pope <jackpope@meta.com> DiffTrain build for commit 91212b0.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 25, 2024

Clean up legacy render from ReactTestUtilsAct-test

1ce5609

jackpope force-pushed the react-test-utils-act branch from 6e41109 to 1ce5609 Compare January 25, 2024 19:02

jackpope commented Jan 25, 2024

View reviewed changes

jackpope marked this pull request as ready for review January 25, 2024 19:48

rickhanlonii approved these changes Jan 26, 2024

View reviewed changes

rickhanlonii merged commit 91212b0 into facebook:main Jan 27, 2024
36 checks passed

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

gaearon pushed a commit that referenced this pull request Feb 3, 2024

Clean up legacy render from ReactTestUtilsAct-test (#28091)

7dacdc1

Co-authored-by: Jack Pope <jackpope@meta.com>

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Clean up legacy render from ReactTestUtilsAct-test (facebook#28091)

1993c1e

Co-authored-by: Jack Pope <jackpope@meta.com>

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Clean up legacy render from ReactTestUtilsAct-test (#28091)

3e90bd4

Co-authored-by: Jack Pope <jackpope@meta.com> DiffTrain build for commit 91212b0.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up legacy render from ReactTestUtilsAct-test #28091

Clean up legacy render from ReactTestUtilsAct-test #28091

jackpope commented Jan 25, 2024

react-sizebot commented Jan 25, 2024 •

edited

Loading

jackpope Jan 25, 2024

Clean up legacy render from ReactTestUtilsAct-test #28091

Clean up legacy render from ReactTestUtilsAct-test #28091

Conversation

jackpope commented Jan 25, 2024

react-sizebot commented Jan 25, 2024 • edited Loading

Critical size changes

Significant size changes

jackpope Jan 25, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 25, 2024 •

edited

Loading