[Fizz] Support aborting with Postpone #28183

gnoff · 2024-02-01T06:31:32Z

Semantically if you make your reason for aborting a Postpone instance the render should not hit the error pathways but should instead follow the postpone pathways. It's awkward today to actually get your hands on a Postpone instance because you have to catch the throw from postpone and then pass that into abort() or AbortController.abort() (depending on the renderer API you are using)

This change makes it so that in most circumstances if you abort with a postpone the onPostpone handler will be called and the Suspense boundaries still pending will be put into client render mode with the appropriate postpone digest to avoid trigger recoverable error pathways on the client.

Similar to postponing in the shell during a resume or render however if you abort before the shell is complete in a resume or render we will fatally error. The fatal error is contextualized by React to avoid passing the postpone object itself to the onError and related options.

…While it is ackward to get your hands ona Postpone object to abort with it does semantically signal that you want to intentionally halt the render and that the abort is not erroneous. It will still put boundaries into fallback and do the usual cleanup.

react-sizebot · 2024-02-01T06:36:22Z

Comparing: d29f7d9...761a236

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/react-server/cjs/react-server.production.min.js	+0.82%	41.16 kB	41.50 kB	+0.54%	12.94 kB	13.01 kB
oss-experimental/react-server/cjs/react-server.production.js	+0.68%	166.57 kB	167.71 kB	+0.34%	38.54 kB	38.67 kB
oss-experimental/react-server/cjs/react-server.development.js	+0.54%	210.10 kB	211.24 kB	+0.27%	49.01 kB	49.14 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js	+0.40%	85.79 kB	86.13 kB	+0.22%	25.99 kB	26.05 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.min.js	+0.38%	88.79 kB	89.13 kB	+0.29%	27.16 kB	27.24 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js	+0.37%	90.98 kB	91.32 kB	+0.22%	27.64 kB	27.70 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.min.js	+0.37%	92.75 kB	93.10 kB	+0.21%	28.44 kB	28.50 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js	+0.34%	330.40 kB	331.53 kB	+0.18%	71.43 kB	71.56 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js	+0.34%	338.34 kB	339.47 kB	+0.17%	73.75 kB	73.88 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js	+0.33%	343.30 kB	344.44 kB	+0.18%	73.44 kB	73.57 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js	+0.33%	345.47 kB	346.60 kB	+0.18%	74.44 kB	74.57 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.production.min.js	+0.33%	82.96 kB	83.23 kB	+0.22%	25.57 kB	25.63 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.min.js	+0.33%	82.88 kB	83.15 kB	+0.19%	25.19 kB	25.24 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js	+0.33%	332.16 kB	333.24 kB	+0.16%	71.87 kB	71.98 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js	+0.32%	340.96 kB	342.04 kB	+0.16%	72.99 kB	73.10 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js	+0.31%	87.38 kB	87.65 kB	+0.15%	26.73 kB	26.77 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js	+0.31%	87.45 kB	87.72 kB	+0.14%	27.08 kB	27.12 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js	+0.27%	428.65 kB	429.79 kB	+0.14%	95.44 kB	95.57 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js	+0.26%	434.95 kB	436.09 kB	+0.14%	97.39 kB	97.52 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js	+0.26%	436.81 kB	437.95 kB	+0.13%	97.86 kB	97.99 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js	+0.26%	455.10 kB	456.29 kB	+0.13%	98.36 kB	98.48 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js	+0.26%	442.26 kB	443.40 kB	+0.13%	97.73 kB	97.86 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js	+0.26%	443.83 kB	444.97 kB	+0.14%	98.50 kB	98.63 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js	+0.26%	444.41 kB	445.55 kB	+0.14%	98.63 kB	98.77 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js	+0.25%	464.38 kB	465.56 kB	+0.13%	99.53 kB	99.66 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against 761a236

Semantically if you make your reason for aborting a Postpone instance the render should not hit the error pathways but should instead follow the postpone pathways. It's awkward today to actually get your hands on a Postpone instance because you have to catch the throw from postpone and then pass that into `abort()` or `AbortController.abort()` (depending on the renderer API you are using) This change makes it so that in most circumstances if you abort with a postpone the `onPostpone` handler will be called and the Suspense boundaries still pending will be put into client render mode with the appropriate postpone digest to avoid trigger recoverable error pathways on the client. Similar to postponing in the shell during a resume or render however if you abort before the shell is complete in a resume or render we will fatally error. The fatal error is contextualized by React to avoid passing the postpone object itself to the `onError` and related options. DiffTrain build for [1219d57](1219d57)

Semantically if you make your reason for aborting a Postpone instance the render should not hit the error pathways but should instead follow the postpone pathways. It's awkward today to actually get your hands on a Postpone instance because you have to catch the throw from postpone and then pass that into `abort()` or `AbortController.abort()` (depending on the renderer API you are using) This change makes it so that in most circumstances if you abort with a postpone the `onPostpone` handler will be called and the Suspense boundaries still pending will be put into client render mode with the appropriate postpone digest to avoid trigger recoverable error pathways on the client. Similar to postponing in the shell during a resume or render however if you abort before the shell is complete in a resume or render we will fatally error. The fatal error is contextualized by React to avoid passing the postpone object itself to the `onError` and related options.

Semantically if you make your reason for aborting a Postpone instance the render should not hit the error pathways but should instead follow the postpone pathways. It's awkward today to actually get your hands on a Postpone instance because you have to catch the throw from postpone and then pass that into `abort()` or `AbortController.abort()` (depending on the renderer API you are using) This change makes it so that in most circumstances if you abort with a postpone the `onPostpone` handler will be called and the Suspense boundaries still pending will be put into client render mode with the appropriate postpone digest to avoid trigger recoverable error pathways on the client. Similar to postponing in the shell during a resume or render however if you abort before the shell is complete in a resume or render we will fatally error. The fatal error is contextualized by React to avoid passing the postpone object itself to the `onError` and related options.

Semantically if you make your reason for aborting a Postpone instance the render should not hit the error pathways but should instead follow the postpone pathways. It's awkward today to actually get your hands on a Postpone instance because you have to catch the throw from postpone and then pass that into `abort()` or `AbortController.abort()` (depending on the renderer API you are using) This change makes it so that in most circumstances if you abort with a postpone the `onPostpone` handler will be called and the Suspense boundaries still pending will be put into client render mode with the appropriate postpone digest to avoid trigger recoverable error pathways on the client. Similar to postponing in the shell during a resume or render however if you abort before the shell is complete in a resume or render we will fatally error. The fatal error is contextualized by React to avoid passing the postpone object itself to the `onError` and related options. DiffTrain build for commit 1219d57.

facebook-github-bot added the CLA Signed label Feb 1, 2024

gnoff requested a review from sebmarkbage February 1, 2024 06:31

facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Feb 1, 2024

sebmarkbage approved these changes Feb 1, 2024

View reviewed changes

gnoff merged commit 1219d57 into facebook:main Feb 1, 2024
36 checks passed

gnoff deleted the abort-with-postpone branch February 1, 2024 15:14

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fizz] Support aborting with Postpone #28183

[Fizz] Support aborting with Postpone #28183

gnoff commented Feb 1, 2024

react-sizebot commented Feb 1, 2024

[Fizz] Support aborting with Postpone #28183

[Fizz] Support aborting with Postpone #28183

Conversation

gnoff commented Feb 1, 2024

react-sizebot commented Feb 1, 2024

Critical size changes

Significant size changes