Use createRoot in ReactDOMComponentTree-test #28112

jackpope · 2024-01-26T16:26:43Z

No description provided.

react-sizebot · 2024-01-26T16:31:19Z

Comparing: 6c64428...5f53e12

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.64 kB	176.64 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.74 kB	178.74 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.66 kB	573.66 kB	=	101.02 kB	101.02 kB
facebook-www/ReactDOM-prod.modern.js	=	557.42 kB	557.42 kB	=	98.10 kB	98.10 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 5f53e12

jackpope · 2024-01-26T16:32:56Z

packages/react-dom/src/__tests__/ReactDOMComponentTree-test.js

@@ -186,33 +204,4 @@ describe('ReactDOMComponentTree', () => {
        'https://reactjs.org/link/controlled-components',
    );
  });
-
-  it('finds instance of node that is attempted to be unmounted', () => {


Not sure there is a concurrent equivalent to this? Moved into legacy test

jackpope · 2024-01-26T16:33:06Z

packages/react-dom/src/__tests__/ReactDOMComponentTree-test.js

-    );
-  });
-
-  it('finds instance from node to stop rendering over other react rendered components', () => {


Same with this test case

DiffTrain build for commit 4c41c09.

Use createRoot in ReactDOMComponentTree-test

5f53e12

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2024

jackpope commented Jan 26, 2024

View reviewed changes

rickhanlonii approved these changes Jan 26, 2024

View reviewed changes

jackpope merged commit 4c41c09 into facebook:main Jan 26, 2024
36 checks passed

jackpope deleted the react-dom-component-tree branch January 26, 2024 22:18

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

gaearon pushed a commit that referenced this pull request Feb 3, 2024

Use createRoot in ReactDOMComponentTree-test (#28112)

16631c0

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Use createRoot in ReactDOMComponentTree-test (facebook#28112)

6f857fd

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Use createRoot in ReactDOMComponentTree-test (#28112)

1dd48c6

DiffTrain build for commit 4c41c09.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use createRoot in ReactDOMComponentTree-test #28112

Use createRoot in ReactDOMComponentTree-test #28112

jackpope commented Jan 26, 2024

react-sizebot commented Jan 26, 2024

jackpope Jan 26, 2024

jackpope Jan 26, 2024

Use createRoot in ReactDOMComponentTree-test #28112

Use createRoot in ReactDOMComponentTree-test #28112

Conversation

jackpope commented Jan 26, 2024

react-sizebot commented Jan 26, 2024

Critical size changes

Significant size changes

jackpope Jan 26, 2024

Choose a reason for hiding this comment

jackpope Jan 26, 2024

Choose a reason for hiding this comment