Created PR #2419 for unicorn/prefer-date-now

• infra(unicorn): prefer-date-now #2419

Created PR #2420 for unicorn/prefer-node-protocol

• infra(unicorn): prefer-node-protocol #2420

Created PR #2421 for unicorn/prefer-spread

• infra(unicorn): prefer-spread #2421

Note: The rule is contested.

Created PR #2440 for unicorn/no-hex-escape

• infra(unicorn): no-hex-escape #2440

Created PR #2441 for unicorn/no-new-array

• infra(unicorn): no-new-array #2441

Created PR #2442 for unicorn/prefer-string-starts-ends-with

• infra(unicorn): prefer-string-starts-ends-with #2442

Created PR #2443 for unicorn/prefer-object-from-entries

• infra(unicorn): prefer-object-from-entries #2443

Created PR #2444 for unicorn/require-array-join-separator

• docs: check and improve handling of duplicate tags #2444

Created PR #2445 for unicorn/prefer-native-coercion-functions

• infra(unicorn): prefer-native-coercion-functions #2445

Created PR #2446 for unicorn/prefer-array-flat-map

• infra(unicorn): prefer-array-flat-map #2446

Created PR #2447 for unicorn/no-console-spaces

• infra(unicorn): no-console-spaces #2447

Created PR #2448 for unicorn/no-process-exit

• infra(unicorn): use hashbang for scripts #2448

Created PR #2451 for unicorn/prefer-array-some

• infra(unicorn): prefer-array-some #2451

Created PR #2452 for unicorn/prefer-number-properties

• infra(unicorn): prefer-number-properties #2452

Created PR #3203 for unicorn/no-object-as-default-parameter

• infra(unicorn): permanently disable no-object-as-default-parameter #3203

@faker-js/members, @faker-js/maintainers I'm unsure about the consistent function scoping one.

• https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v56.0.0/docs/rules/consistent-function-scoping.md

It basically wants us to move most inline functions to be standalone methods.

e.g. convert from

  dish(): string {
    const toTitleCase = (s: string) =>
      s
        .split(' ')
        .map((w) => w.charAt(0).toUpperCase() + w.slice(1))
        .join(' ');

    return toTitleCase(
      this.faker.helpers.arrayElement(this.faker.definitions.food.dish)
    );
  }

to

const toTitleCase = (s: string) =>
      s
        .split(' ')
        .map((w) => w.charAt(0).toUpperCase() + w.slice(1))
        .join(' ');

[...]

  dish(): string {
    return toTitleCase(
      this.faker.helpers.arrayElement(this.faker.definitions.food.dish)
    );
  }

Also, what are your thoughts regarding

• unicorn/prefer-export-from
• unicorn/prevent-abbreviations

?

@faker-js/members, @faker-js/maintainers I'm unsure about the consistent function scoping one.

• sindresorhus/eslint-plugin-unicorn@v56.0.0/docs/rules/consistent-function-scoping.md

It basically wants us to move most inline functions to be standalone methods.

e.g. convert from

  dish(): string {
    const toTitleCase = (s: string) =>
      s
        .split(' ')
        .map((w) => w.charAt(0).toUpperCase() + w.slice(1))
        .join(' ');

    return toTitleCase(
      this.faker.helpers.arrayElement(this.faker.definitions.food.dish)
    );
  }

to

const toTitleCase = (s: string) =>
      s
        .split(' ')
        .map((w) => w.charAt(0).toUpperCase() + w.slice(1))
        .join(' ');

[...]

  dish(): string {
    return toTitleCase(
      this.faker.helpers.arrayElement(this.faker.definitions.food.dish)
    );
  }

This makes sense, because instead of every single function call, only once the function will be created and than reused for multiple calls of the outer function.

Created PR #3255 for unicorn/consistent-function-scoping

• infra(unicorn): consistent-function-scoping #3255

Created PR #3272 for unicorn/prefer-export-from

• infra(unicorn): prefer-export-from #3272

unicorn/prevent-abbreviations is going to be a large PR and I'm not entirely convinced the variable renames help that much.

IMO i is a well accepted index keyword. And even if we would rename these cases we would still need lots of ignores.
I created a few small (maybe too small?) PRs to address some reasonable suggestions, we can discuss how to proceed, once these are merged.

unicorn/prevent-abbreviations is going to be a large PR and I'm not entirely convinced the variable renames help that much.

IMO i is a well accepted index keyword. And even if we would rename these cases we would still need lots of ignores. I created a few small (maybe too small?) PRs to address some reasonable suggestions, we can discuss how to proceed, once these are merged.

I'm with you on this one. See my comment in #3315. While you could argue about some of the suggestions could be valid, I'd much rather see time spend on actual features or bug fixes for our users than having to fight in discussions about variable name nitpicking.

Finally 🥳

I created the last PR for this issue: #3320 for unicorn/prevent-abbreviations

• infra(unicorn): prevent-abbreviations #3320