Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.3.0 proposal #14452

Closed
wants to merge 64 commits into from
Closed

v8.3.0 proposal #14452

wants to merge 64 commits into from

Commits on Jul 24, 2017

  1. repl: fix old history error handling

    Backport-PR-URL: #14392
    Backport-Reviewed-By: James M Snell <jasnell@gmail.com>
    
    PR-URL: #13733
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    BridgeAR authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    32ba8ae View commit details
    Browse the repository at this point in the history
  2. test: fix error handling test-http-full-response

    The way it is currently written, test-http-full-response will fail if
    there is a problem with spawning that doesn't include `ab` or `api` in
    `stderr`, but it will fail with a misleading mismatched-calls
    `common.mustCall()` error.
    
    Alter the error handling so that it rethrows the actual error, providing
    better information.
    
    PR-URL: #14252
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    b5d0a03 View commit details
    Browse the repository at this point in the history
  3. doc: fix minor typo in cluster.md

    Adds a missing `'` in code example.
    
    PR-URL: #14353
    Fixes: #14352
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    lance authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    d2121ab View commit details
    Browse the repository at this point in the history
  4. test: replace concatenation with template literals

    Use template literals instead of string concatenation in
    test/parallel/test-http-extra-response.js
    
    PR-URL: #14296
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: David Cai <davidcai1993@yahoo.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    csvwolf authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    72febfd View commit details
    Browse the repository at this point in the history
  5. doc,stream: _transform happens one at a time

    Add a note to the stream docs specifying that at most a single
    call to _transform can happen, and the provided callback()
    should be used to process another chunk.
    
    Fixes: #3208
    PR-URL: #14321
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mcollina authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    53ad91c View commit details
    Browse the repository at this point in the history
  6. repl: don't terminate on null thrown

    Previous behavior was to assume an error is a proper error in the
    repl module. A check was added to not terminate the process on thrown
    repl errors that are `null` or `undefined`.
    
    PR-URL: #14306
    Fixes: #12373
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com
    Benjamin Gruenbaum authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    34821f6 View commit details
    Browse the repository at this point in the history
  7. doc: replace dead link in v8 module

    PR-URL: #14372
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    drboyer authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    dc0a26f View commit details
    Browse the repository at this point in the history
  8. test: replace string concat in test-fs-watchfile.js

    PR-URL: #14287
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Helianthus21 authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    3bc7d2a View commit details
    Browse the repository at this point in the history
  9. docs: add note about fs.rmdir()

    fs.rmdir() on the file (not directory) results in different errors on
    Windows to everything else
    
    Fixes: #8797
    PR-URL: #14323
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Oleksandr-Kushchak-i2 authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    f6a0343 View commit details
    Browse the repository at this point in the history
  10. test: replace string concatenation with template

    PR-URL: #14342
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    nathansmile authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    def98c6 View commit details
    Browse the repository at this point in the history
  11. build,tools: do not force codesign prefix

    Allow passing the prefix in via the PKGDIR env var. This will allow us
    to use this same script to codesign the binary tarball.
    
    PR-URL: #14179
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    evanlucas authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    5ab4471 View commit details
    Browse the repository at this point in the history
  12. build: codesign tarball binary on macOS

    Previously, we were signing the binary that was released in the .pkg,
    but not the binary released in the tarball.
    
    PR-URL: #14179
    Fixes: #11936
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    evanlucas authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    0ebb4df View commit details
    Browse the repository at this point in the history
  13. test: replace string concatenation with path.join

    PR-URL: #14272
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    jkzing authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    94c7331 View commit details
    Browse the repository at this point in the history
  14. test: use path.join for long path concatenation

    PR-URL: #14280
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    jankjn authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    c866c90 View commit details
    Browse the repository at this point in the history
  15. benchmark: add assert map and set benchmarks

    PR-URL: #14258
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    BridgeAR authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    9b104b4 View commit details
    Browse the repository at this point in the history
  16. test: move test-fs-largefile to pummel

    test-fs-largefile was disabled. It was fixed in bbf74fb but left in
    disabled because it generates a 5Gb file. However, gibfahn had the
    sensible suggestion of moving it to the pummel directory. Which is what
    this change does.
    
    In pummel, lint rules are applied, so this does necessitate changing a
    pair of `var` declarations to `const`.
    
    PR-URL: #14338
    Refs: bbf74fb
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    956a473 View commit details
    Browse the repository at this point in the history
  17. doc: add XadillaX to collaborators

    PR-URL: #14388
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    XadillaX authored and Fishrock123 committed Jul 24, 2017
    2 Configuration menu
    Copy the full SHA
    b12924d View commit details
    Browse the repository at this point in the history
  18. doc: fixes default shell in child_process.md

    Clarifies the default shell in Windows is process.env.ComSpec
    and that cmd.exe is only used as a fallback. Functions whose
    descriptions are affected include:
    child_process.spawn, child_process.exec,
    child_process.spawnsSync, and child_process.execSync.
    
    PR-URL: #14203
    Fixes: #14156
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    henryzxu authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    4be373b View commit details
    Browse the repository at this point in the history
  19. test: add comments for whatwg-url tests

    Added comments to whatwg-url tests that they should not be changed until
    modifications are merged upstream as per "Web Platform Tests" guidelines
    
    PR-URL: #14355
    Fixes: #12793
    Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    gautamarora authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    0197ba0 View commit details
    Browse the repository at this point in the history
  20. doc: fix typo in stream.md

    PR-URL: #14364
    Fixes: #14362
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Marc Hernández Cabot authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    f1b09c0 View commit details
    Browse the repository at this point in the history
  21. test: use path.join in async-hooks/test-tlswrap.js

    PR-URL: #14319
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    vincentcn authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    3c92b78 View commit details
    Browse the repository at this point in the history
  22. test: replace string concatenation with template

    PR-URL: #14286
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    ziyun authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    e237720 View commit details
    Browse the repository at this point in the history
  23. readline: remove the caching variable

    Line 486 and 525 contain for loops where a length property is cached in
    a variable (for example, itemLen). This used to be a performance
    optimization, but current V8 handles the optimization internally.
    
    These caching variables are removed, and the length property is used
    directly instead.
    
    PR-URL: #14275
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Lyall Sun authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    e54f75b View commit details
    Browse the repository at this point in the history
  24. test: improve fs.exists coverage

    By adding a test case using a path with illegal protocol
    
    PR-URL: #14301
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    jkzing authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    99104e1 View commit details
    Browse the repository at this point in the history
  25. test: delete obsolete test-sendfd.js

    This test was disabled in 2011 and is no longer useful without
    modifications.
    
    PR-URL: #14334
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    decareano authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    11ae8c3 View commit details
    Browse the repository at this point in the history
  26. test: fix flaky test-net-write-after-close

    Replace 250ms timer with event-based logic to make test robust.
    
    PR-URL: #14361
    Fixes: #13597
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    9b22acc View commit details
    Browse the repository at this point in the history
  27. doc: error message are still major

    PR-URL: #14375
    Refs: #13937
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    refack authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    592787e View commit details
    Browse the repository at this point in the history
  28. test: move timing-dependent tests to sequential

    Move test-http-server-keep-alive-timeout-slow-server and
    test-http-server-keep-alive-timeout-slow-client-headers from parallel to
    sequential to resolve test flakiness on freebsd10-64.
    
    Fixes: #14033
    Refs: #9317
    PR-URL: #14377
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    aqrln authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    953736c View commit details
    Browse the repository at this point in the history
  29. tools: always include llvm_version in config

    Also used in common.gypi to check whether a flag is needed or not
    based on llvm version.
    
    PR-URL: #14077
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    nanaya authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    c0ea5d8 View commit details
    Browse the repository at this point in the history
  30. tools: skip workaround for newer llvm

    PR-URL: #14077
    Fixes: #14076
    Refs: https://svnweb.freebsd.org/ports/head/www/node/Makefile?revision=444555&view=markup
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    nanaya authored and Fishrock123 committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    ebb9090 View commit details
    Browse the repository at this point in the history
  31. test: replace concatenation with template literals

    * test/parallel/test-stdout-close-catch.js
    
    PR-URL: #14298
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    leizongmin authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    3414e42 View commit details
    Browse the repository at this point in the history
  32. doc: describe labelling process for backports

    Based on discussion from the first backporting team meeting.
    
    PR-URL: #12431
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    83c8e5c View commit details
    Browse the repository at this point in the history
  33. test: replace concatenation with template literals

    Replace string concatenation in test/async-hooks/test-signalwrap.js
    with template literals.
    
    PR-URL: #14295
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    4garfield authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    265f159 View commit details
    Browse the repository at this point in the history
  34. deps: cherry-pick 18ea996 from c-ares upstream

    Original commit message:
    
        ares_parse_naptr_reply: make buffer length check more accurate
    
        9478908a490a6bf009ba58d81de8c1d06d50a117 introduced a length check
        for records parsed by `ares_parse_naptr_reply()`. However, that
        function is designed to parse replies which also contain non-NAPTR
        records; for A records, the `rr_len > 7` check will fail as there
        are only 4 bytes of payload.
        In particular, parsing ANY replies for NAPTR records was broken
        by that patch.
    
        Fix that by moving the check into the case in which it is already
        known that the record is a NAPTR record.
    
    Ref: c-ares/c-ares@18ea996
    PR-URL: #13883
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    d9273ed View commit details
    Browse the repository at this point in the history
  35. test: add non-internet resolveAny tests

    This is a bit of a check to see how people feel about having this kind
    of test.
    
    Ref: #13137
    PR-URL: #13883
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    0418a70 View commit details
    Browse the repository at this point in the history
  36. doc: fix some links

    PR-URL: #14400
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vsemozhetbyt authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    6c6da38 View commit details
    Browse the repository at this point in the history
  37. test: improve test-util-inspect

    PR-URL: #14003
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    psmarshall authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    552d2be View commit details
    Browse the repository at this point in the history
  38. lib: include cached modules in module.children

    `module.children` is supposed to be the list of modules included by this
    module but lib/module.js failed to update the list when the included
    module was retrieved from `Module._cache`.
    
    Fixes: #7131
    PR-URL: #14132
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    bnoordhuis authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    28f0693 View commit details
    Browse the repository at this point in the history
  39. n-api: add fast paths for integer getters

    Ref: #14379
    PR-URL: #14393
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
    addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    fa134dd View commit details
    Browse the repository at this point in the history
  40. deps: update V8 to 5.9.211.35

    PR-URL: #13515
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    272f494 View commit details
    Browse the repository at this point in the history
  41. deps: limit regress/regress-crbug-514081 v8 test

    regress/regress-crbug-514081 allocates a 2G block of memory
    and if there  are multiple variants running at the
    same time this can lead to crashes, OOM kills or
    the OS failing to allocate memory.  This patch
    limits us to running a single variant of the test
    
    Fixes: #6340
    PR-URL: #6678
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    mhdawson authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    613c81e View commit details
    Browse the repository at this point in the history
  42. deps: run memory hungry V8 test in exclusive mode

    es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
    and if there  are multiple variants running at the same time this can
    lead to crashes, OOM kills or the OS failing to allocate memory.
    This patch limits us to running a single variant of the test.
    
    Refs: #6678
    
    PR-URL: #13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    fae03e6 View commit details
    Browse the repository at this point in the history
  43. deps: add missing include to V8 i18n.cc

    This is required for ICU 59.1.
    
    PR-URL: #13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    ad928c0 View commit details
    Browse the repository at this point in the history
  44. deps: fix addons compilation with VS2013

    VS2013 does not support defaulting move constructor and assignment
    operator. This adds explicit definitions of those methods for two
    classes.
    This fix is required because we still support building addons with
    VS2013 and the incompatibility is in v8.h.
    
    Fixes: nodejs/node-v8#4
    
    PR-URL: #13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    bzoz authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    5fb7a0b View commit details
    Browse the repository at this point in the history
  45. v8: fix stack overflow in recursive method

    HGlobalValueNumberingPhase::CollectSideEffectsOnPathsToDominatedBlock()
    used to self-recurse before this commit, causing stack overflows on
    systems with small stack sizes.  Make it non-recursive by storing
    intermediate results in a heap-allocated list.
    
    Fixes: #11991
    PR-URL: #12460
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yang Guo <yangguo@chromium.org>
    bnoordhuis authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    1906077 View commit details
    Browse the repository at this point in the history
  46. v8: fix gcc 7 build errors

    Porting #12392 to V8 5.9
    
    Ref: #12392
    Fixes: #10388
    PR-URL: #13515
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    0be4d17 View commit details
    Browse the repository at this point in the history
  47. deps: cherry-pick bfae9db from upstream v8

    Original commit message:
    
        Update postmortem metadata generator.
    
        Add PropertyDetails::AttributesField +
        PropertyDetails::LocationField.
    
        Review-Url: https://codereview.chromium.org/2842843004
        Cr-Commit-Position: refs/heads/master@{#44889}
    
    PR-URL: #12722
    Refs: nodejs/llnode#81
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    bnoordhuis authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    6204fad View commit details
    Browse the repository at this point in the history
  48. deps: cherry-pick f5fad6d from upstream v8

    Original commit message:
    
        This commit adds a getter for the private is_verbose_ member.
        The use case for this comes from Node.js where the ability to avoid
        calling FatalException if the TryCatch is verbose would be nice
        to have.
    
        BUG=
    
        Review-Url: https://codereview.chromium.org/2840803002
        Cr-Commit-Position: refs/heads/master@{#45018}
    
    PR-URL: #12826
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    danbev authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    4c4f647 View commit details
    Browse the repository at this point in the history
  49. deps: cherry-pick 6d38f89 from upstream V8

    Original commit message:
    
        [turbofan] Boost performance of Array.prototype.shift by 4x.
    
        For small arrays, it's way faster to just move the elements instead of
        doing the fairly complex and heavy-weight left-trimming. Crankshaft has
        had this optimization for small arrays already; this CL more or less
        ports this functionality to TurboFan, which yields a 4x speed-up when
        using shift on small arrays (with up to 16 elements).
    
        This should recover some of the regressions reported in the Node.js issues
    
          #12657
    
        and discovered for the syncthrough module using
    
          https://github.com/mcollina/syncthrough/blob/master/benchmarks/basic.js
    
        as benchmark.
    
        R=jarin@chromium.org
        BUG=v8:6376
    
        Review-Url: https://codereview.chromium.org/2874453002
        Cr-Commit-Position: refs/heads/master@{#45216}
    
    PR-URL: #13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    65956e6 View commit details
    Browse the repository at this point in the history
  50. deps: backport 4fdf9fd4813 from upstream v8

    Original commit message:
    
        Add documentation for FunctionCallbackInfo
    
        R=verwaest@chromium.org,haraken@chromium.org,yukishiino@chromium.org
        BUG=
    
        Change-Id: I273f5ce305f80b2aa5e9c8c42a6e8e5afc51a0a7
        Reviewed-on: https://chromium-review.googlesource.com/484422
        Reviewed-by: Kentaro Hara <haraken@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Commit-Queue: Jochen Eisinger <jochen@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#44927}
    
    Ref: v8/v8@4fdf9fd4813
    
    PR-URL: #12875
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jeisinger authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    83636a4 View commit details
    Browse the repository at this point in the history
  51. v8: do not test v8 with -Werror

    PR-URL: #12875
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    1e93589 View commit details
    Browse the repository at this point in the history
  52. v8: backport bd59e7452be from upstream v8

    Original commit message:
        [PATCH] Merged: Make Object::GetOwnPropertyDescriptor() take a Name, not a String.
    
        Revision: b5e610c19208ef854755eec67011ca7aff008bf4
    
        NOTRY=true
        NOPRESUBMIT=true
        NOTREECHECKS=true
        TBR=vogelheim@chromium.org
    
        Bug:
        Change-Id: I396b559b28aab6afa138db747711e50cd0da3da7
        Reviewed-on: https://chromium-review.googlesource.com/513927
        Reviewed-by: Michael Achenbach <machenbach@chromium.org>
        Cr-Commit-Position: refs/branch-heads/6.0@{#5}
        Cr-Branched-From: 97dbf624a5eeffb3a8df36d24cdb2a883137385f-refs/heads/6.0.286@{#1}
        Cr-Branched-From: 12e6f1cb5cd9616da7b9d4a7655c088778a6d415-refs/heads/master@{#45439}
    
    PR-URL: #13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mi-ac authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    da35ac3 View commit details
    Browse the repository at this point in the history
  53. v8: backport a9e56f4f36d from upstream v8

    Because 5.8 still had other uses of the removed flag, there are some extra
    changes in Heap::ConfigureHeap and api.cc:SetResourceConstraints.
    
    Original commit message:
        [heap] Remove max_executable_size resource constraint.
    
        BUG=chromium:716032
    
        Review-Url: https://codereview.chromium.org/2890603007
        Cr-Commit-Position: refs/heads/master@{#45400}
    
    PR-URL: #13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    psmarshall authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    e3c1119 View commit details
    Browse the repository at this point in the history
  54. v8: backport 4f82f1d948c from upstream v8

    Original commit message:
        [Api] Add an idle time garbage collection callback flag to GCCallbackFlags.
    
        BUG=chromium:718484
    
        Review-Url: https://codereview.chromium.org/2867073002
        Cr-Commit-Position: refs/heads/master@{#45167}
    
    PR-URL: #13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hannespayer authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    61a1f9c View commit details
    Browse the repository at this point in the history
  55. v8: backport 4f82f1d948c from upstream v8

    Original commit message:
        [PATCH] Rename idle garbage collection callback flag.
    
        TBR=mlippautz@chromium.org
    
        Review-Url: https://codereview.chromium.org/2867863002
        Cr-Commit-Position: refs/heads/master@{#45173}
    
    PR-URL: #13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hannespayer authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    9c7af15 View commit details
    Browse the repository at this point in the history
  56. v8: backport pieces from 18a26cfe174 from upstream v8

    Backport new virtual methods from 18a26cfe174
    ("Add memory protection API to ArrayBuffer::Allocator")
    
    PR-URL: #13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    psmarshall authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    e3fcdef View commit details
    Browse the repository at this point in the history
  57. deps: cherry-pick a16c3c9 from upstream V8

    Original commit message:
    
        Expose the ValueSerializer data format version as a compile-time constant.
    
        BUG=chromium:704293
    
        Review-Url: https://codereview.chromium.org/2804643006
        Cr-Commit-Position: refs/heads/master@{#44945}
    
    PR-URL: #13515
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    jeremyroman authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    8e96729 View commit details
    Browse the repository at this point in the history
  58. deps: cherry-pick 866ee63 from upstream V8

    Original commit message:
    
        [string] Re-enable result caching for String.p.split
    
        Runtime::kStringSplit's result caching is only enabled when limit equals
        kMaxUInt32.
    
        BUG=v8:6463
    
        Review-Url: https://codereview.chromium.org/2923183002
        Cr-Commit-Position: refs/heads/master@{#45724}
    
    Fixes: #13445
    PR-URL: #13515
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    06d419f View commit details
    Browse the repository at this point in the history
  59. v8: fix debug builds on Windows

    Adds missing return which fixes debug builds on Windows
    
    Fixes: #13392
    Ref: https://codereview.chromium.org/2929993003/
    PR-URL: #13634
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bzoz authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    55a1231 View commit details
    Browse the repository at this point in the history
  60. deps: update V8 to 5.9.211.37

    PR-URL: #13790
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    da93046 View commit details
    Browse the repository at this point in the history
  61. deps: cherry-pick 3f4536894ac from V8 upstream

    Original commit message:
    
        d8: Make in process stack dumping optional
    
        Adds a flag (--disable-in-process-stack-traces) to not install
        signal handlers so that e.g. ASan signal handlers will work.
    
        This flag mirrors chromium's one.
    
        R=jochen@chromium.org
        BUG=chromium:716235
    
        Review-Url: https://codereview.chromium.org/2854173002
        Cr-Commit-Position: refs/heads/master@{#45142}
    
    PR-URL: #13985
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    oliverchang authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    da1913c View commit details
    Browse the repository at this point in the history
  62. src: fix process.abort() interaction with V8

    Since V8 5.9 V8 installs a default signal handler for some signals
    when creating a default platform instance that prints a stack trace.
    
    However, Node already does the same thing, so it would seem like the
    two different stack traces would be printed; also, the V8 handler
    would lead to a `SIGSEGV` under some circumstances, rather than
    letting the abort continue normally.
    
    Resolve this by disabling V8’s signal handler by default.
    
    PR-URL: #13985
    Fixes: #13865
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    89961ba View commit details
    Browse the repository at this point in the history
  63. deps: cherry-pick 6cb999b97b from V8 upstream

    Original commit message:
    
        Properly handle loads from global interceptor via prototype chain.
    
        ... when receiver is in dictionary mode.
    
        Bug: v8:6490
        Change-Id: Ic5a8d214adcc4efd4cb163cbc6b351c4e6b596af
        Reviewed-on: https://chromium-review.googlesource.com/559548
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Commit-Queue: Igor Sheludko <ishell@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#46428}
    
    Ref: https://chromium.googlesource.com/v8/v8.git/+/6cb999b97b7953ebfd4aabf2e1f62bf405f21c69
    Fixes: #13804
    PR-URL: #14188
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    isheludko authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    577b4f7 View commit details
    Browse the repository at this point in the history
  64. 2017-07-??, Version 8.3.0 (Current)

    Notable changes
    
    * **V8**
        * The V8 engine has been upgraded to version 5.9, which has a significantly
        changed performance profile.
        [#13515](#13515)
    addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    d4c2406 View commit details
    Browse the repository at this point in the history