feat(linter): introduce LintPlugins to store builtin + custom plugins

[camc314]

No description provided.

[camc314]

• feat(linter): load custom JS plugins #11980
• feat(linter): introduce LintPlugins to store builtin + custom plugins #12117 👈 (View in Graphite)
• refactor(linter): rename LintPlugins to BuiltinLintPlugins #12116
• refactor(linter): access plugins through config instead of storing directly #12115
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #12117 will not alter performance

_{Comparing c/07-07-feat_linter_introduce_lintplugins_to_store_builtin_custom_plugins (a4dae73) with main (35c6d48)}

Summary

✅ 34 untouched benchmarks

[overlookmotel]

Merge activity

• Jul 7, 1:32 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jul 7, 1:32 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Jul 7, 1:58 PM UTC: Merged by the Graphite merge queue.

[connorshea]

@camc314 Was it intentional that this resulted in plugins in the configuration_schema.json allowing any string value?

The schema has this for the definition of the plugins value:

"LintPlugins": {
  "type": "array",
  "items": {
    "anyOf": [
      {
        "$ref": "#/definitions/LintPluginOptionsSchema"
      },
      {
        "type": "string"
      }
    ]
  }
},

Which results in my editor not validating whether the given plugins are actually allowed.

If I change it to this, like it was before:

"LintPlugins": {
  "type": "array",
  "items": {
    "$ref": "#/definitions/LintPluginOptionsSchema"
  }
},

I do get validation:

[camc314]

Yes, sorry, we went back and forward here. Initially, JS plugins were going to be enabled via the same plugins array so any string was allowed here. but that later changed, and i think we forgot to update the schema

[connorshea]

Yes, sorry, we went back and forward here. Initially, JS plugins were going to be enabled via the same plugins array so any string was allowed here. but that later changed, and i think we forgot to update the schema

Makes sense! I opened #15468 for adding some basic JSON Schema tests that might be useful to prevent this kind of regression in the future (though maybe not really this case, since the test would've ended up removed when we moved to allowing any string)