refactor(ast): rename TemplateLiteral::quasi to TemplateLiteral::single_quasi
#12266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12266 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
07-14-refactor_ast_check_whether_there_is_a_single_quasi_in_templateliteral_quasi
branch
from
c16bc41 to
c21abab
Compare
Dunqing
force-pushed
the
07-14-refactor_ast_rename_templateliteral_quasi_to_templateliteral_single_quasi
branch
from
0da315f to
1d20685
Compare
camc314
approved these changes
Jul 14, 2025
Dunqing
force-pushed
the
07-14-refactor_ast_check_whether_there_is_a_single_quasi_in_templateliteral_quasi
branch
from
c21abab to
6fc8f4f
Compare
Dunqing
force-pushed
the
07-14-refactor_ast_rename_templateliteral_quasi_to_templateliteral_single_quasi
branch
2 times, most recently
from
b94dcab to
aec41b4
Compare
Dunqing
force-pushed
the
07-14-refactor_ast_check_whether_there_is_a_single_quasi_in_templateliteral_quasi
branch
from
6fc8f4f to
16ac7f3
Compare
Dunqing
force-pushed
the
07-14-refactor_ast_rename_templateliteral_quasi_to_templateliteral_single_quasi
branch
from
aec41b4 to
d01412a
Compare
Dunqing
force-pushed
the
07-14-refactor_ast_check_whether_there_is_a_single_quasi_in_templateliteral_quasi
branch
from
16ac7f3 to
40c4bab
Compare
Dunqing
force-pushed
the
07-14-refactor_ast_rename_templateliteral_quasi_to_templateliteral_single_quasi
branch
from
d01412a to
00c1204
Compare
Dunqing
force-pushed
the
07-14-refactor_ast_check_whether_there_is_a_single_quasi_in_templateliteral_quasi
branch
from
40c4bab to
e82afea
Compare
overlookmotel
approved these changes
Jul 14, 2025
Member
Merge activity
|
…ingle_quasi` (#12266) The method name `quasi` is hard to realize that this method will return a `Some` when there is a only single quasi in this `TemplateLiteral`, so rename to `single_quasi` to match what the implementation does.
graphite-app
bot
force-pushed
the
07-14-refactor_ast_check_whether_there_is_a_single_quasi_in_templateliteral_quasi
branch
from
e82afea to
32c32af
Compare
graphite-app
bot
force-pushed
the
07-14-refactor_ast_rename_templateliteral_quasi_to_templateliteral_single_quasi
branch
from
00c1204 to
c68b607
Compare
Base automatically changed from
07-14-refactor_ast_check_whether_there_is_a_single_quasi_in_templateliteral_quasi
to
main
July 14, 2025 19:34
graphite-app
bot
deleted the
07-14-refactor_ast_rename_templateliteral_quasi_to_templateliteral_single_quasi
branch
This was referenced Jul 16, 2025
camc314
added a commit
that referenced
this pull request
Jul 16, 2025
## [1.7.0] - 2025-07-16 ### 🚀 Features - 5e428a4 linter/eslint-plugin-next: No-html-link-for-pages rule addition (#12194) (Gabriel Díaz Aguilera) - 9b14fbc ast: Add `ThisExpression` to `TSTypeName` (#12156) (Boshen) - c551b8f linter: Report diagnostics from custom plugins (#12219) (camc314) - d387729 linter: JS custom rules config (#12160) (camc314) - 152e59d napi/oxlint: Read source text into start of allocator (#12122) (overlookmotel) - bde1ef1 linter: Load custom JS plugins (#11980) (camc314) - d4ebd14 linter: Add `oxlint2`/`disable_oxlint2` feature flags (#12130) (camc314) - a4dae73 linter: Introduce `LintPlugins` to store builtin + custom plugins (#12117) (camc314) ### 🐛 Bug Fixes - 3f9a1f0 linter/no-unused-private-class-members: Fix false positive with nullish coalescing assignments (#12317) (camc314) - 47fad0e linter/no-empty-file: False positive with empty file with triple slash directive (#12293) (camc314) - 633ba30 linter: False positive with unknown plugins when unmatched eslint rule (#12285) (camc314) - 9720774 linter: Report implicit config parse errors (#12260) (Simon Buchan) - 1920c6b language_server: Respect the root `.oxlintrc.json` file for `ignorePatterns` (#12171) (Sysix) - 98708eb linter: Fix inconsistent behavior in `no-duplicate-imports` rule (#12192) (yefan) - 853d2bc linter, language_server: Correctly identify usage of `import` plugin (#12157) (overlookmotel) ### 🚜 Refactor - ee761de ast: Remove `AstKind` for `AssignmentTarget` (#12252) (Tyler Earls) - c68b607 ast: Rename `TemplateLiteral::quasi` to `TemplateLiteral::single_quasi` (#12266) (Dunqing) - 32c32af ast: Check whether there is a single `quasi` in `TemplateLiteral::quasi` (#12265) (Dunqing) - 8f6a1da linter/js-plugins: Use `u32` for IDs (#12243) (overlookmotel) - 36cd364 linter/js-plugins: Clean up code (#12242) (overlookmotel) - 8c02ebd linter/js-plugins: Rename `specifiers` to `paths` (#12241) (overlookmotel) - 3adaf98 linter: Simplify getting nodes count (#12239) (overlookmotel) - 6e54645 language_server: Store `LintService` instead of `Linter` (#12016) (Sysix) - 113cf8c linter: Move `LintServiceOptions.paths` to `LintService.with_paths` (#12015) (Sysix) - acfac68 oxlint: Adjust ignore patterns by counting bytes instead of chars (#12209) (Sysix) - 729b82b linter: Rename `plugin_name` to `plugin_specifier` (#12148) (overlookmotel) - 532b816 linter: Use `to_string` instead of `into` (#12147) (overlookmotel) - 89f2a69 linter: TODO comment (#12146) (overlookmotel) - f90d3e1 linter: Feature gate `load_external_plugin` by both `oxlint2` and `disable_oxlint2` features (#12141) (overlookmotel) - 12e4ec7 linter: Make `tokio` dependency optional (#12140) (overlookmotel) - 1d2eaca oxlint2: Introduce `force_test_reporter` feature for consistent graphical outputs (#12133) (camc314) - 8814c53 ast: Remove `AstKind` for `PropertyKey` (#12108) (camchenry) - 228cff5 semantic,linter: Assert that Program is always the first node (#12123) (Ulrich Stark) - e8e2a25 ast: Remove `AstKind` for `AssignmentTargetPattern` (#12105) (camchenry) - f7c675d linter: Rename `LintPlugins` to `BuiltinLintPlugins` (#12116) (camc314) - a9e5ec0 linter: Access plugins through config instead of storing directly (#12115) (camc314) - 9736a7f linter: Simplify `unicorn/require-post-message-target-origin` (#12110) (shulaoda) ### 📚 Documentation - 2e3db46 linter: Add missing backtick preventing website from building (#12113) (camc314) ### ⚡ Performance - d0f8b88 linter/js-plugins: Do not copy `Vec` (#12248) (overlookmotel) - 4284d19 linter/js-plugins: Use hashmap `Entry` API + remove temp `Vec` (#12247) (overlookmotel) - c7889c3 semantic,linter: Simplify implementation and uses of ancestors iterators (#12164) (Ulrich Stark) - f99959c linter: Move work out of loop (#12145) (overlookmotel) - 514d40c linter: Do not create `Resolver` unless required (#12142) (overlookmotel) - 7103527 linter/no-constructor-return: Optimize loop (#12138) (overlookmotel) ### 🧪 Testing - d1194e8 oxlint: Ignore test on windows (#12262) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method name
quasiis hard to realize that this method will return aSomewhen there is a only single quasi in thisTemplateLiteral, so rename tosingle_quasito match what the implementation does.