server: fix potential goroutine leak when kill connection (#13051) #13250

SunRunAway · 2019-11-07T11:37:39Z

cherry-pick #13051

What problem does this PR solve?

Fix #13050

What is changed and how it works?

Check List

Tests

Unit test (covered by TestShutDown)

Code changes

None

Side effects

None

Related changes

None

Release note

None

…umn (pingcap#11220) (pingcap#11395) Test pass, auto merge by Bot

…ngcap#11411)

pingcap#11350)

…NALYZE`(pingcap#11334) (pingcap#11418) All tests passed, auto merged by Bot

…cap#11429)

…e slow log file. (pingcap#11417) (pingcap#11419) All tests passed, auto merged by Bot

…#11383) All tests passed, auto merged by Bot

All tests passed, auto merged by Bot

pingcap#11433) All tests passed, auto merged by Bot

…up (pingcap#11110) (pingcap#11385)

… (pingcap#12690)

…ingcap#12930) (pingcap#12961)

…ace (pingcap#12845) (pingcap#12988)

…amegraph by SQL (pingcap#12986) (pingcap#13009)

… is waiting for the pessimistic lock (pingcap#12852) (pingcap#12989)

…#12152) (pingcap#13013)

…#12901)

…gcap#12707)

…p#13028)

…ingcap#13110) (pingcap#13116)

…) (pingcap#12998)

…3101)

pingcap#13108)

) (pingcap#13072)

…ingcap#13117)

…le or alter table. (pingcap#13119 & pingcap#12327) (pingcap#13174)

)

…p#13178) (pingcap#13185)

…) (pingcap#13140)

)

sre-bot and others added 30 commits July 17, 2019 19:58

*: refine text protocol multiple query response (pingcap#11290)

6baed7d

*: fix microseconds behaviour in DATE_ADD() (pingcap#11280) (pingcap#…

b9b6c97

…11288)

metrics: add missing TiKVTxnCmdCounter (pingcap#11292) (pingcap#11316)

bbfb4ec

CHANGELOG: add release notes for v3.0.1 (pingcap#11282)

07120a1

planner: fix NAME_CONST function compatibility (pingcap#11241) (pingc…

7ef017f

…ap#11268)

plugin: add "exec start-time" to GeneralEvent (pingcap#11293) (pingca…

3d7da06

…p#11322)

expression: fix getIntervalFromDecimal in DATE_ADD() (pingcap#11297) (p…

13aa832

…ingcap#11325)

owner: improve unit tests code coverage (pingcap#10792) (pingcap#11030)

a52cfff

ddl: refine error messages in unsupported column options (pingcap#110… (

ffe55b8

pingcap#11274)

expression, types: fix Mod(%), Multiple(*), Minus(-) operators… (ping…

2348c75

…cap#11354)

store/tikv: refine streaming client re-create log and use a sm… (ping…

8dd4a27

…cap#11370)

store/tikv: reduce the lock contend between sending message an… (ping…

5847d3a

…cap#11372)

expression: add max_allowed_packet check in concat/concat_ws (… (ping…

e8d254a

…cap#11275)

ddl: fix the parallel problem of "set default value" and other… (ping…

f8662a2

…cap#11346)

planner: fix bugs related to TIDB_INLJ hint (pingcap#11253) (pingcap#…

db533f5

…11362)

expression: let testEvaluatorSuite run serially to avoid aff… (ping…

91ae309

…cap#11366)

planner: correct the generation of the field name (pingcap#11324) (pi…

8de0fd6

…ngcap#11379)

Function SUBTIME ADDTIME should return NULL with a warning if… (pingc…

e6372f5

…ap#11337)

CONVERT_TZ should return NULL if its arguments are invalid. (#… (ping…

aa4b386

…cap#11359)

infoschema: fix compatibility of auto_increment column value o… (ping…

02527cf

…cap#11413)

ddl: add check for max index key length when alter modify/change col…

5d5dfcd

…umn (pingcap#11220) (pingcap#11395) Test pass, auto merge by Bot

planner: reject invalid conversion from like to = (pingcap#11320) (pi…

68acdce

…ngcap#11411)

infochema, server: export region_id in hot_region table (pingcap#1098… (

cfcd4db

pingcap#11350)

executor: show operators' memory consumption in results of `EXPLAIN A…

da97861

…NALYZE`(pingcap#11334) (pingcap#11418) All tests passed, auto merged by Bot

executor: show CARTESIAN Join explicitly in the results of `… (ping…

37cf597

…cap#11429)

*: add succ filed to slow log and fix shallow copy problem when pars…

f375c91

…e slow log file. (pingcap#11417) (pingcap#11419) All tests passed, auto merged by Bot

store/helper: remove timeout for fetch diagnose from info pd (pingcap…

a79a86e

…#11383) All tests passed, auto merged by Bot

fix a coding mistake (pingcap#11400)

709ee4f

All tests passed, auto merged by Bot

types: fix uint64 overflow bug in ConvertJSONToFloat (pingcap#11355) (

fdaee60

pingcap#11433) All tests passed, auto merged by Bot

executor: fix autoid doesn't handle float, double type and tiny clean…

5bb3c06

…up (pingcap#11110) (pingcap#11385)

winoros and others added 25 commits October 28, 2019 19:37

planner: stream agg should not be pushed to double read (pingcap#12443)…

6e0d18f

… (pingcap#12690)

executor: wait all fetchChildData exiting in HashAggExec.Close (p…

e48693b

…ingcap#12930) (pingcap#12961)

store/tikv: tiny refactoring, change twoPhaseCommitAction to interf…

bdc59e6

…ace (pingcap#12845) (pingcap#12988)

perfschema: support query cpu/memory/mutex/block/allocs/goroutines fl…

1211d61

…amegraph by SQL (pingcap#12986) (pingcap#13009)

*: fix bug that the kill command doesn't work when the killed session…

55dbfd6

… is waiting for the pessimistic lock (pingcap#12852) (pingcap#12989)

main: add make server_coverage build option (pingcap#11844)(pingcap…

fd1953b

…#12152) (pingcap#13013)

docker: update go version to 1.13 (pingcap#13030)

8d55be9

executor: fix data race in GetDirtyTable() (pingcap#12767) (pingcap…

864213f

…#12901)

tikv: eliminate unnecessary pessimistic rollback (pingcap#12561) (pin…

5cb5162

…gcap#12707)

types: invalid year should be 0 (pingcap#12715) (pingcap#12745)

399e03f

privileges: refine infoschema privilege check (pingcap#13006) (pingca…

199d9e3

…p#13028)

*: add release notes for v3.0.5 (pingcap#13038)

8a19ab5

tikv: fix out-of-index in split-region (pingcap#12265) (pingcap#13092)

7939e6f

store/tikv: do not backoff when PessimisticLock return locked error (p…

aa54342

…ingcap#13110) (pingcap#13116)

executor: reuse chunk row for insert on duplicate update (pingcap#12847…

cdcb4ae

…) (pingcap#12998)

tikv: fix init batch client cherry-pick 3.0(pingcap#12819) (pingcap#1…

4809367

…3101)

config: correct the explanation of status and metrics. (pingcap#13024) (

de39012

pingcap#13108)

infoschema/slow_query: add more field in slow_query table (pingcap#13007

fa90d57

) (pingcap#13072)

expression: add builtin function json_valid (pingcap#13133)

16a0358

bindinfo: correctly handle quotes for bindings sql (pingcap#13115) (p…

c99e6b2

…ingcap#13117)

ddl : fix column collate should use table's if it has when create tab…

5df9ff5

…le or alter table. (pingcap#13119 & pingcap#12327) (pingcap#13174)

Makefile: fix export log_level for gotest (pingcap#13197) (pingcap#13200

c7b4ae6

)

perfschema: rename TIDB_GOROUTINES to TIDB_PROFILE_GOROUTINES (pingca…

f0740e3

…p#13178) (pingcap#13185)

util/admin: support admin check table on partition table (pingcap#12796…

536e259

…) (pingcap#13140)

server: fix potential goroutine leak when kill connection (pingcap#13051

c14e8a8

)

SunRunAway requested a review from a team as a code owner November 7, 2019 11:37

ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 7, 2019 11:37

SunRunAway closed this Nov 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server: fix potential goroutine leak when kill connection (#13051) #13250

server: fix potential goroutine leak when kill connection (#13051) #13250

SunRunAway commented Nov 7, 2019

server: fix potential goroutine leak when kill connection (#13051) #13250

server: fix potential goroutine leak when kill connection (#13051) #13250

Conversation

SunRunAway commented Nov 7, 2019

What problem does this PR solve?

What is changed and how it works?

Check List