fix: highlight confirmed status when signer confirms #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add StepperFactory, new tx pages * wip: context instead of routes * Add tx flows to new modal context * fix: Close modal when user navigates * Export all flows from one file * refactor: Remove unused code from StepperFactory * fix: Duplicate ModalDialog to fix failing tests
* Refactor: reactive recommended nonce Reduce re-renders Nonce -1 * Use "nonceReadyOnly" instead of -1 * Split sign and execute into two components
* feat: add tx status widget UI * add logic to paint the stepper * port the ConfirmProposedTx to the new layout * pass tx data to the TxStatusWidget to get the tx confirmations * style: add new lines between adjacent tags
* Refactor: SafeTxProvider * Avoid oscillating nonce * fix reject tx for new provider --------- Co-authored-by: Usame Algan <usame@safe.global>
* Refactor: useRecommendedNonce + useSafeTxGas * Fix lint * Get recommended nonce by "estimating" an empty tx
* Refactor: a less verbose ModalProvider * Fix Cannot redefine property: dispatchTxProposal
* Refactor the tx flow system * Array
* Editable nonce * Fix tests
* fix: Close modal on sign, only render current step * fix: Close modal on sign, only render current step * fix: set all data + move back button --------- Co-authored-by: Usame Algan <usame@safe.global>
* Refactor: single type for tx flows * Omit txNonce * FormData type
* feat: Port change threshold flow * fix: Only estimate gas when executing * fix: Remove old component
* feat: add owner flow * feat: replace owner flow * feat: replace owner flow
* SafeAppsTx flow * On close * Handle txFlow close
* feat: new spending limit flow * fix: preserve token address + reset time values
* fix: Check execute checkbox if execution is the only option (#2230) * v1.14.0 * Chore: escape quotes in release action (#2236) Use printf Use a heredoc Use jq * fix: only initiate WC v2 module if project id provided (#2228) * chore: mark `NEXT_PUBLIC_WC_PROJECT_ID` required * chore: don't prettify * fix: don't return module * fix: revert readme * fix: autoconnect to WC v2 on mobile (#2238) * fix: update token price tooltip (#2257) --------- Co-authored-by: katspaugh <katspaugh@gmail.com> Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com> Co-authored-by: Aaron Cook <aaron@safe.global>
* fix: Hide status for batch execute * fix: Close batch execute flow when submitting tx * fix: Remove hide status flag, add isBatch flag and display different status messages for batch execution
* fix: Hide approval editor for non-approval transactions * fix: Adjust useApprovalInfos hook for non-approval txs
* fix: increase `min-width` of nonce field * fix: prevent recommended nonce jump
* fix: Align decoded tx ui for batch execute * fix: Don't show confirmation dialog for batch execute, update spending limit components to use SendAmountBlock
* fix: Validation for spending limits * fix: Reset amount field to empty string instead of 0 when switching tokens * fix: Add readonly addressbook input to spending limits
* fix: Hide nonce for spending limit txs * Update src/components/tx-flow/flows/TokenTransfer/ReviewSpendingLimitTx.tsx Co-authored-by: Aaron Cook <aaron@safe.global> --------- Co-authored-by: Aaron Cook <aaron@safe.global>
Branch preview✅ Deploy successful! https://confirmed_status--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
approved these changes
Jul 12, 2023
|
LGTM. The confirm status looks fine |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves confirmed status incorrectly highlighted
How this PR fixes it
The transaction status "Confirmed" step is now only highlighted if the user will confirm the transaction with their signature.
How to test it
Checklist