Release 1.16.0 #2366

katspaugh · 2023-08-08T10:18:51Z

This reverts commit e1eadbc.

* Fix: mobile pairing check * Fix tests

* fix: replacement nonce dropdown style * fix: tweak style * fix: reduce padding

* fix: don't close flow in Safe Apps * fix: dependencies

* fix: Reopen QR modal in safe creation * fix: Use RHF isValidating instead of setting own state

* feat: Safe App info button * fix: return type * fix: mark apps agnostic of chain * Revert "fix: mark apps agnostic of chain" This reverts commit 35e7917.

* Fix: warn if wallet already signed a tx * Adjust TxLayout margin * Replace dashboard link with modal close * fix: align transaction links (#2332) * Fix: mobile pairing check (#2327) * Fix: mobile pairing check * Fix tests * fix: align transaction links --------- Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com> * Rm NewTxMenu margin * fix e2e create_tx * fix e2e nfts --------- Co-authored-by: Aaron Cook <aaron@safe.global> Co-authored-by: Franco Venica <francovenica@gmail.com>

* Feat: batch any tx * Refactor: move DecodedTx logic to a hook; extract Approval editor * Expanded details * Notifications * Batch indicator on mobile * Tracking * Tracking: add counts and types * Fix useDecodeTx * Fix tooltip * Fix propose tests * Disable batching batches * Empty state * Disable batch button for multisends * Reordering * Empty batch image in dark mode * Update src/components/batch/BatchSidebar/EmptyBatch.tsx Co-authored-by: Aaron Cook <aaron@safe.global> * Update src/components/batch/BatchSidebar/EmptyBatch.tsx Co-authored-by: Aaron Cook <aaron@safe.global> * Use ids in the store, PR comments * Disable accordion when dragging * Rm unnecessary casting * Update src/components/batch/BatchIndicator/BatchTooltip.tsx Co-authored-by: Aaron Cook <aaron@safe.global> * Await txDetails; disallow batching delegate calls; other PR comments * Add signatures in createMockSafeTx * Avoid re-fetching txDetails * Disallow batching rejection txs * Close sidebar when txflow is opened * Fix e2e test * Fix tracking * Hide batching on mobile --------- Co-authored-by: Aaron Cook <aaron@safe.global>

* Feat: show delegates * Fix: don't show delegates if array is empty * Add help tooltip

* fix: `useAsync` dependency arrays * fix: lint * fix: missing dependency

* Feat: emoji identicons Add experimental toggle * Fix tests * Fix build * Adjust settings style * Disable emojis for small avatars * Extract static fn part * Fix z-index

* Fix: re-connecting a locked wallet * Reconnect WC v2 * Refactor: onboard autoConnect * e2e wallet * Rm the connectE2EWallet command * Tracking + WC v2 peer tracking * Reset last tracked wallet on disconnect * Lint * Minor UI adjustments * Fix: WC v1 detection

* Fix: prevent key prop warning in EthHashInfo Fix: prevent key prop warning in EthHashInfo Fix: prevent key prop warning in EthHashInfo * Fix tests * PR comments

* Chore: rm Plausible Analytics script * Rm PA from privacy policy and CSP

* fix: limit `origin` length * fix: prioritise URL * fix: add test

* Fix: tx can have been created w/o signatures * Reuse the same logic in ExecuteForm

* Fix: cookie prefs checked checkbox color * Move colors to CSS * Stop propagation on ExplorerButton in EthHashInfo

* Fix: prevent an early redirect on the Safe Apps share page * Use an effect

* fix: Use PNG instead of SVG for Redefine logo * fix: Optimize PNG

* Refactor: fetch pending queue only in 1/N Safes * Improve hook condition * Fix previous nonces

github-actions · 2023-08-08T10:19:07Z

Branch preview

✅ Deploy successful!

https://release_1_16_0--walletweb.review-wallet-web.5afe.dev

github-actions · 2023-08-08T10:20:22Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

francovenica · 2023-08-09T14:48:35Z

In mobile, I see this in the topbar. (Can be seen using the emulation with chrome)

The bell for notifications wasn't there before and now is pushing the network out of bounds. I don't even remember any ticket that adds the bell at the top for the mobile view

francovenica · 2023-08-10T01:49:12Z

Beyond that small issue for mobile the rest RC looks good.
I've checked the tickets on the description, except some that are covered by a regression and some tickets about delegates that can only be done with "MM inst"

The regression looks good. Testedly mostly in GNO, ETH and Goerli
Safe creation / adding,
Tx creation/execution/rejection/replacement
Spending limit
Address book
Apps (tested just a few)
Assets list
Import/export of data
Adv parameters
Relayer
Simulations (tenderly and redefine)
Connecting with different wallets (mobile pairing, MM WCv1, Rainbow WCv2, trezor, ledger, MM extension)
...

katspaugh · 2023-08-10T06:58:02Z

In mobile, I see this in the topbar. (Can be seen using the emulation with chrome)

Fixed here. Thanks Franco!

* Fix: limit emoji avatars to owned Safes * Fix mobile header

francovenica · 2023-08-10T11:49:41Z

There is still the issue present when no wallet is connected. I'll create a ticket to solve it in the next iteration

iamacook and others added 27 commits July 31, 2023 09:34

feat: add "Transaction is executed" to success

e1eadbc

Revert "feat: add "Transaction is executed" to success"

dac1fea

This reverts commit e1eadbc.

Fix: mobile pairing check (#2327)

d86bacd

* Fix: mobile pairing check * Fix tests

feat: add "Transaction is executed" to stepper (#2328)

c031735

fix: replacement nonce dropdown style (#2318)

793cd98

* fix: replacement nonce dropdown style * fix: tweak style * fix: reduce padding

fix: don't close flow in Safe Apps (#2333)

1a48103

* fix: don't close flow in Safe Apps * fix: dependencies

feat: add Plausible Analytics to privacy policy (#2336)

65d2663

fix: execute icon colour in dark mode (#2338)

9fd937a

fix: Reopen QR modal in safe creation (#2294)

e78930a

* fix: Reopen QR modal in safe creation * fix: Use RHF isValidating instead of setting own state

feat: Safe App info button (#1726)

2658166

* feat: Safe App info button * fix: return type * fix: mark apps agnostic of chain * Revert "fix: mark apps agnostic of chain" This reverts commit 35e7917.

Feat: show delegates (#2324)

1db9568

* Feat: show delegates * Fix: don't show delegates if array is empty * Add help tooltip

fix: useAsync dependency arrays (#2291)

e99b511

* fix: `useAsync` dependency arrays * fix: lint * fix: missing dependency

Feat: emoji identicons (#2305)

3410911

* Feat: emoji identicons Add experimental toggle * Fix tests * Fix build * Adjust settings style * Disable emojis for small avatars * Extract static fn part * Fix z-index

fix: Open custom safe apps on click (#2350)

bd9118c

Fix: prevent key prop warning in EthHashInfo (#2351)

8826af3

* Fix: prevent key prop warning in EthHashInfo Fix: prevent key prop warning in EthHashInfo Fix: prevent key prop warning in EthHashInfo * Fix tests * PR comments

Chore: rm Plausible Analytics script (#2346)

d88bb03

* Chore: rm Plausible Analytics script * Rm PA from privacy policy and CSP

fix: limit origin length (#2334)

7556391

* fix: limit `origin` length * fix: prioritise URL * fix: add test

Fix: tx can have been created w/o signatures (#2354)

3fbb439

* Fix: tx can have been created w/o signatures * Reuse the same logic in ExecuteForm

Fix: cookie prefs checked checkbox color (#2356)

e3c0e31

* Fix: cookie prefs checked checkbox color * Move colors to CSS * Stop propagation on ExplorerButton in EthHashInfo

Fix: prevent an early redirect on the Safe Apps share page (#2358)

425cf08

* Fix: prevent an early redirect on the Safe Apps share page * Use an effect

fix: Replace transaction with 0 nonce (#2361)

7eedd71

fix: Use PNG instead of SVG for Redefine logo (#2362)

0be8488

* fix: Use PNG instead of SVG for Redefine logo * fix: Optimize PNG

Refactor: fetch pending queue only in 1/N Safes (#2353)

90bdb23

* Refactor: fetch pending queue only in 1/N Safes * Improve hook condition * Fix previous nonces

v1.16.0

84b6419

katspaugh requested a review from iamacook August 8, 2023 10:18

iamacook approved these changes Aug 8, 2023

View reviewed changes

schmanu and others added 2 commits August 8, 2023 15:34

feat: pending safes per chainId (#2295)

9750cec

Fix: extend the emoji set for eth addresses (#2368)

3d2ba01

Fix: limit emoji avatars to owned Safes (#2376)

402fde0

* Fix: limit emoji avatars to owned Safes * Fix mobile header

katspaugh merged commit 402fde0 into main Aug 10, 2023
8 of 9 checks passed

katspaugh deleted the release/1.16.0 branch August 10, 2023 07:34

github-actions bot locked and limited conversation to collaborators Aug 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.16.0 #2366

Release 1.16.0 #2366

katspaugh commented Aug 8, 2023

github-actions bot commented Aug 8, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023 •

edited

Loading

francovenica commented Aug 9, 2023 •

edited

Loading

francovenica commented Aug 10, 2023

katspaugh commented Aug 10, 2023

francovenica commented Aug 10, 2023

Release 1.16.0 #2366

Release 1.16.0 #2366

Conversation

katspaugh commented Aug 8, 2023

Features

Bug fixes

Improvements

github-actions bot commented Aug 8, 2023 • edited Loading

Branch preview

github-actions bot commented Aug 8, 2023 • edited Loading

ESLint Summary View Full Report

francovenica commented Aug 9, 2023 • edited Loading

francovenica commented Aug 10, 2023

katspaugh commented Aug 10, 2023

francovenica commented Aug 10, 2023

github-actions bot commented Aug 8, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023 •

edited

Loading

francovenica commented Aug 9, 2023 •

edited

Loading