Test/tsc version upgrade #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Post release automated changes for azure-event-hubs
Post release automated changes for azure-core-util
Bump emitter version 0.17.0
…rotobuf (Azure#27209) ### Packages impacted by this PR @azure/web-pubsub-client-protobuf ### Issues associated with this PR Azure#25703 ### Describe the problem that is addressed by this PR As protobufjs is purely commonjs type but rollup bundle didn't add commonjs support. So only file in `dist-esm/` works but in `dist` doesn't. ### Are there test cases added in this PR? _(If not, why?)_ Test already added `cjs()` plugin in bundle, so it works.
- along with it, `@types/mocha` version to `^10.0.0` - add `esm` dev dependency as they are used, but not explicitly list - use dev-tool run command for test scripts as much as possible - fix test issue caused by Mocha behavior change around test name - move `import "chai/register-should"` to mocha -r command line option for core http tests ***NO_CI***
### Packages impacted by this PR @azure/web-pubsub-client ### Issues associated with this PR Azure#26400 ### Describe the problem that is addressed by this PR React native use some different packages from node, I added some package map to resolve it. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7013 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
### Packages impacted by this PR @azure/openai ### Issues associated with this PR Fixes Azure#27227 Fixes Azure#27226 ### Describe the problem that is addressed by this PR `@azure/openai` depends on v4 of `formdata-node` and v1.7.2 of `form-data-encoder`. However, those are outdated versions and we should depend on recent versions of those libraries instead but the recent versions are ESM-only. I couldn't find a way to bundle ESM code into cjs using rollup v2, our current rollup version. With rollup v3, you can bundle ESM-only code if you import it with dynamic imports and this PR does exactly that. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
This is an automatic PR generated weekly with changes from running the command rush update --full
) ### Packages impacted by this PR @azure/monitor-opentelemetry-exporter ### Describe the problem that is addressed by this PR Adds tests to the `metricUtils`, `spanUtils`, and `fileSystemPersister` classes. ### Checklists - [x] Added impacted package name to the issue description - [x] Added a changelog (if necessary)
…r in TypeScript 5.2 (Azure#27224) ### Packages impacted by this PR @azure/cosmos ### Issues associated with this PR Azure#26924 ### Describe the problem that is addressed by this PR Some of the conditions mentioned in this file were causing issues in typescript version 5.2. This PR aims to fix that. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ yes ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
Otherwise, irrelevant types for `sources` and `test` get packaged
### Packages impacted by this PR @azure/openai ### Issues associated with this PR Fixes Azure#27275 ### Describe the problem that is addressed by this PR Missed import of `AzureKeyCredential` in README.md ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
… for Javascript (Azure#27242) CallAutomationEventProcessor is being added to Javascript. This will ensure correlation between call and events more easily. See below example for its usage. - Adds EventProcessor and a way to wait for events based on given predicate - Ongoing event handlers to allow developer to utilize callback scenarios - Updated rest events to avoid confusions on CallAutomation events - Unit test added to test all added features - Readme file updated to give examples on its usage --------- Co-authored-by: Min Woo Lee 🧊 <77083090+minwoolee-ms@users.noreply.github.com>
### Packages impacted by this PR @azure/cosmos ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Following suit with the Azure Monitor label consolidation effort that was completed for Java at Azure/azure-sdk-for-java#36538. These labels have been removed from issues and PRs and have been deleted from the Labels admin page on GitHub.
### Packages impacted by this PR @azure/monitor-opentelemetry ### Issues associated with this PR ### Describe the problem that is addressed by this PR Documentation is wrong, and the property name used throws an error. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [x] Added a changelog (if necessary)
It is using `pretty-quick` which is no longer actively maintained. We also found that the usage of pre-commit git hook is very low. This PR saves us from the maintanence burden.
### Packages impacted by this PR All libraries ### Issues associated with this PR Fixes Azure#26665 ### Describe the problem that is addressed by this PR We need to upgrade Rollup to v3 so our cjs bundles could import ES modules among other goodness. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? See the linked issue for discussion of the upgrade. Credit to @xirzec for writing up the sourcemaps plugin in-house replacement! ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ [N/A](Azure#27258) ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Removing config for the dead CXP Attention rule
### Issues associated with this PR - Fixes Azure#27106 ### Describe the problem that is addressed by this PR Fix browser bundling warnings by: - Create browser mappings for Node-only tests which use `crypto.createHash`, which does not have a polyfill - Re-enabling Node polyfill for browser bundle ### Packages impacted by this PR - `@azure/keyvault-keys`
This is an automatic PR generated weekly with changes from running the command rush update --full
Commits that I forgot to push to address feedback in Azure#27266
…s setup (Azure#27295) ### Packages impacted by this PR @azure/monitor-opentelemetry-exporter ### Issues associated with this PR Azure#27268 Issue is causing first time this code is executed credentialScopes are not passed to core-client adding incorrect default one.
…zure#27631) Adding the missing export for KeyCredential for ts http runtime lib
The link to the code sample was missing
### Packages impacted by this PR dev-tool ### Issues associated with this PR This change adds support for customizing interface call signatures. It also fixes an issue with the property removal functionality. ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
This is an automatic PR generated weekly with changes from running the command rush update --full
I bumped into this issue when I was running `rush update` on a clean-slate Windows.
…onal (Azure#27661) ### Packages impacted by this PR @azure/identity
to maintain back compatibility. Related issue Azure#27618 Previously `import * as serviceBus from @azure/service-bus` is working but broken after upgrading to rollup v3. The rollup migration guide suggested `esModule: true` More details: - https://rollupjs.org/migration/#changed-defaults - https://rollupjs.org/configuration-options/#output-esmodule
### Packages impacted by this PR @azure/event-hubs ### Issues associated with this PR Azure#27253 ### Describe the problem that is addressed by this PR Azure#27253 (comment) ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ To be tested using stress testing framework. UPDATE: The results are in and it is confirmed there is no more space leak! ### Provide a list of related PRs _(if any)_ Azure#26065 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
- update CHANGELOG
Post release automated changes for azure-event-hubs
Post release automated changes for azure-core-amqp
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7251 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Post release automated changes for azure-service-bus
### Describe the problem that is addressed by this PR Adding self as a Core code owner so I can get review notifications for Core
…rs/vikas/fix/pipelinefix-nov2023
…laky tests (Azure#27700) ### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Jeremy Meng <jeremy.ymeng@gmail.com> Co-authored-by: Minh-Anh Phan <111523473+minhanh-phan@users.noreply.github.com> Co-authored-by: Mary Gao <yanmeigao1210@gmail.com> Co-authored-by: KarishmaGhiya <kghiya8@gmail.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> Co-authored-by: Gerardo Lecaros <gerardo.lecaros.e@gmail.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: Timo van Veenendaal <timov@microsoft.com> Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
…e/azure-sdk-for-js into users/vikas/fix/pipelinefix-nov2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists