Facebook widget: hide-cta and small-header #13744

wigglemuff · 2019-10-14T02:34:04Z

Changes proposed in this Pull Request:

Fixes #9270

Fixes this issue: Facebook Widget: Expand widget functionality #9270
Adds an option to hide call to action button
Adds an option to show small header instead of big one
By default these two options will be off

Testing instructions:

Go to widgets page, add Facebook widget, add URL and save.
Go to front page, inspect the facebook widget, you will see data-hide-cta="false" data-small-header="false"
Go back to widget settings and enable both hide call to action and show small header options.
Now you will see data-hide-cta="true" data-small-header="true" in the element inspector.

Proposed changelog entry for your changes:

Facebook widget now supports all new settings for the Facebook page plugin

Screenshot:

Other notes:

The third functionality adapt-container-width is covered by this #9889 issue and this #13740 PR.

matticbot · 2019-10-14T02:34:10Z

Caution: This PR has changes that must be merged to WordPress.com
Hello codestor4! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33973-code before merging this PR. Thank you!

jetpackbot · 2019-10-14T02:36:26Z

	Warnings
⚠️	`pre-commit` hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 54509bb

wigglemuff · 2019-10-14T02:44:36Z

modules/widgets/facebook-likebox.php

+			'stream'     		=> '',
+			'cover'      		=> 'true',
+			'hide_cta'      	=> '',
+			'small_header'      => '',


Need to fix issues with spacing (in multiple places) to make it better formatted. Will do that after initial review by someone! :)

modules/widgets/facebook-likebox.php

add esc_html_e instead of _e Co-Authored-By: Jeremy Herve <jeremy@jeremy.hu>

matticbot · 2019-10-26T07:55:27Z

codestor4, Your synced wpcom patch D33973-code has been updated.

stale · 2020-01-24T08:33:24Z

This PR has been marked as stale. This happened because:

It has been inactive in the past 3 months.
It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

matticbot · 2020-02-24T17:00:53Z

codestor4, Your synced wpcom patch D33973-code has been updated.

matticbot · 2020-02-24T17:25:13Z

codestor4, Your synced wpcom patch D33973-code has been updated.

wigglemuff · 2020-02-24T17:27:56Z

The latest change added a filter jetpack_fb_hide_cta which can be used to return false if someone wishes to display the Facebook's call to action button.

modules/widgets/facebook-likebox.php

jeherve · 2020-02-24T21:51:59Z

modules/widgets/facebook-likebox.php

+		$like_args['show_faces']   = (bool) $like_args['show_faces'] ? 'true' : 'false';
+		$like_args['stream']       = (bool) $like_args['stream'] ? 'timeline' : 'false';
+		$like_args['cover']        = (bool) $like_args['cover'] ? 'false' : 'true';
+		$like_args['small_header'] = (bool) $like_args['small_header'] ? 'true' : 'false';


What's the current default value for this header? If I update Jetpack, will my header change unless I go to the widget options and toggle this new option?

Fixed this by adding a value of true to small_header to get_default_args function. I think that's what you wanted here but let me know if I'm wrong 😅

I think it should default to false, since that's the default value in the Page Plugin. The idea is for the widget to look the same when folks will update Jetpack, so the large header has to stay until you decide to have a smaller header instead.

matticbot · 2020-02-25T18:33:04Z

codestor4, Your synced wpcom patch D33973-code has been updated.

jeherve · 2020-02-25T22:30:28Z

modules/widgets/facebook-likebox.php

+		$like_args['show_faces']   = (bool) $like_args['show_faces'] ? 'true' : 'false';
+		$like_args['stream']       = (bool) $like_args['stream'] ? 'timeline' : 'false';
+		$like_args['cover']        = (bool) $like_args['cover'] ? 'false' : 'true';
+		$like_args['small_header'] = (bool) $like_args['small_header'] ? 'true' : 'false';


I think it should default to false, since that's the default value in the Page Plugin. The idea is for the widget to look the same when folks will update Jetpack, so the large header has to stay until you decide to have a smaller header instead.

jeherve · 2020-02-25T22:31:27Z

modules/widgets/facebook-likebox.php

+		 *
+		 * @param bool True value hides the call to action button
+		 */
+		$hide_cta = apply_filters( 'jetpack_facebook_likebox_hide_cta', true );


I would default to false here as well, for the same reasons as above.

Oh right. Sorry, I checked now and the default is indeed false for both small_header and hide_cta - https://developers.facebook.com/docs/plugins/page-plugin/ I'll make this change now.

matticbot · 2020-02-26T18:26:52Z

codestor4, Your synced wpcom patch D33973-code has been updated.

matticbot · 2020-02-26T19:05:00Z

codestor4, Your synced wpcom patch D33973-code has been updated.

kraftbj

Thanks for these updates. This looks good to me now.

matticbot · 2020-03-17T12:23:51Z

codestor4, Your synced wpcom patch D33973-code has been updated.

jeherve

This should be good to go now!

jeherve · 2020-03-17T13:32:10Z

r204387-wpcom

* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description

new functionality for fb widget with hide-cta and small-header

058f0f3

wigglemuff added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal Good For Community labels Oct 14, 2019

wigglemuff requested a review from a team October 14, 2019 02:34

wigglemuff self-assigned this Oct 14, 2019

matticbot added Touches WP.com Files labels Oct 14, 2019

wigglemuff commented Oct 14, 2019

View reviewed changes

jeherve requested changes Oct 14, 2019

View reviewed changes

modules/widgets/facebook-likebox.php Outdated Show resolved Hide resolved

modules/widgets/facebook-likebox.php Outdated Show resolved Hide resolved

modules/widgets/facebook-likebox.php Outdated Show resolved Hide resolved

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 14, 2019

Update modules/widgets/facebook-likebox.php

951622b

add esc_html_e instead of _e Co-Authored-By: Jeremy Herve <jeremy@jeremy.hu>

stale bot added the [Status] Stale label Jan 24, 2020

Merge branch 'master' into fix/fb-widget

cb1b801

stale bot removed the [Status] Stale label Feb 24, 2020

[not verified] filter for hide-cta and other adjustments

f640b3c

wigglemuff requested a review from jeherve February 24, 2020 17:28

jeherve requested changes Feb 24, 2020

View reviewed changes

minor adjustments

3901448

wigglemuff requested a review from jeherve February 25, 2020 18:36

wigglemuff added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 25, 2020

jeherve requested changes Feb 25, 2020

View reviewed changes

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 25, 2020

switched the default value to false

074d3ca

wigglemuff requested a review from jeherve February 26, 2020 18:27

small adjustment to default_args

db8caf2

wigglemuff added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 27, 2020

jeherve added this to the 8.4 milestone Feb 27, 2020

kraftbj previously approved these changes Mar 6, 2020

View reviewed changes

kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 6, 2020

Small header setting should default to true

54509bb

jeherve dismissed kraftbj’s stale review via 54509bb March 17, 2020 12:23

jeherve approved these changes Mar 17, 2020

View reviewed changes

jeherve merged commit 8c01e22 into master Mar 17, 2020

jeherve deleted the fix/fb-widget branch March 17, 2020 13:20

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 17, 2020

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Mar 23, 2020

jeherve added a commit that referenced this pull request Mar 23, 2020

Changelog: add #13744

36ba0a5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Facebook widget: hide-cta and small-header #13744

Facebook widget: hide-cta and small-header #13744

wigglemuff commented Oct 14, 2019 •

edited by kraftbj

Loading

matticbot commented Oct 14, 2019

jetpackbot commented Oct 14, 2019 •

edited

Loading

wigglemuff Oct 14, 2019 •

edited

Loading

matticbot commented Oct 26, 2019

stale bot commented Jan 24, 2020

matticbot commented Feb 24, 2020

matticbot commented Feb 24, 2020

wigglemuff commented Feb 24, 2020

jeherve Feb 24, 2020

wigglemuff Feb 25, 2020

jeherve Feb 25, 2020

matticbot commented Feb 25, 2020

jeherve Feb 25, 2020

jeherve Feb 25, 2020

wigglemuff Feb 26, 2020

matticbot commented Feb 26, 2020

matticbot commented Feb 26, 2020

kraftbj left a comment

matticbot commented Mar 17, 2020

jeherve left a comment

jeherve commented Mar 17, 2020

Facebook widget: hide-cta and small-header #13744

Facebook widget: hide-cta and small-header #13744

Conversation

wigglemuff commented Oct 14, 2019 • edited by kraftbj Loading

Changes proposed in this Pull Request:

Testing instructions:

Proposed changelog entry for your changes:

Screenshot:

Other notes:

matticbot commented Oct 14, 2019

jetpackbot commented Oct 14, 2019 • edited Loading

wigglemuff Oct 14, 2019 • edited Loading

Choose a reason for hiding this comment

matticbot commented Oct 26, 2019

stale bot commented Jan 24, 2020

matticbot commented Feb 24, 2020

matticbot commented Feb 24, 2020

wigglemuff commented Feb 24, 2020

jeherve Feb 24, 2020

Choose a reason for hiding this comment

wigglemuff Feb 25, 2020

Choose a reason for hiding this comment

jeherve Feb 25, 2020

Choose a reason for hiding this comment

matticbot commented Feb 25, 2020

jeherve Feb 25, 2020

Choose a reason for hiding this comment

jeherve Feb 25, 2020

Choose a reason for hiding this comment

wigglemuff Feb 26, 2020

Choose a reason for hiding this comment

matticbot commented Feb 26, 2020

matticbot commented Feb 26, 2020

kraftbj left a comment

Choose a reason for hiding this comment

matticbot commented Mar 17, 2020

jeherve left a comment

Choose a reason for hiding this comment

jeherve commented Mar 17, 2020

wigglemuff commented Oct 14, 2019 •

edited by kraftbj

Loading

jetpackbot commented Oct 14, 2019 •

edited

Loading

wigglemuff Oct 14, 2019 •

edited

Loading