Always display the mobile nav menu when disconnecting sites

[enejb]

Make the cancel and disconnect buttons always visible on mobile devices.

Fixes #8726
Before:

After:

Changes proposed in this Pull Request:

Testing instructions:

• Connect your site.
• On a mobile iPhone or any other device (use browserstack.com ) device try disconnection.
• Are you able to do it? Do you see the button as expected?

Proposed changelog entry for your changes:

• Fix broken flow. Show the disconnect button on mobile always.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against b150c3f

[keoshi]

In general this looks good to me and it's a great change.

Added a comment about a color variable below, which is minor, but I noticed we're not showing the modal's title if the device is shorter than the content. See below:

This affects all sorts of devices, from iPhone SE/5/6/7/8.

An easy fix would be to add something like:

.admin-bar .dops-modal-wrapper {
  top: 46px;

  @include breakpoint( '>782px' ) {
    top: 32px;
  }
}

[enejb]

Can you help me replicate the Black bar? What browser were you using?
Maybe the better solution could be to just make sure that the modal has a higher z-index. So that it shows up on top?

[keoshi]

@enejb I was logged into the site, so the WP admin bar was showing. I'd rather not have something overlap with the core admin bar, but let me know if you think that's a better option.

[jeherve]

You still have a few spaces left. I would recommend setting up your IDE so it transforms those on save, that should save you some trouble!

[enejb]

I fixed the adminbar overlap and the spacing issue.

[github-actions]

Howdy! The Jetpack team has disappeared for a few days to a secret island lair to concoct new ways to make Jetpack one hundred billion percent better. As a result, your Pull Request may not be reviewed right away. Do not worry, we will be back next week to look at your work! Thank you for your understanding.

[jeherve]

I removed more spaces in b150c3f

This should be good to go now.

[keoshi]

LGTM