Recurring Payments Block: Minimum transaction amounts #14802

beaucollins · 2020-02-25T21:29:10Z

Uses Stripe's minimum transaction amounts per currency.

Changes proposed in this Pull Request:

Uses Stripe's minimum transaction amounts per currency.
Sets the input minimum value to 0 to allow for better stepper experience
Prevents using less than minimum amount during component state change
Shows the minimum price for the selected currency below the Price input field.

The placeholder text uses formatCurrency which is nice, however it somewhat misleads the user into thinking they can type the currency symbols into the field while we actually only allow that which can be parsed by parseFloat which means values like $0.50 or CHF 0,50 are not considered valid. Should we allow this kind of input?

Testing instructions:

This assumes the "Recurring Payments Block" is available to your Jetpack plan for the site you are testing.

Setup

Go to "Posts → Add New"
Add a block and type /recurr select "Recurring Payments button"
If a plan already exists press the "Add a plan" button to display the form:

Test

Clear out the "price" value, the placeholder should show the minimum price
Change the currency, if the price is now too low for the given currency, it should show the error (e.g. start with USD and 0.5 and change to MXN)

Proposed changelog entry for your changes:

Recurring Payments block minimum price is updated and is dependent on selected currency.

jetpackbot · 2020-02-25T21:31:17Z

	Warnings
⚠️	`pre-commit` hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 3ce8d81

beaucollins · 2020-02-25T21:33:58Z

extensions/blocks/recurring-payments/index.js

+
+/**
+ * Returns the minimum transaction amount for the given currency. If currency is not one of the
+ * known types it returns ...


@artpi Should we default to a value if the currency is not one of the known options? This shouldn't happen in practice.

The currency list gets populated from these constants above. So that should not be happening and we don't want want fallbacks - we want errors in this case :)

extensions/blocks/recurring-payments/edit.jsx

artpi

My comments are not huge blockers

extensions/blocks/recurring-payments/index.js

artpi · 2020-02-26T10:31:09Z

extensions/blocks/recurring-payments/index.js

+
+/**
+ * Returns the minimum transaction amount for the given currency. If currency is not one of the
+ * known types it returns ...


The currency list gets populated from these constants above. So that should not be happening and we don't want want fallbacks - we want errors in this case :)

matticbot · 2020-02-26T20:10:26Z

Caution: This PR has changes that must be merged to WordPress.com
Hello beaucollins! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39465-code before merging this PR. Thank you!

Recurring Payments Block: Minimum transaction amounts Uses Stripe's minimum transaction amounts per currency. - Sets the input minimum value to 0 to allow for better stepper experience - Prevents using less than minimum amount during component state change

matticbot · 2020-02-26T20:14:02Z

beaucollins, Your synced wpcom patch D39465-code has been updated.

artpi

In saveProduct function there is still this.state.editedProductPrice < 5 which does not allow to actually save these products:

matticbot · 2020-02-28T16:40:30Z

beaucollins, Your synced wpcom patch D39465-code has been updated.

beaucollins · 2020-02-28T16:41:17Z

In saveProduct function there is still this.state.editedProductPrice < 5 which does not allow to actually save these products:

Good catch @artpi, updated in fc53ad2.

beaucollins · 2020-03-05T01:30:38Z

@artpi can you chime in about the question:

For example, if on 8.3 before this PR, I add a plan for MX$5 (where the minimum is MX$10), after upgrade, there is seemingly no notification that I have an invalid plan active on my site or ability to update it.

artpi · 2020-03-05T09:28:52Z

I'm curious about the migration plan for existing invalid recurring payment blocks.
For example, if on 8.3 before this PR, I add a plan for MX$5 (where the minimum is MX$10), after upgrade, there is seemingly no notification that I have an invalid plan active on my site or ability to update it.

Oooh, nice catch @kraftbj

There is no migration path because they are plainly not working. If you add a MX$5 , the transaction will fail during checkout, with an error that is confusing to the user.
This whole PR is intended to fix this problem.

There are 2 users with plans in MXN<10 and 4 users with plans in JPY that have this issue.

@beaucollins To make sure everything is proper in the block, let's filter out the invalid subscriptions (make them impossible to select)

We will not deal with those 6 users. Their subscriptions are not working anyway, by definition these plans have no subscribers, so they can retry and create a new plan.

kraftbj · 2020-03-05T13:16:30Z

Making invalid plans impossible to select and not providing a fix for those six is reasonable to me.

If you could Slack me those users or how to pull that list, I'm happy to reach out to them proactively to let them know they need to amend their subscriptions. That'd be a nice priority support outreach.

matticbot · 2020-03-06T19:58:43Z

beaucollins, Your synced wpcom patch D39465-code has been updated.

…minimum-transaction

matticbot · 2020-03-06T20:03:25Z

beaucollins, Your synced wpcom patch D39465-code has been updated.

beaucollins · 2020-03-06T20:05:21Z

@kraftbj @artpi membership options that do not meet the minimum threshold are no longer available to be selected.

Currently they are filtered out as opposed to "shown and disabled".

kraftbj

Thanks for the updates! Let's do this.

artpi · 2020-03-11T14:11:42Z

Hey @beaucollins I merged something and suspect you will have to:

rebase this
wait for D39465-code to pick up new changes (otherwise it will have conflicts )
get new approval from this from Brandon
merge D39465-code
Merge this

…minimum-transaction

matticbot · 2020-03-13T15:02:27Z

beaucollins, Your synced wpcom patch D39465-code has been updated.

matticbot · 2020-03-13T15:11:40Z

beaucollins, Your synced wpcom patch D39465-code has been updated.

beaucollins · 2020-03-13T18:52:45Z

D39465 is deployed.

* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description

beaucollins added [Status] In Progress [Block] Payment Button aka Recurring Payments labels Feb 25, 2020

beaucollins requested a review from a team February 25, 2020 21:29

matticbot added the Touches WP.com Files label Feb 25, 2020

beaucollins added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Feb 25, 2020

beaucollins commented Feb 25, 2020

View reviewed changes

beaucollins requested a review from a team February 25, 2020 21:35

beaucollins force-pushed the recurring-payments/minimum-transaction branch from 8d324ef to d943f12 Compare February 25, 2020 21:45

jeherve added this to the 8.4 milestone Feb 25, 2020

jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 25, 2020

jeherve previously requested changes Feb 25, 2020

View reviewed changes

extensions/blocks/recurring-payments/edit.jsx Outdated Show resolved Hide resolved

jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Feb 25, 2020

beaucollins added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 25, 2020

beaucollins requested a review from jeherve February 25, 2020 23:01

artpi previously approved these changes Feb 26, 2020

View reviewed changes

beaucollins dismissed artpi’s stale review via e91674e February 26, 2020 20:10

beaucollins force-pushed the recurring-payments/minimum-transaction branch from 346cb8f to e91674e Compare February 26, 2020 20:10

beaucollins force-pushed the recurring-payments/minimum-transaction branch from e91674e to cd7f368 Compare February 26, 2020 20:13

artpi requested changes Feb 28, 2020

View reviewed changes

beaucollins added 2 commits February 28, 2020 08:39

Use the same currency price check in saveProduct

fc53ad2

remove currency not supported by WordPress.com

5d857a3

kraftbj added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 5, 2020

beaucollins added 2 commits March 6, 2020 10:02

typo

14e7835

Removes memberships that do not meet the minimum price threshold

a4df71a

beaucollins dismissed artpi’s stale review via a4df71a March 6, 2020 19:58

Merge remote-tracking branch 'origin/master' into recurring-payments/…

65f413b

…minimum-transaction

beaucollins requested a review from a team March 6, 2020 20:05

beaucollins added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 6, 2020

kraftbj approved these changes Mar 10, 2020

View reviewed changes

kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 10, 2020

Merge remote-tracking branch 'origin/master' into recurring-payments/…

3ce8d81

…minimum-transaction

beaucollins merged commit 771f691 into master Mar 13, 2020

beaucollins deleted the recurring-payments/minimum-transaction branch March 13, 2020 18:53

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 13, 2020

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Mar 20, 2020

jeherve added a commit that referenced this pull request Mar 20, 2020

Changelog: add #14802

38cf737

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recurring Payments Block: Minimum transaction amounts #14802

Recurring Payments Block: Minimum transaction amounts #14802

beaucollins commented Feb 25, 2020 •

edited

Loading

jetpackbot commented Feb 25, 2020 •

edited

Loading

beaucollins Feb 25, 2020

artpi Feb 26, 2020

artpi left a comment

artpi Feb 26, 2020

matticbot commented Feb 26, 2020

matticbot commented Feb 26, 2020

artpi left a comment

matticbot commented Feb 28, 2020

beaucollins commented Feb 28, 2020

beaucollins commented Mar 5, 2020

artpi commented Mar 5, 2020 •

edited

Loading

kraftbj commented Mar 5, 2020

matticbot commented Mar 6, 2020

matticbot commented Mar 6, 2020

beaucollins commented Mar 6, 2020

kraftbj left a comment

artpi commented Mar 11, 2020

matticbot commented Mar 13, 2020

matticbot commented Mar 13, 2020

beaucollins commented Mar 13, 2020

Recurring Payments Block: Minimum transaction amounts #14802

Recurring Payments Block: Minimum transaction amounts #14802

Conversation

beaucollins commented Feb 25, 2020 • edited Loading

Changes proposed in this Pull Request:

Testing instructions:

Setup

Test

Proposed changelog entry for your changes:

jetpackbot commented Feb 25, 2020 • edited Loading

beaucollins Feb 25, 2020

Choose a reason for hiding this comment

artpi Feb 26, 2020

Choose a reason for hiding this comment

artpi left a comment

Choose a reason for hiding this comment

artpi Feb 26, 2020

Choose a reason for hiding this comment

matticbot commented Feb 26, 2020

matticbot commented Feb 26, 2020

artpi left a comment

Choose a reason for hiding this comment

matticbot commented Feb 28, 2020

beaucollins commented Feb 28, 2020

beaucollins commented Mar 5, 2020

artpi commented Mar 5, 2020 • edited Loading

kraftbj commented Mar 5, 2020

matticbot commented Mar 6, 2020

matticbot commented Mar 6, 2020

beaucollins commented Mar 6, 2020

kraftbj left a comment

Choose a reason for hiding this comment

artpi commented Mar 11, 2020

matticbot commented Mar 13, 2020

matticbot commented Mar 13, 2020

beaucollins commented Mar 13, 2020

beaucollins commented Feb 25, 2020 •

edited

Loading

jetpackbot commented Feb 25, 2020 •

edited

Loading

artpi commented Mar 5, 2020 •

edited

Loading