Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Scan card layout looks bad when threats are found #15052

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Dashboard: Scan card layout looks bad when threats are found #15052

merged 1 commit into from
Mar 20, 2020

Conversation

sergeymitr
Copy link
Contributor

Dashboard: Scan card layout fix (issue #14914)

When threats are found, the "Scan" card styling gets a little bit messed up.

Fixes #14914

Changes proposed in this Pull Request:

Minor styling adjustments.

Testing instructions:

Steps to reproduce the issue:

  1. Purchase a Jetpack plan (Premium or Pro)
  2. Install/activate VaultPress
  3. Go to the Jetpack AAG dashboard in wp-admin
  4. In Jetpack footer, click "Dev Tools", and then click the button for "threats":

76113550-5b5f2180-5fb2-11ea-9271-671328dac3d6

  1. Scroll up to the "Security" section, find the "Scan" card.
    This is what you should see:

Screen Shot 2020-03-19 at 4 21 41 PM

If you see this, the fix does not work:
Screen Shot 2020-03-19 at 4 05 57 PM

Proposed changelog entry for your changes:

No entry needed.

@sergeymitr
Jetpack Dashboard: Scan card layout looks bad when threats are found…
234f63c 
… (issue #14914)

Minor styling adjustment for the "Security -> Scan" dashboard widget.
The problem only appears if there are threats found.
More information and steps on how to reproduce: #14914
@sergeymitr sergeymitr requested a review from a team March 19, 2020 21:28
@sergeymitr sergeymitr self-assigned this Mar 19, 2020
@sergeymitr sergeymitr changed the title Jetpack Dashboard: Scan card layout looks bad when threats are found… Dashboard: Scan card layout looks bad when threats are found Mar 19, 2020
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 234f63c

@sergeymitr sergeymitr added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Mar 19, 2020
@jeherve jeherve added [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended Admin Page React-powered dashboard under the Jetpack menu labels Mar 20, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 20, 2020
keoshi
keoshi approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thank you for doing this! 🛳

@keoshi keoshi added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels Mar 20, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 20, 2020
jeherve
jeherve approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me. Merging!

@jeherve jeherve merged commit 9dc02e1 into master Mar 20, 2020
@jeherve jeherve deleted the fix/dashboard-scan-card-layout branch March 20, 2020 10:12
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 20, 2020
jeherve added a commit that referenced this pull request Mar 23, 2020
@jeherve
Changelog: add #15052
8fdf9be
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@keoshi keoshi keoshi approved these changes

Assignees

@sergeymitr sergeymitr

Labels
Admin Page React-powered dashboard under the Jetpack menu [Status] Design Review Complete [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

Jetpack Dashboard: Scan card layout looks bad when threats are found
5 participants
@sergeymitr @jetpackbot @keoshi @jeherve @matticbot