Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crowdsignal: Fix poll embeds on P2 #14826

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Crowdsignal: Fix poll embeds on P2 #14826

merged 2 commits into from
Mar 5, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 27, 2020

This commit syncs r203465-wpcom.
D35940-code

Fixes 478-gh-greenhouse

Changes proposed in this Pull Request:

P2 appears to load posts async, so the Crowdsignal code was attempting to load content into a div that wasn't in the DOM yet. This workaround adds a delay to the rendering call from the Crowdsignal js.

Testing instructions:

  • Insert a crowdsignal link or shortcode for a poll into a P2 post. It should render the poll and you should be able to place your vote. Also ensure that poll shortcodes still work as expected on other themes.

Proposed changelog entry for your changes:

  • Shortcodes: Fix Crowdsignal poll embeds when using the P2 theme.

@roundhill @jeherve
Crowdsignal: Fix poll embeds on P2. Refs D35940
4fa48e0 
This commit syncs r203465-wpcom.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Dotcom Merge [Status] Tested on WP.com labels Feb 27, 2020
@jeherve jeherve added this to the 8.4 milestone Feb 27, 2020
@jeherve jeherve requested a review from a team February 27, 2020 08:35
@jetpackbot
Copy link

jetpackbot commented Feb 27, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against d72ba80

roundhill
roundhill previously approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 5, 2020
@jeherve jeherve merged commit 7393c78 into master Mar 5, 2020
@jeherve jeherve deleted the fusion-sync/jeherve/r203465-wpcom-1582792371 branch March 5, 2020 16:25
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 5, 2020
@jeherve
Copy link
Member Author

jeherve commented Mar 5, 2020

r203910-wpcom

jeherve added a commit that referenced this pull request Mar 20, 2020
@jeherve
Changelog: add #14826
39cf90e
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@roundhill roundhill roundhill left review comments

Assignees

@roundhill roundhill

Labels
[Feature] Shortcodes / Embeds [Status] Tested on WP.com [Type] Bug When a feature is broken and / or not performing as intended [Type] Dotcom Merge
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @jetpackbot @kraftbj @roundhill @matticbot