Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg 7.2.0: replace legacy editor- classes with block-editor- #14446

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Gutenberg 7.2.0: replace legacy editor- classes with block-editor- #14446

merged 1 commit into from
Mar 20, 2020

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented Jan 23, 2020 •
edited
Loading

Gutenberg 7.2.0 & 7.3.0 removed legacy editor- classes in WordPress/gutenberg#19050 and WordPress/gutenberg#19489. This PR updates references to legacy classes found in these PRs and the Gutenberg repo.

These were refactored in the aforementioned PRs:

editor-warning
editor-warning__message
editor-media-placeholder
editor-block-list__block
editor-plain-text

These were found in Gutenberg with the newer format (possibly updated in other revisions - need to check):

editor-block-preview__content

Testing instructions:

Booted a local Jetpack environment with this PR and compared with a site on WPCOM. Some visual regressions spotted:

Markdown

Before

Screenshot 2020-01-29 at 4 40 51 PM

After

Screenshot 2020-01-29 at 4 40 45 PM

Recurring Payments button (block nudge)

Before

Screenshot 2020-01-29 at 4 54 46 PM

After

Screenshot 2020-01-29 at 4 54 35 PM

Contact Info

Before (on focus)

Screenshot 2020-01-29 at 5 08 50 PM

After (on focus)

Screenshot 2020-01-29 at 5 09 17 PM

Proposed changelog entry for your changes:

Not sure.

@chriskmnds chriskmnds requested review from a team January 23, 2020 18:07
@chriskmnds chriskmnds self-assigned this Jan 23, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello chriskmnds! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38073-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Jan 23, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against aca56b6

@chriskmnds chriskmnds mentioned this pull request Jan 23, 2020
Closed
23 tasks
@kraftbj kraftbj added this to the 8.2 milestone Jan 23, 2020
@kraftbj
Copy link
Contributor

kraftbj commented Jan 23, 2020

Are these changes fine with the editor as it shipped in WP 5.2? Based on https://make.wordpress.org/core/2019/04/16/wordpress-5-2-field-guide/, it looks like G 5.4 shipped with WP 5.2 and the block-editor namespacing was added in G 5.3, so I think this is fine, right?

@jeherve jeherve added the [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack label Jan 24, 2020
@chriskmnds
Copy link
Contributor Author

Are these changes fine with the editor as it shipped in WP 5.2? Based on https://make.wordpress.org/core/2019/04/16/wordpress-5-2-field-guide/, it looks like G 5.4 shipped with WP 5.2 and the block-editor namespacing was added in G 5.3, so I think this is fine, right?

I believe so. This is the relevant PR that shipped with 5.3.0: WordPress/gutenberg#14420

@jeherve jeherve modified the milestones: 8.2, 8.3 Jan 27, 2020
@chriskmnds
Copy link
Contributor Author

Updated the description with a few visible regressions that I was able to spot. cc @jeherve

@jeherve
Copy link
Member

jeherve commented Feb 19, 2020

@chriskmnds Do you think this would be ready for a review?

@simison simison added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Feb 19, 2020
@simison
Copy link
Member

simison commented Feb 19, 2020

I believe this is good for testing and merging.

jeherve
jeherve requested changes Feb 20, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to test well in WordPress 5.2 and 5.3, but I see this when using the Gutenberg plugin:
image

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 20, 2020
@jeherve jeherve removed this from the 8.3 milestone Feb 20, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 4, 2020
@jeherve jeherve mentioned this pull request Mar 4, 2020
Closed
14 tasks
@jeherve jeherve mentioned this pull request Mar 13, 2020
Closed
@simison
Copy link
Member

simison commented Mar 19, 2020

@jeherve since this already fixed lots of things, let's merge and leave markdown fixea for a separate PR?

@jeherve jeherve force-pushed the fix/gutenberg-7.2.0-classnames branch from 3b3138b to aca56b6 Compare March 20, 2020 09:51
@matticbot
Copy link
Contributor

chriskmnds, Your synced wpcom patch D38073-code has been updated.

jeherve
jeherve approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this as is for now!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Mar 20, 2020
@jeherve jeherve merged commit e454873 into master Mar 20, 2020
@jeherve jeherve deleted the fix/gutenberg-7.2.0-classnames branch March 20, 2020 10:59
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 20, 2020
@jeherve
Copy link
Member

jeherve commented Mar 20, 2020

r204563-wpcom

jeherve added a commit that referenced this pull request Mar 23, 2020
@jeherve
Changelog: add #14446
4459413
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@chriskmnds chriskmnds

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.
6 participants
@chriskmnds @matticbot @jetpackbot @kraftbj @jeherve @simison