Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicize block: Update wording on the publicize block placeholder message to reflect feature behavior #15138

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Publicize block: Update wording on the publicize block placeholder message to reflect feature behavior #15138

merged 2 commits into from
Mar 27, 2020

Conversation

bisko
Copy link
Contributor

@bisko bisko commented Mar 26, 2020

Fixes #15115

Changes proposed in this Pull Request:

This PR updates the wording in the Publicize block placeholder to reflect the actual behavior of the feature.

The old version said that it was only going to use the post title when generating the publicize message, while it is actually using the post content as the source for the snippet.

Testing instructions:

  • Connect a social account
  • Create a new post
  • Click Publish
  • In the confirmation popup click Share this post to expand the share form
  • Remove the content of the message box
  • Confirm the message was updated properly

Proposed changelog entry for your changes:

  • Update wording on Publicize block to reflect the actual feature behavior.

@bisko bisko added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Publicize Now Jetpack Social, auto-sharing [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 26, 2020
@bisko bisko requested a review from a team March 26, 2020 15:58
@bisko bisko self-assigned this Mar 26, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello bisko! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40912-code before merging this PR. Thank you!

jeherve
jeherve reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only an excerpt and not the full content, should we say excerpt and instead of content?

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 26, 2020
@jetpackbot
Copy link

jetpackbot commented Mar 26, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 63859b6

@matticbot
Copy link
Contributor

bisko, Your synced wpcom patch D40912-code has been updated.

@bisko bisko added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Mar 27, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 27, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 27, 2020
@bisko bisko merged commit d6e29d4 into master Mar 27, 2020
@bisko bisko deleted the fix/publicize-block-update-wording-on-message branch March 27, 2020 10:19
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 27, 2020
@bisko
Copy link
Contributor Author

bisko commented Mar 27, 2020

Deployed on WPCOM in r204941-wpcom

jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
Changelog: add #15138
309e7a4
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@bisko bisko

Labels
[Feature] Publicize Now Jetpack Social, auto-sharing Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.

Publicize: Default custom message shows wrong instructions
4 participants
@bisko @matticbot @jetpackbot @jeherve