-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Add search plan to dashboard #15153
Conversation
* Add Instant Search feature gate * Add Jetpack Search to the Plans page
* Add Search plan constants * Tweak At-A-Glance Search Component * Move Search and Media to top of Performance tab * Enable toggling Instant Search via Performance tab * Check for Instant Search eligibility w/ plan class * Add Search plan to the developer menu * Improve copy in Performance settings Co-authored-by: Greg Ichneumon Brown <greg@automattic.com> Co-authored-by: Filipe Varela <keoshi@keoshi.com>
* Update markup for the product card * Update styles
Method to auto config the search widgets based on registered post types and taxonomies
Co-authored-by: Jason Moon <jason.moon@automattic.com>
* Add handling for pricing and tier APIs * Use a unified loading state for single feature products
Caution: This PR has changes that must be merged to WordPress.com |
This is an automated check which relies on |
Did a brief code review of the PR and didn't see any immediate concerns that jumped out. The big item on this is going to be testing and regressions to Plans
Misc Notes: |
We had to substantially refactor parts of Backups components in the Plans page. There shouldn't be any changes to its behavior, however.
As I understand it, the Business/Professional plan will retain the ability to enable the Jetpack Search module. However, it will not be able to enable the new Instant Search feature.
👍 The only noticeable difference should be the ability to enable Instant Search with an active Jetpack Search product purchase. |
* Add Search product purchase detection * Remove Instant Search feature gate for Plans page * Simplify Plans page by only using SiteProducts * Remove mention of the enhanced search for biz plan * Use new PurchasedProductCard component * Update copy * Fix malformed and missorted imports * Add preliminary support for Search product option * Use consistent naming for selector function * Don’t return anything for useEffect function * Bypass search support check in the JetpackPlan class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as Approved.
No concerns at a code level, This needs copious levels of testing on plans and to ensure no regression to search. I've done a walk though on my site for different scenarios ( different plans, content sizes, etc) without any blockers being identified.
* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description
This merges the changes to the JP dashboard that allow management of the new Search Plan.
What is missing:
Testing Instructions: