Merge develop into customer-journey#4086
Merged
hawflau merged 51 commits intoaws:customer-journeyfrom Jul 29, 2022
Merged
Conversation
Fix describe_stack_events with long sleep delay Replace describe_stack as the event has the stack status Fix events order Stop loop at first not in progress
* update safe tear down for logs test * add safe teardown for sync code Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
…ambda functions of Image Type (aws#3922) * feat: remove the created intermediate containers while building the Image type lambda functions * adding integration test case * apply black * apply PR comments
…33e11271c3156cc0) (aws#3939) Co-authored-by: GitHub Action <action@github.com>
…37bc077d40c0cc19) (aws#3940) Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Lau <lauwing@f8ffc25e8e59.ant.amazon.com>
* Update command option text * Use curly braces Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* Added --s3-bucket and --s3-prefix flags to sam delete * Added and fixed tests for --s3 flags for sam delete * Added integration tests and cleaned up format and log messages * Added type hinting and fetch region from boto3 session * Expanded arguments * Reverted warning message back to only warn on missing bucket info Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* Add in test data * Modify test cases to include sync code nested tests * Disabling rest api and state machine test since nested does not have proper support * Refactoring fix * Added test case for resolving GetAttr intrinsics * Repath for Api and StateMachine tests
* Fix issue in cloning app templates repo in windows * Fix tests to address non windows cases * Add debug message * Fix pylint issue
…Functions (aws#3948) * Add in support for nested stack's code sync with Api and StepFunction resources * Add property to access protected variable * Remove unused import * Consistency in return type for definition files * Make location attribute type safe * Remove redundant casting * Remove unused import * Refactor to have a common helper * Enable rest api and statemachine nested integration test * Add docstring for new method Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* Add logic for reading layer contents * Parameterize ADL for existing tests * Add nodejs test * Skip CDK templates * Use Pathlib for paths * Update remaining paths Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* add logs integration tests files * add most part of it, needs validation * updated tests and validated * address pr comments
* fix: revert not creating ADL for empty dependencies * add integration tests * update integration tests * address pr comments * black formatting
* ux: don't display managed s3 bucket location & capabilities which was printed below * update logging messages from build definition uuid to resource name list * use yellow fg for experimental flag confirmation * fix warning message for sfn invalid logging configuration * fix accidental deletes from earlier commits * rest of the ux improvements * unit tests * update unit tests * fix parameter name * address pr comments * additional tests to confirm sam logs validation * add default exception handler to traces as well * build tests regex changes * fix test cases * black formatting
* require Flask 1.1.4 * make update-reproducible-reqs Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
…8666c74fe758e68a) (aws#3959) Co-authored-by: GitHub Action <action@github.com>
* Added --s3-bucket and --s3-prefix flags to sam delete * Added and fixed tests for --s3 flags for sam delete * Added integration tests and cleaned up format and log messages * Added type hinting and fetch region from boto3 session * Expanded arguments * Reverted warning message back to only warn on missing bucket info * Reverted removal of string casting * Fixed default arguments Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* bump cookiecutter version to address CVE * Handle TypeError from cookiecutter * fix pylint violation
* Update sam logs setup to align with function update * fix: don't use same layername in the template otherwise they will override themselves * fix build tests * downgrade python version for windows tests & add missing fields for adl sync tests * re-format
Co-authored-by: Qingchuan Ma <69653965+qingchm@users.noreply.github.com>
* fix: clean build folder before starting sync operation * use function or layer build folder Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com>
…uccess message (aws#3986) Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
aws#3988) * use cache build instead of incremental when building in container * use self reference
…ws#3990) make sure all pullers in child combine puller also get stopped
* Add resource type validation for sync --code * Refactor to use click.Choice and fix integration tests * Add help text in option description * Update samcli/commands/sync/command.py Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com> * Remove debug flag for clean integ test output Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com>
* chore: replace InvokeContextException with granular ones * but InvokeContextException back and extend other classes from it Co-authored-by: Qingchuan Ma <69653965+qingchm@users.noreply.github.com>
…ws#4013) Co-authored-by: Qingchuan Ma <69653965+qingchm@users.noreply.github.com>
* chore: remove accelerate beta experimental flag (aws#3973) * remove beta experimental flag * fix the if check for name * use text variable directly * fix unit tests * fix unit test and remove accelerate flags * remove accelerate beta feature flag * skip accelerate experimental test * fix build tests Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> * fix integration tests * fix unit and integration tests * reformat * docs: Update logs and traces docs (aws#4009) * Update logs and traces docs * Fix typos Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com>
…ler (aws#4016) Co-authored-by: Lucas Cimon <ext.lucas.cimon@sncf.fr>
* Fix typo in doc * Replace last_event_time with execution_time To not skip events in case of throttle * Update tests for execute_changeset and wait_for_execute * Document execution_time and set a default value Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Daniel Mil <84205762+mildaniel@users.noreply.github.com>
* README.md Updated Updated README.md typo fixes. * Update README.md
…b52abadeacdddaf8) (aws#4030) Co-authored-by: GitHub Action <action@github.com>
* blogs * Readme update * more * some more * roadmap * adding pip * added powertools * adding more outbound links * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Update README.md Co-authored-by: Chris Rehn <crehn@outlook.com> * Adding sam validate in help context in the CLI. * updating per Mehmet's feedback * adding recent launches to readme * updating readme * minor updates * updated - removed beta keyword for accelerate Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com> Co-authored-by: Chris Rehn <crehn@outlook.com> Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> Co-authored-by: Qingchuan Ma <69653965+qingchm@users.noreply.github.com>
* Don't use deps dir for non-cached builds * Remove unused import * Fix test, rename variable to cached * Make default cached false * Add function definition * Remove debug prints
* Fixed describe stack events reporting wrong events * Revert removal of method and its tests * Added test to check output on stack update * Fix make black * Removed unnecessary parameter for execution time.
github-actions
bot
added
pr/external
stage/needs-triage
hawflau
approved these changes
Jul 29, 2022
hawflau
removed
the
stage/needs-triage
torresxb1
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
N/A
Why is this change necessary?
This commit serves to prepare this branch for merge into the primary
developbranch.How does it address the issue?
N/A
What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.