Warn on S-interpolator usage for assert, assume and printf (backport #2751) #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Add a "handover" option that augments circt.stage.ChiselStage to lower using a combination of the Scala FIRRTL Compiler (SFC) followed by CIRCT. The handover can be set at CHIRRTL (don't run the SFC), High FIRRTL, Middle FIRRTL, Low FIRRTL, or Optimized Low FIRRTL. Include tests of this behavior by looking at the FirrtlCircuitAnnotation that exists before running CIRCT for different handover values. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
…able-handover Add --handover option to lower partially using SFC
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
…-publish Add publishing to sonatype
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
- Add Maven release, Sonatype snapshots, and Javadoc.io badges - Improve setup instructions Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Add an option to output using a "*.v" suffix. This is still using the CIRCT SystemVerilog back end, though. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Change command line option passed to "firtool" due to upstream change. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Change "RTL" to "HW"
* Enable CI for 3.5.x branch * Enable Mergify for 3.5.x branch * Drop 3.5.x from Mergify
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
* add mill build system * bump to Chisel 3.5.0 * use cross build to select Scala version. * add gitignore * Add/use Compiler Plugin
…hots Bump to 3.6-SNAPSHOT
…iance#2352) This only includes a merge-based flow which will presumably be squash-and-merged for any merged PRs. It is possible to do this with rebasing but it is tricky and hard to describe in a fool-proof way.
#naming implies within the current file. Removing the # refers to a file in the current directory.
The new reflection based IO autowrapping for compatibility mode Modules would previously throw a NullPointerExceptions if any hardware were constructed in the Module before "val io" was initialized. The logic is now more robust for this case. Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Fix the QMC bug for constant and dontcare output. * Fix the Espresso bug for constant and dontcare output.
Co-authored-by: Jack Koenig <koenig@sifive.com>
Add macro for determining Chisel structural subtypes. This replaces the use of built-in <:< for determining what types can be cast with .viewAsSuperType.
* Cleanup Cookbook and printing docs * Format specifiers are actually concise now Co-authored-by: Megan Wachs <megan@sifive.com>
This enables emission of modules that serialize to >2 GiB of .fir text.
) Previously, failed jobs in the CI matrix would cause the sentinel job (all-tests-passed) to be skipped, which for purposes of Github Actions branch protection would count as "success". This allowed PRs with failing CI to be merged. This new approach which uses two sentinel jobs should not suffer from this same issue.
The command line options for CIRCT's firtool command have been updated.
Treadle will be used as the "defaultBackend" when the environment variable CHISEL3_CI_USE_TREADLE is set. The intent is to set this variable during CI for pre-merge CI (aka on pull requests).
Use Treadle (on pull requests only) to speed up CI
Co-authored-by: Megan Wachs <megan@sifive.com>
Update a callsite. Rename function in Printf.scala to match the naming convention in the file. Undo call by name change to preserve binary compatibility.
Better docs for the error Update error message to not mention the p-interpolator
|
Chose the wrong source branch, unable to change it on github.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #2751, change errors to warnings
Contributor Checklist
docs/src?Type of Improvement
API Impact
Backend Code Generation Impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.