Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support XMP in SVG #771

Merged
merged 4 commits into from
Dec 16, 2024
Merged

fix: Add support XMP in SVG #771

merged 4 commits into from
Dec 16, 2024

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

Add support for XMP in SVG. Fix other anomalous XMP issues for other file formats.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 93.47079% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (612a8a8) to head (f379b73).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/asset_handlers/svg_io.rs 91.62% 17 Missing ⚠️
sdk/src/asset_handlers/bmff_io.rs 0.00% 1 Missing ⚠️
sdk/src/utils/io_utils.rs 98.68% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
+ Coverage   80.59%   80.62%   +0.02%     
==========================================
  Files         117      117              
  Lines       31536    31809     +273     
==========================================
+ Hits        25417    25646     +229     
- Misses       6119     6163      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauricefisher64 mauricefisher64 merged commit fe4d6e0 into main Dec 16, 2024
29 checks passed
@mauricefisher64 mauricefisher64 deleted the xmp_fixes branch December 16, 2024 20:58
This was referenced Dec 16, 2024
@scouten-adobe scouten-adobe mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants