vets-api/v0.0.1438

Release 0.0.1438 ami-03bf2de91fece3523

e1767b3 Mobile: Add guard against users that cannot access preferred name and gender identity (#12786)

• WIP

• Update docs and revert test changes

• Fixes

• updated spec

• Update specs to pass and test all scenarios

• Update last specs so that all pass

• Merge policies and include in global directory

• WIP

• Update docs and revert test changes

• Fixes

• updated spec

• Update specs to pass and test all scenarios

• Update last specs so that all pass

• Merge policies and include in global directory

• Attempt reset of generate_static_docs.sh

• Attempt reset of generate_static_docs.sh

48bb89d Fixing uninitialized constant benchmarklogger (#12797)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io

3bbb732 update brakeman (#12808)

60421fe Bump googleauth from 1.3.0 to 1.5.2 (#12406)

Bumps googleauth from 1.3.0 to 1.5.2.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: googleauth
  dependency-type: direct:production
  update-type: version-update:semver-minor
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rebecca Tolmach 10993987+rmtolmach@users.noreply.github.com
Co-authored-by: Ryan McNeil ryan.mcneil288@gmail.com

e6fabac mobile - allow nil dates in LH claims overview (#12796)

c58f74e Bump sidekiq_alive from 2.2.0 to 2.2.1 (#12714)

Bumps sidekiq_alive from 2.2.0 to 2.2.1.

• Release notes
• Commits

---

updated-dependencies:

• dependency-name: sidekiq_alive
  dependency-type: direct:production
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

f577191 Update appt ids in docs to be more accurate (#12800)

• Update appt ids in docs to be more accurate

• update cc appointment ids

• regen docs

• regen docs

a11ae7f Bump parallel_tests from 4.2.0 to 4.2.1 (#12713)

Bumps parallel_tests from 4.2.0 to 4.2.1.

• Changelog
• Commits

---

updated-dependencies:

• dependency-name: parallel_tests
  dependency-type: direct:development
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil@oddball.io

b70aa6d API-25894 Save Benefits Intake file sizes (#12799)

Adds the file size (in bytes) of all PDFs (main content and attachments)
uploaded via the Benefits Intake API to the set of saved metadata

6178066 4195 update endpoint to receive letters from lighthouse (#12765)

• updated endpoints to pull from lighthouse - wip

• renamed letters specs

• fixed vcr and removed skip

• fixed vcr and get letters -wip

• rubocop fixes

• added benefits VCR and added adapter to controller

• fixed serializer for lighthouse letters

• added download cassettes with specs and updated service used

• created subclass of service and configuration / rubocop fixes

• added beneficiary/military data

• removed additional post request from specs

• fixed download and error handling specs

• removed benefit cassette

• rubocop fix

• changed service from mobile lighthouse back to lighthouse

• removed subclassed config ands service file for letters

• moved lighthouse letters cassettes to root folder and fixed cassettes path in specs

• removed empty spaces

• fixed specs

• changed context of spec test

cbd9460 Direct deposit client get with exception handling (#12805)

• Direct deposit client response changes for getting payment info and handling exceptions

• Update swagger docs and specs

• Remove unused spec file

• Update swagger docs

b93fdaa API-26689: No need to scrub the doc_type key anymore as it does not exist (#12782)

aff920c API-26964: Add Forms Modernization Team to Benefits Intake Prod email reports (#12806)

f8da2ec API-26838 Remove vba_documents_larger_page_size_limit flag (#12811)

cb0490a mobile claim copy update (#12809)

9eaf935 [bug] Update identifier key name and add notify template id reference (#12802)

• Add template id and key name updates

• Update spec api key reference

5ecee59 Add authorization for VBS API in copay controller (#12784)

vets-api/v0.0.1437

Release 0.0.1437 ami-080258ad88f45ede8

36b6211 Update Appealable Issues API v0 OAuth scopes (#12779)

The scopes */ContestableIssues.read have now been renamed to
*/AppealableIssues.read on the server side, so we can remove the old
scopes.

89b0029 API-26932 Update Appeals Status API v1 description (#12787)

fe22402 13320 income limits sidekiq jobs (#12791)

• Income limits data import jobs added

• schedule quarterly

• unit test update

• test vcr

• updated tests

• type

• test update

• updated fetch logic and test

• typo

• test fix

• test fixes

• hash values for test

• hash values for test

• test fix

• test fix

• test data

• csv data fix for tests

• csv format

• csv data fix

• csv data fix

• csv data fix

• data update

• response code error

• tests added for IL sidekiq jobs

• cleanup

02576de 13320 GMT and County import jobs for Income Limits (#12732)

• county and gmt jobs for income limits added with tests

• lint

• tests fixed, scheduler fixed

9027b3c 58164 Parse JSON file from VBS for copay notifications (#12768)

• [57447] Add initial boilerplate for find profile by Vista (#12527)

• Add initial boilerplate for find profile by Vista

• Fix misspelling

• [57450] Create find profile by facility service method (#12571)

• Build request body for find profile by facility

• Update service for find by vista -> facility

• Add specs for find profile by facility

• Add workers to parse and send statement notification

• Update controller and service to leverage statement workers

• Clear up verbiage for find profile by facility parameters

• Clean up trailing whitespace

• Update mpi service spec for facility updates

• Add logic and tests for copay statement notification jobs

• Update namespace for copay email job and add more specs

• Adjustments to specs

• Variable name change

a26232b Call LH token on each request to avoid annoying expired token error (#12760)

• Call LH token on each request to avoid annoying expired token error

• Fix auth header

2da5c84 5310: remove location logging (#12793)

2a4e75a Remove profile_email_specify feature toggle (#12595)

7f29ba9 Api 26149 evss docker service (#12754)

• Add base service

• Move token to separate file

• Pull form_data from claim

• Pull auth_headers from claim also

• Rename service to not conflict with other EVSS

• Add to v2 526 controller

• Only check addr attr if needed

c041f02 Vfep 603 - add functionality for different types of chapter 33 selections in form 1995 (#12772)

• chapter33 json schema changes

• backed out addition of db columns and updated code

• Fix failing tests

• Fix rubocop issues

• update vets-json-schema to point to updated master

• remove eager load

• Add tests related to chapter33 changes

• update json-schema hash

---

Co-authored-by: nfstern02 Noah.Stern@va.gov

15dd02c fixes header + updates styling (#12798)

5147e0b Additional testing for branch protection settings (#12778)

• Additional testing for branch protection settings

• Allow admin bypass checks

4db3b8a Filter out claims with certain statuses (#12762)

• Filtering out claims with certain statuses

• Adding Pundit check to benefits claims controller

• Remove puts statement; adding super to init function for benefits claims service

315d3e8 Mobile - add maintence window async job (#12781)

vets-api/v0.0.1436

Release 0.0.1436 ami-0119e107e273a78be

5116968 Finalize appeals rswag updates (part 2) (#12744)

• Removes the API_NAME and API_VERSION environment variables and their
  dependents from DocHelpers; Refactors schema-generating methods in
  the rswag config accordingly
• Updates appeals rswag rake tasks so that all docs are generated at
  once (instead of offering one task per API)
• Actual outputs of docs specs still have not changed

75bd9cc renamed evss specs and removed lighthouse specs (#12774)

a02300c Configure Branch Protection Settings via .github/settings.yml instead of UI (#12681)

• create .github/settings.yml file

• add new line to end of file

• Optional require branch up to date before merging

• Restrictions null

---

Co-authored-by: Ryan Johnson ryan.johnson@oddball.io

da1561b wrap contention classification code in rescue (#12766)

• wrap contention classification code in rescue

• fix exception handling

• capture 500 codes for CC in _spec

• fix rubocop issues

6fe2186 API-26271-526-v2-sec-5-disability-pdf-mapping (#12725)

• Adds some logic for disability mapping

• Adds most of disability pdf mapping

• flattens secondary disabilities & maps them.

• Removes unneeded attributes, and adds more test expectations.

• Refactor

• Adds test for the hasConditionsRelatedToToxicExposures attribute

aef1a79 refactor(vaos): remove unused find_service_type_and_category method and related logging (#12769)

dfb92bc Add HLR disable submit feature (#12775)

627152d 5310: remove unnecessary logging (#12776)

4d0a246 Adds pdf mapping for 526-v2-tx-centers (#12733)

• Adds pdf mapping for 526-v2-tx-centers

• Cleanup

• Addresses PR comments

• Removes line that created an empty obj for claimInfoormation

a084453 Api 24832 526 v2 section 5 treatment centers validation (#12752)

• Moves over elements from v1

• Adds beginnings of validations moved over from v1

• Fixing Gemfile inclusion

• Sets up validations and RSPEC, lint and tests are green

• Removes uneeded methods in the validation file, cleans up the RSpec tests

• Cleans up validator file more and RSpec tests

• Cleans up RSpec and validator file, updates 526 schema for string value that changed from array
  API-24832

  • Adds a few more RSpec tests for some user-submitted string scenarios
  • Updates REGEX pattern for center names so a single empty space does not match
  • Updates 526 schema file for treatedDisabilityname to move from some array values from old set up to string values (Length in place of Items for min and max )
    Changes to be committed:
    modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
    modified: modules/claims_api/config/schemas/v2/526.json
    modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
    modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb

• Updates validator method and RSpec to include secondary disabilities listed in the check of treated disability names after comment on ticket

• Updates treatedDisabiltiyNames to be an array of strings, updates RSPec and validation as well as schema,request and example json files

a2901e9 Claims API v2 handle hash in index (#12764)

• handles hash in index

• remove nil

3527e48 Potentially fixing flaky specs in claims api (#12783)

• Potentially fixing flaky specs in claims api

• Fix for treatment center PDf mapper test, updates pdf mapper to create expected values and updates test for those values

---

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io
Co-authored-by: rockwellwindsor-va rockwell.rice@oddball.io

ce300e2 [12634] Adding private_key_jwt flow to sign in service (#12690)

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io
Co-authored-by: Ryan McNeil ryan.mcneil288@gmail.com

cbbabed Refactor specs for bug squashing (#12758)

5460a51 Ensure larger page size limit is enabled for Benefits Intake (#12785)

Co-authored-by: Drew Fisher 142862+cilestin@users.noreply.github.com

b3d0da6 API-26689: Stop storing doc_type in UploadSubmission metadata (#12780)

cbce5bb [API-25973] Add healthchecks to all endpoint versions (#12773)

1fee3f8 [department-of-veterans-affairs/va-virtual-agent#951] Setup flipper for JWT fetching in the front end (#12736)

• [department-of-veterans-affairs/va-virtual-agent#951] Setup flipper for JWT fetching in front end

  Co-authored-by: Alex Person alex.person@thoughtworks.com

1. create a new flipper
2. Add Aaron & Alex as flipper admins

• Co-authored-by: Alex Person alex.person@thoughtworks.com

d3cf39a Hotfix UTC conversion (#12737)

*hotfix for timezoneid and local time field

Co-authored-by: Tonksthebear jasonconig@me.com

vets-api/v0.0.1435

Release 0.0.1435 ami-0e0e31adfab09a65b

85d6550 Feature - call VRO contention classification service for some 526-ez claims (#12638)

• Add skeleton

• Minor syntax fixes

• Linting

• Fix syntax error

• Minor updates

• Adding stuff from meeting

• Minor updates, debugging, linting

• Add spec that inserts form526 submissions into postgres for local testing

• add new feature flag for contention classification service

• Add exploratory changes from pairing session

• wip hit classification endpoint, spec file stuff

• Clean up branch

• get _spec.rb to POST to contention classfication endpoint

• check flipper before classification

• check for diagnostic code before submitting

• add it block for testing cc w/o diagnostic code

• another one for feature flag off

• update CC call to use VRO client

• fix vro client import

• Point VRO client at localhost contention classifier endpoint

• update vcr cassette for VRO cc request

keep contention classification disabled for most tests

fix client_spec, delete outdated test cases

Update VRO client to be RRD-agnostic

Fix VRO client test

Clean up submit_form526_all_claim_spec

• Fix rubocop failures

• more rubocop fixes

• gitignore .DS_STORE

• resolve rubocop yelling about spec file format

• remove spec for adding to database

• remove obsolete constants

• remove comment

• update VCR cassette to use contention classification request one

---

Co-authored-by: Carly Jones carly.jones@coforma.io
Co-authored-by: Kyle Soskin kyle.soskin@adhocteam.us
Co-authored-by: Yang Yang yangyang@navapbc.com

dcc2bf1 5310 remove logging low hanging fruit (#12755)

• 5310: remove unnecessary logging

ba4df50 mobile VA rep copy update (#12759)

73b9ec1 Remove remaining RRD processor code (#12761)

• Remove RRD processor code

• Remove remaining RRD Flipper flags

---

Co-authored-by: Ryan McNeil ryan.mcneil288@gmail.com

02dea09 58537 Add datadog metrics for travel claim responses (#12757)

• 58537 Add datadog metrics for travel claim responses

13bbe0c Add find MPI profile by facility method (#12622)

• [57447] Add initial boilerplate for find profile by Vista (#12527)

• Add initial boilerplate for find profile by Vista

• Fix misspelling

• [57450] Create find profile by facility service method (#12571)

• Build request body for find profile by facility

• Update service for find by vista -> facility

• Add specs for find profile by facility

• Clear up verbiage for find profile by facility parameters

• Clean up trailing whitespace

• Update mpi service spec for facility updates

vets-api/v0.0.1434

Release 0.0.1434 ami-0d4bc75c1b17dce56

dd499dc API-25981 Make VAForms::FormBuilder less chatty in slack (#12730)

02dd7dd switch out mobile claims service with Benefit claims service (#12724)

a246e6f add logging around shutdown callback (#12740)

34d1708 Orphaned queue cleanup job (#12746)

• Add queue cleanup job

• add spec

• rubocops

• fix specifically for dev env

• newline

21fe8ea Mobile Claim hotfix (#12745)

c2c9408 58604 Modifying appointment date format for travel claims (#12743)

• 58604 Modifying appointment date format for travel claims

• Fix spacing

• Adding variable for formatted date

---

Co-authored-by: kanchanasuriya ksuriyamoorthy@kindsys.us

629d90a Mobile: Secure messaging thread schema update (#12738)

• Add v1 message thread endpoint using new api

• Remove pointless override

• Copy over vcr, remove module from controller, add more thorough tests

• Remove redundant test

• Reset cassettes after tests

• Change name of test

• Debug failures

• Relocate cassette and uncomment test

• Add back .to_i for params[:id]

• Add logging to debug

• Debugging

• Further changes required by new serializer

• Update to use new schema from upstream

• Remove extra route

---

Co-authored-by: Andrew Herzberg andrew.herzberg@adhocteam.us

07dd801 VAOS: Set Appointments 'cancellable' Flag to False for Covid Appointments (#12739)

• refactor(vaos): extract method to check if appointment is for compensation and pension

• feat(vaos): updated appointments service to set cancellable flag to false for covid appointments, also added/updated rspecs.

f2122b7 API-26673-526-v2-schema-alternate-names (#12698)

• Changes properties of 'alternateNames'.

• Adds items to array in schema

• Changes properties of alternate names

f2fcfcf Api 26589 v2 itf request format (#12688)

• Updates Controller, RSpec and validator to enforce nesting of requests inside data and attributes

• Refactors error code according to example in docs, refactors RSpec tests

• Rubocop linting fixes, tests are green

• Fixing my gemfile mistake

• Updates validate_request_format so it checks for existance attributes object after data object

• Rubocop lint, tests green

e089a34 Bdex/57063/migrate get intent to file to lighthouse (#12623)

• implement GET request for Lighthouse intent-to-file

• modify BenefitsClaims::Service to request intent to file data

• extend BenefitsService::Configuration to handle different consumer/client needs

• modify existing BenefitsClaims index and show operations to handle new configuration

• add parameters to fix evss method, move transform to private method, rm unneeded comment

• add error handling and request specs

• fix a few request specs

• fix some tests to accommodate provider pattern

• fix rubocop errors, add tests to lighthouse itf provider

• a little cleanup, fixing errors in lighthouse service, config, and spec

• minor tweak for Rubocop and require needed files

• avoid errors in mobile

• rm unused params

---

Co-authored-by: Ryan McNeil ryan.mcneil288@gmail.com

6af7940 MHV-42054: Labs and tests api complete (#12741)

Co-authored-by: wright0776 matwright2010@gmail.com

vets-api/v0.0.1433

Release 0.0.1433 ami-0b96583fa98bbaf35

005d2b4 Dedicated specs for HLR docs, part 2 (#12707)

Finishes extracting dedicated rswag spec files for the Higher Level
Reviews API v0 from the HLR specs for the Decision Reviews API v2.

2397055 Dedicated specs for SC docs, part 2 (#12709)

Finishes extracting dedicated rswag spec files for the Supplemental
Claims API v0 from the SC specs for the Decision Reviews API v2.

19843c9 Moved frequent sidekiq scheduled jobs to periodic jobs (#12720)

cb97673 Remove RRD contention-specific flags and job selector (#12708)

• Remove RRD contention-specific flags and job selector

• Fix some tests

• Remove mailer spec

---

Co-authored-by: Ryan McNeil ryan.mcneil288@gmail.com

82a5a50 claim wording fix (#12722)

bcf7e48 API-26385: Updated "Empty payload" Error Handling for BI Upload Submissions (#12700)

• API-26385: Raise error during upload parsing if tempfile is found to be empty, likely server resource issue

• API-26385: Move empty payload check to occur prior to MultipartParser

• API-26385: Small wording change

• API-26385: Add missing 'self' to method

• API-26385: Fix specs

• API-26385: Small wording change

• API-26385: Fix specs

e808159 Mobile: Add v1 message thread endpoint using new api (#12633)

• Add v1 message thread endpoint using new api

• Remove pointless override

• Copy over vcr, remove module from controller, add more thorough tests

• Remove redundant test

• Reset cassettes after tests

• Change name of test

• Debug failures

• Relocate cassette and uncomment test

---

Co-authored-by: Andrew Herzberg andrew.herzberg@adhocteam.us

a9a4bfc 56139 convert datetime from UTC to local on appointment responses (#12632)

• utc to local time conversion on appointment responses

---

Co-authored-by: Tonksthebear jasonconig@me.com

aa2efcb Remove VAOS Type of Care, Stop Code Logging (#12697)

• refactor(vaos): remove type of care - stop code logging and unused methods find_provider_name and find_practice_name from appointments_controller and its spec file

1ee3439 Mobile: Secure messaging thread quick fix (#12727)

• Add v1 message thread endpoint using new api

• Remove pointless override

• Copy over vcr, remove module from controller, add more thorough tests

• Remove redundant test

• Reset cassettes after tests

• Change name of test

• Debug failures

• Relocate cassette and uncomment test

• Add back .to_i for params[:id]

---

Co-authored-by: Andrew Herzberg andrew.herzberg@adhocteam.us

aae6a66 fix 'uninitialized constant BGS::Exceptions' failures in bank_name_spec.rb in the k8s branch (#12726)

bd9e0fa Finalize appeals rswag updates (part 1) (#12729)

• Stops relying on the environment to determine which rswag spec files
  to run. Instead, all docs specs run and all docs are generated each
  time an rswag rake task runs.
• Removes several DocHelpers methods (more removals to come).
• Fixes a few minor mistakes from the process of moving segemented API
  docs specs to their own dedicated files.
• Regenerates the Appealable Issues v0 docs, which was forgotten in an
  earlier PR.

89b22e4 model validation for income limits data import (#12731)

• model validation for income limits data import

• lint

vets-api/v0.0.1432

Release 0.0.1432 ami-0e3cac1ea1976a05a

c2a7045 Bump rack-cors from 2.0.0 to 2.0.1

Bumps rack-cors from 2.0.0 to 2.0.1.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: rack-cors
  dependency-type: direct:production
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] support@github.com

f78a797 Add Agile 6 team members to flipper admin list (#12671)

• Add Agile 6 team members to flipper admin list

• Update email address

f786f23 Bump rubocop from 1.44.1 to 1.45.1 (#11759)

• Bump rubocop from 1.44.1 to 1.45.1

Bumps rubocop from 1.44.1 to 1.45.1.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
  ...

Signed-off-by: dependabot[bot] support@github.com

• enable rubocop

---

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rebecca Tolmach 10993987+rmtolmach@users.noreply.github.com

692fb5d update source to avoid confusion (#12678)

7752045 VACMS-11482 Add feature flipper for Drupal footer (#12672)

d7cad1d Bump database_cleaner from 2.0.1 to 2.0.2 (#12254)

Bumps database_cleaner from 2.0.1 to 2.0.2.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: database_cleaner
  dependency-type: direct:development
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil288@gmail.com
Co-authored-by: Eric Boehs eric@boehs.com

ee5aa49 Api 26185 526 v2 526 schema doc updates 2 (#12610)

• Displaying correctly in swagger, request and example files updated to match changes

• Nests the properties correctly, each update made, all tests are green

• Development:

• Cleans up reverted descriptions

• Updates schema and example to be nested inside data and attributes object.

• Cleans up missed changes in request.json file

Pausing on work until I understand a little better what the path to the finish line is.

Changes to be committed:
modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/config/schemas/v2/526.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
modified: modules/claims_api/spec/support/swagger_shared_components/v2.rb

• Replaces 526.json display with request.json file, fixes missed required fields removal in homeless section

• Displays the request.json file in place of 526.json file

  • does update v2.rb in order to make this change

• Nests form attributes inside "data" and "attributes"

• Fixes missed needed removals of required fileds inside "homeless"

• Updates the request.json file to match 526.json in it display

  • this required description updates and a few regex updates in the file
    Changes to be committed:
    modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
    modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
    modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
    modified: modules/claims_api/spec/support/swagger_shared_components/v2.rb

a5c41cd Removes "require_dependency" from test_user_dashboard module (#12582)

Co-authored-by: Gia Antoniades giaantoniades@Gias-MacBook-Pro.local

834da28 API-526-v2-change-address-pdf-gen (#12606)

• Adds pdf gen mapping for 526 v2 section 2

• Refactors mapper

• Merge & rubocop

• Fixes merge conflict, and a spelling error.

6ee33e6 API-26269-sec-3-pdf-map (#12628)

• Adds mappings for homelessness

• Rubocop

• Update disability_compensation_pdf_mapper.rb

• Fixes the mapper to not allow both a status of homeless and at risk of being homeless

af4303f Add verified email (#12670)

4c81ba0 Add sidekiq job to clear stale InProgressRemindersSent (#12651)

• Add sidekiq job to clear stale InProgressRemindersSent

• Add Flipper toggle to clear stale in progress reminders sent

2b1f9a7 Forms api form mapping fixups (#12687)

• remove field no longer in payload

• fix st 2 and phone mappers

c7a48fb update script per latest metadata changes (#12680)

2fec23d EVSS Migration: Form 21-526EZ Submit Workflow: retrieve ICN for rated disabilities call (#12647)

• retrieve ICN from account settings, to use in LH calls

• rubocop fixes

• fix failing test

• rubocop fix

• remove whitespace

d4b2b9b 4745 Add Lighthouse upstream service to Mobile claims (#12547)

f97dbdd Replace user.session.uuid with token (#12568)

• Replace user.session.uuid with token

• Replaced session_object with session_token

• Replace token with session_uuid. Plus replace @session_token for @session_object.token

• removed test_authentication and added Session.find(token).ttl_in_time.iso8601(0)

f5be147 VaNotify - Remove feature flag that is no longer needed (#12682)

e410c6c Add scopes for letters generator (#12686)

• Add scopes for letters generator

• Fix rubocop

6c0a2e2 [58093, 57942] Use vet360 ID for mcp notification email (#12683)

• expose a method for the VA profile service to return person information via a vet360 ID

• create a worker that takes a vet360 id as an input, sources an email from this data and emails the sourced address

• linting fix

301abce Adds validation to the schema and tests for that validation. (#12654)

83d7e85 Dedicated specs for HLR docs (#12685)

Extracts docs specs for the Higher-Level Reviews API v0 to their own
file. To stay under PR line limits, this change does not yet use the
specs to generate docs (although they run under regular rspec runs).

7885f64 Dedicated specs for SC docs (#12684)

Extracts docs specs for the Supplemental Claims API v0 to their own
file. To stay under PR line limits, this change does not yet use the
specs to generate docs (although they run under regular rspec runs).

4c49504 Finish renaming Contestable Issues v0 to Appealable Issues (#12691)

• Finish renaming contestable issues

Defines a new, separate schema for responses in the Appealable Issues
API v0, which was previously called Contestable Issues. This replaces
the use of "contestable issue" in the schema and in responses from
caseflow as returned by the API. The rake task for generating oauth
tokens for this API has also been renamed.

• Update appeals insomnia configs

'Contestable Issues' has been renamed to 'Appealable Issues'

ce8da53 API-26270-526-v2-exp-info-pdf-map (#12640)

• Adds mapping for toxic exposure

• rubocop

• Resloves merge conflicts & rubocop

• Adds back delted test, and removes test for at risk of being homeless attribute

• Adds swagger changes

790abed Update settings.yml (#12699)

Adding my VA email address to admin_user_emails

e2fe559 Bump lockbox from 1.1.2 to 1.2.0 (#12313)

Bumps lockbox from 1.1.2 to 1.2.0.

• Release notes
• Changelog
• Commits

---

updated-dependencies:

• dependency-name: lockbox
  dependency-type: direct:production
  update-type: version-update:semver-minor
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan McNeil ryan.mcneil288@gmail.com

1dcdacd Dedicated specs for NOD docs (#12669)

Extracts docs specs for the Notice of Disagreements API v0 to their own
file. To stay under PR line limits, this change does not yet use the
specs to generate docs (although they run under regular rspec runs).

6bded42 Api 24829 section 3 validation (#12658)

• Incremental commit

• Misc fixes, add rspec tests

• Misc fixes and final cleanup

• Add swagger

• Remove extraneous context blocks

• Rubocop whitespace fix

• Clean up return value handling

• Rubocop spacing fix

• Update test data and fix test

2eb03da [API-26991] Spawn child FormBuilder jobs (#12661)

• [API-26991] Ensure all forms spawn child jobs

dbaac91 Bump addressable from 2.8.1 to 2.8.4 (#12692)

Bumps addressable from 2.8.1 to 2.8.4.

• Changelog
• Commits

---

updated-dependencies:

• dependency-name: addressable
  dependency-type: direct:production
  update-type: version-update:semver-patch
  ...

Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored...

vets-api/v0.0.1431

Release 0.0.1431 ami-09d884c580652d511

041abc8 Swap title and detail in returns (#12637)

30f30f2 Deep freeze 1010 schemas (#12363)

• freeze 1010 schemas

• add frozen schema specs

• lint

• lint

23b6f06 add repository setting 'allow_squash_merge: true' (#12656)

7434461 delete github/settings.yml for now (#12659)

168123b API-26190-526-v2-sec-1-vet-identification-pdf-gen (#12600)

• Adds section 1 to v2 526 mapper

• Refactors mapper

5b2c832 API-25891 Fixes for appeals API rswag docs (#12642)

fd0b4f4 Removes 'require_dependency' From 'veteran_verification' Module (#12592)

• Removes unnecessary 'require_dependency' from veteran_verification module

• Replaces one instance of 'require_dependency' with 'require'

• Replaces some 'require_dependency' instances with 'require'

• Replaces 'require_dependency' with 'require'

---

Co-authored-by: Gia Antoniades giaantoniades@Gias-MacBook-Pro.local

d764952 Removes unnecessary 'require_dependency' from covid_research module (#12587)

Co-authored-by: Gia Antoniades giaantoniades@Gias-MacBook-Pro.local

27b818c Removes 'require_dependency' From 'claims_api' Module (#12593)

• Removes unnecessary 'require_dependency' from claims_api module

• Substitutes 'require_dependency' with 'require'

---

Co-authored-by: Gia Antoniades giaantoniades@Gias-MacBook-Pro.local

3987bdc Removes 'require_dependency' From 'vba_documents' Module (#12644)

• Removes unnecessary 'require_dependency' statements from vba_documents module

• Updates 'require_dependency' with 'require'

• Replaces 'require_depdendency' with 'require'

• Replaces 'require_depdendency' with 'require'

• Resolves rubocop error

---

Co-authored-by: Gia Antoniades giaantoniades@Gias-MacBook-Pro.local

6462ba9 MHV-42067: Clinical notes api complete (#12650)

Co-authored-by: wright0776 matwright2010@gmail.com

259f510 fixup times in forms (#12667)

3a4dacb Add redis_namespace to log (#12666)

• add redis_namespace to log

• line length

b852e6e [12645] Adding schema changes for Client Config to allow for possible private_key_jwt authentication (#12646)

• [12645] Adding schema changes for Client Config to allow for possible private_key_jwt authentication

• Update db/migrate/20230512221434_add_certificates_client_configs.rb

Co-authored-by: Riley Anderson riley.anderson@oddball.io

---

Co-authored-by: Trevor Bosaw trevor.bosaw@oddball.io
Co-authored-by: Riley Anderson riley.anderson@oddball.io

9d6979c Adds new feature flag to gate enhancements for June release (#12653)

58e36b6 Updated Lighthouse Letters Generator Service exception handling (#12649)

• Updated Lighthouse Letters Generator Service exception handling

6c27e48 Adding transform for smoother FE integration (#12543)

• Adding transform for smoother FE integration

• Fix test

• Fix Rubocop

• Add tests for transformation

• fix rubocop

f777863 Letters Generator controller for Lighthouse Migration (#12446)

• letters generator controller and service tweaks

• removed stray var that wasn't being used

• cleaned up Letters Generator Controller tests

• letters generator controller spec updates

• updated letters generator controller spec to use vcr

• updated lighthouse letters generator controller tests to use vcr

• added Raven tag for Sentry

• undid changes to service controller that weren't supposed to be added to this branch

• fixed a small spacing issue in letters generator controller

• another small linting fix in letters generator controller

• removed unused test data file for letters generator controller

• fixed frozen string literal magic comment that had small syntax issue

• updated letters generator service to check for 'true' as a string rather than a true boolean for letter download options

• updated letters generator controller to cast url 'true' strings to booleans before passing it along to the service

• reverted service to check for booleans rather than strings in download_letter method

• added pundit authorization to lighthouse letters generator controller

• removed rescues from controller

• updated error test

• minor rubocop fix

5177eb3 Adds feature toggle (#12660)

Signed-off-by: Ryan Shaw ryan.shaw@adhocteam.us

5c1b472 Api 262190 claim details validate ptcpnt clmant (#12636)

• Updates controller, spec test to handle scenario

• Adds comment on conditional

• Fixes for Rubocop linting

• Fixing my Gemfile inclusion

08d3cb2 vfep-512 - use latest json-schema (#12665)

• latest json-schema

• fix specs

• fix spool files and remove duplicate test

---

Co-authored-by: nfstern02 Noah.Stern@va.gov

ea16378 Add necessary requires for FSR code (#12556)

666e23b Api 25831 faraday healthchecks (#12557)

• In progress

• Updates to call specific localBGS methods

• Updates to spec test for new Faraday checks

• Rubocop fixes

• Disable line length for Rubocop

• Add specific identifiers to avoid exceptions

• Add settings for environment-specific params, update FaradayBGSCheck to use

• Fix typo in settings name

• Refactor to add healthcheck for service wsdl, update tests to use

• Update rspec for updated healthcheck

• Rubocop fixes

• Line length

• Revert changes to settings.yml

vets-api/v0.0.1430

Release 0.0.1430 ami-0728e15765109233a

f1754f6 API-26111 Rename Contestable Issues v0 (#12618)

Updates constants and most docs for the Contestable Issues v0 API to
rename it to "Appealable Issues v0". Schemas still need to be renamed.

dd358df Unique docs spec file for Legacy Appeals API v0 (#12576)

68d3cf1 Forms api 21-10210 add lay witness mappings (#12617)

• generate model and mappings

• fixup mappings and add tests, stamps

• lint

• fixup mappings

• fixup model to match new pattern

39d477b Branch Protection Settings (#12631)

• Add branch protection GHA

• Syntax update

• Resolve push requires map value

• Resolve node version conflict

• Fix syntax error

• Rerun workflow

• Set node version to 16

• Update github token env

• settings.yml branch protections

• Clean up branch protections

vets-api/v0.0.1429

Release 0.0.1429 ami-03df5cb3204e95267

9e5ea08 Removing hard coded logout values -- ticket 56883 (#12482)

• Removing hard coded logout values -- ticket 56883

• Enabling spec for when the client_id_value is nil -ticket 56883

9c0b7a7 add feature toggle for quick submit (#12621)

f7d2740 add logging around redis response and key (#12624)

7710259 add emails, update note (#12626)

31173d5 Revert "add logging around redis response and key (#12624)" (#12629)

This reverts commit f7d2740.

33526b9 Removes unnecessary 'require_dependency' from spec directory (#12594)

Co-authored-by: Gia Antoniades giaantoniades@Gias-MacBook-Pro.local

8cce6cc Logging around the session response for 500 Internal Server Errors (#12630)

• logging around the session reponse

• lint

2b5589c 44949 port fsr to debts api module (#12560)

Squash and Merge large commit due to most of it being copied from another module (linked in PR).

• port FSR controller and routes to debts_api module

• ported financial_status_reports_controller_spec to debts_api module, specs green. financial_status_report_service ported over but not dependencies.

• port form5655_submission model, workers, specs and related helper and configuration files

• adjust new debts_api files to fall in line with linter

• remove commented out require statement

Co-authored-by: Scott James Scott.James1@va.gov

• remove commented code from debt-api application_controller

---

Co-authored-by: Scott James Scott.James1@va.gov

f1525b3 Forms Api submit to benefits intake (#12591)

• change forms to submit to benefits intake api

• make lighthouse vcr cassettes generic

• cleanup imports and methods

• remove unused logic

• update docs

• change setting to true

• don't need these settings

• add tests for lib files

• lint