microsoft sso login supported #4848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dash#4231) * don't need to depend on context when templating failure reports * extract a render_template function with some docs * CodeClimate has really outdone itself this time. Removed a whitespace character in order to fix 2 CodeClimate errors * apparently whitespace doesn't count as a character
* add rq and an rq_worker service * add rq_scheduler and an rq_scheduler service * move beat schedule to periodic_jobs queue * move version checks to RQ * move query result cleanup to RQ * use timedelta and DRY up a bit * move custom tasks to RQ * do actual schema refreshes in rq * rename 'period_jobs' to 'periodic', as it obviously holds jobs * move send_email to rq * DRY up enqueues * ditch and use a partially applied decorator * move subscribe to rq * move check_alerts_for_query to rq * move record_event to rq * make tests play nicely with rq * 👋 beat * rename rq_scheduler to plain scheduler, now that there's no Celery scheduler entrypoint * add some color to rq-worker's output * add logging context to rq jobs (while keeping execute_query context via get_task_logger for now) * move schedule to its own module * cancel previously scheduled periodic jobs. not sure this is a good idea. * rename redash.scheduler to redash.schedule * allow custom dynamic jobs to be added decleratively * add basic monitoring to rq queues * add worker monitoring * pleasing the CodeClimate overlords * adjust cypress docker-compose.yml to include rq changes * DRY up Cypress docker-compose * add rq dependencies to cypress docker-compose service * an odd attempt at watching docker-compose logs when running with Cypress * Revert "an odd attempt at watching docker-compose logs when running with Cypress" This reverts commit 016bd1a. * show docker-compose logs at Cypress shutdown * Revert "DRY up Cypress docker-compose" This reverts commit 43abac7. * minimal version for binding is 3.2 * remove unneccesary code reloads on cypress * add a command which errors if any of the workers running inside the current machine haven't been active in the last minute * SCHEMAS_REFRESH_QUEUE is no longer a required setting * split tasks/queries.py to execution.py and maintenance.py * fix tests after query execution split * pleasing the CodeClimate overlords * rename worker to celery_worker and rq_worker to worker * use /rq_status instead of /jobs * show started jobs' time ago according to UTC * replace all spaces in column names * fix query tests after execution split * exit with an int * general lint * add an entrypoint for rq_healthcheck * fix indentation * delete all existing periodic jobs before scheduling them * remove some unrequired requires * move schedule example to redash.schedule * add RQ integration to Sentry's setup * pleasing the CodeClimate overlords * remove replication settings from docker-compose - a proper way to scale using docker-compose would be the --scale CLI option, which will be described in the knowledge based * revert to calling a function in dynamic settings to allow periodic jobs to be scheduled after app has been loaded * don't need to depend on context when templating failure reports * set the timeout_ttl to double the interval to avoid job results from expiring and having periodic jobs not reschedule * whoops, bad merge * describe custom jobs and don't actually schedule them * fix merge
…sh#4250) * Fix: Alert page breaks when target query returns null result * Better handling of topValue value
…4256) * track general RQ queues (default, periodic and schemas) * get all active RQ queues * call get_celery_queues in another place
…o continue running periodically even after longer executions (getredash#4283)
* Make core app compatible with Python 3 No backward compatibility with Python 2.7 is kept. This commit mostly contains changes made with 2to3 and manual tweaking when necessary. * Use Python 3.7 as base docker image Since it is not possible to change redash/base:debian to Python 3 without breaking future relases, its Dockerfile is temporarly copied here. * Upgrade some requirements to newest versions Some of the older versions were not compatible with Python 3. * Migrate tests to Python 3 * Build frontend on Python 3 * Make the HMAC sign function compatible with Python 3 In Python 3, HMAC only works with bytes so the strings and the float used in the sign function need to be encoded. Hopefully this is still backward compatible with already generated signatures. * Use assertCountEqual instead of assertItemsEqual The latter is not available in Python 3. See https://bugs.python.org/issue17866 * Remove redundant encoding header for Python 3 modules * Remove redundant string encoding in CLI * Rename list() functions in CLI These functions shadow the builtin list function which is problematic since 2to3 adds a fair amount of calls to the builtin list when it finds dict.keys() and dict.values(). Only the Python function is renamed, from the perspective of the CLI nothing changes. * Replace usage of Exception.message in CLI `message` is not available anymore, instead use the string representation of the exception. * Adapt test handlers to Python 3 * Fix test that relied on dict ordering * Make sure test results are always uploaded (getredash#4215) * Support encoding memoryview to JSON psycopg2 returns `buffer` objects in Python 2.7 and `memoryview` in Python 3. See getredash#3156 * Fix test relying on object address ordering * Decode bytes returned from Redis * Stop using e.message for most exceptions Exception.message is not available in Python 3 anymore, except for some exceptions defined by third-party libraries. * Fix writing XLSX files in Python 3 The buffer for the file should be made of bytes and the actual content written to it strings. Note: I do not know why the diff is so large as it's only a two lines change. Probably a white space or file encoding issue. * Fix test by comparing strings to strings * Fix another exception message unavailable in Python 3 * Fix export to CSV in Python 3 The UnicodeWriter is not used anymore. In Python 3, the interface provided by the CSV module only deals with strings, in and out. The encoding of the output is left to the user, in our case it is given to Flask via `make_response`. * (Python 3) Use Redis' decode_responses=True option (getredash#4232) * Fix test_outdated_queries_works_scheduled_queries_tracker (use utcnow) * Make sure Redis connection uses decoded_responses option * Remove unused imports. * Use Redis' decode_responses option * Remove cases of explicit Redis decoding * Rename helper function and make sure it doesn't apply twice. * Don't add decode_responses to Celery Redis connection URL * Fix displaying error while connecting to SQLite The exception message is always a string in Python 3, so no need to try to decode things. * Fix another missing exception message * Handle JSON encoding for datasources returning bytes SimpleJSON assumes the bytes it receives contain text data, so it tries to UTF-8 encode them. It is sometimes not true, for instance the SQLite datasource returns bytes for BLOB types, which typically do not contain text but truly binary data. This commit disables SimpleJSON auto encoding of bytes to str and instead uses the same method as for memoryviews: generating a hex representation of the data. * Fix Python 3 compatibility with RQ * Revert some changes 2to3 tends to do (getredash#4261) - Revert some changes 2to3 tends to do when it errs on the side of caution regarding dict view objects. - Also fixed some naming issues with one character variables in list comprehensions. - Fix Flask warning. * Upgrade dependencies * Remove useless `iter` added by 2to3 * Fix get_next_path tests (getredash#4280) * Removed setting SERVER_NAME in tests setup to avoid a warning. * Change get_next_path to not return empty string in case of a domain only value. * Fix redirect tests: Since version 0.15 of Werkzeug it uses full path for fixing the location header instead of the root path. * Remove explicit dependency for Werkzeug * Switched pytz and certifi to unbinded versions. * Switch to new library for getting country from IP `python-geoip-geolite2` is not compatible with Python 3, instead use `maxminddb-geolite2` which is very similar as it includes the geolite2 database in the package . * Python 3 RQ modifications (getredash#4281) * show current worker job (alongside with minor cosmetic column tweaks) * avoid loading entire job data for queued jobs * track general RQ queues (default, periodic and schemas) * get all active RQ queues * call get_celery_queues in another place * merge dicts the Python 3 way * extend the result_ttl of refresh_queries to 600 seconds to allow it to continue running periodically even after longer executions * Remove legacy Python flake8 tests
* Start draft for new Parameter structure * Add the rest of the methods * EnumParameter * QueryBasedDropdownParameter * DateParameter * DateRangeParameter * Update Parameter usage on code * Merge dynamicValue into normalizedValue * Add updateLocals and omit unwanted props * Allow null NumberParameter and omit parentQueryId * Rename parameter getValue to getExecutionValue * Update $$value to normalizedValue + omit on save * Add a few comments * Remove ngModel property from Parameter * Use value directly in DateRangeParameter * Use simpler separator for DateRange url param * Add backward compatibility * Use normalizeValue null value for isEmpty * Start creating jest tests * Add more tests * Normalize null value for multi mode in Enum * Use saved value for param isEmpty
* Migrate table editor to React: skeleton, Grid tab * Columns tab * Cleanup * Columns tab: DnD column sorting * Columns types should be JSX * New Columns tab UI/X * Use Sortable component on Columns tab * Tests: Grid Settings * Tests: Columns Settings * Tests: Editors for Text, Number, Boolean and Date/Time columns * Tests: Editors for Image and Link columns * Minor UI fix * Trigger build * Debounce inputs
* CircleCI workflow improvements - Don't automatically build the Docker image. - Make the Python lint step requirement for the follow up steps. When it fails it usually means there is a code error which will prevent the next steps anyway. * Fix YAML syntax error. * Add separate build Docker image step for master branch
Co-Authored-By: Arik Fraimovich <arik@arikfr.com>
* New feature - Alert muting * pep8 fix * Fixed backend api update * whoops semicolon * Implemented mute
* Add last 14, 30, 60, and 90 days to DRP.js Date Range Parameter (DRP) * Add last 14, 30, 60, and 60 day params to DRP.jsx DateRangeParameters (DRP)
…addresses optional (getredash#4790) * feature: add ability to make the restriction of api calls to private addresses optional * chore: fix typo * Update redash/settings/__init__.py Co-authored-by: lprice92 <lprice92@iastate.edu> Co-authored-by: Arik Fraimovich <arik@arikfr.com>
Co-authored-by: Weng Kham Kan <wengkham.kan@icarasia.com>
* add pyexasol datasource, ensure that integer dont overflow in javascript * support setting encryption for Exasol connections Co-authored-by: Arik Fraimovich <arik@arikfr.com>
* Disable Percy snapshot for Choropleth test * Increase wait. * Diasble Percy snapshot. * Reduce wait time to original value. * Restyled by prettier (getredash#4800) Co-authored-by: Restyled.io <commits@restyled.io> * Update choropleth_spec.js Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Fix comparison error when scale is None Prevents `'>' not supported between instances of 'NoneType' and 'int'` error when scale is `None` * Update oracle.py * Fix scale logic. Co-authored-by: Arik Fraimovich <arik@arikfr.com>
…dash#4773) Let the notifications go into browser/OS notification trays so users can click on them from there if they miss the initial notification. Modern browsers generally use OS notifications so the user is in control of the notification at the OS level.
* Move Dashboard off `subqueryload()` loader in all() method due to inconsistent results bug in SQLAlchemy when leveraging distinct within a subqueryload call through paginate. * Added source reference to Presto Query Runner connection through the pyhive client to announce to presto that the query is coming from `redash` instead of `pyhive`. * Removing source line from presto query runner to refactor based on feedback.
… passwrod link for the first time (getredash#4817)
…4816) * Reduce number of queries used to load the dashboards list. * Use DashboardSerializer everywhere. * Call serialize
* ODBC Based Databricks connector. * Install Databricks' ODBC driver in Docker image * Add useragent string. * Add Types enum to redash.query_runner to replace the seprate constants. * Databricks connector: 1. Parse types. 2. Send additional connection options. 3. Correctly parse errors. * Switch to TYPE constants to use code with Python 2. * Add note about the Databricks driver terms and conditions. * Show message about Databricks driver terms and conditions. * Handle cases when the query doesn't return any results. * Update redash/query_runner/databricks.py Co-Authored-By: Jesse <jesse@whitehouse.dev> * Use new Databricks logo * Fix connection string options Co-authored-by: Jesse <jesse@whitehouse.dev>
* Add column description to table viz * Fix: misplaced super long titles tooltip.
Signed-off-by: koooge <koooooge@gmail.com>
…tredash#4822) This was dropped in aa17681.
* Specify restylers versions for restyled * Trigger file change for testing * Revert "Trigger file change for testing" This reverts commit d203e37.
yangyinchun
force-pushed
the
support-microsoft-login
branch
from
348f84a to
7e70140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
support Office365 login of Microsoft
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)