Disable the slider for numeric values on the tree view. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godotengine
pushed a commit
that referenced
this pull request
Feb 13, 2014
Disable the slider for numeric values on the tree view.
Closed
hungrymonkey
referenced
this pull request
in hungrymonkey/godot
Sep 30, 2017
String operator_plus fix
lawnjelly
added a commit
to lawnjelly/godot
that referenced
this pull request
Mar 31, 2023
…ction Fix Linux release action
YeldhamDev
pushed a commit
to YeldhamDev/godot
that referenced
this pull request
Jul 21, 2023
…dates Fix a few small typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've talked to Juan about this, and he seems to be in relative agreement that the slider on the treeview's numeric values isn't exactly an optimal solution. There are multiple things wrong with it, namely that there is no intelligent handling of limits that are essentially limitless (that is, -65536 to 65535), and it doesn't go away when you're done editing a field, which leads to accidental clicks that cause chaos. Example: I change the screen width of my project, and then for some reason try to use the mouse to go to the field below. Oops, the width of my project is now -12445.
I'm not a C++ programmer, I'm more comfortable in C#. And I don't know the codebase well enough to create proper fixes, but I don't feel the slider contributes anything of value to this particular gui element, so for now, I've just gotten rid of it.