docs: add legacy snippets convention to GEMINI.md by NTaylorMullen · Pull Request #18597 · google-gemini/gemini-cli

NTaylorMullen · 2026-02-09T05:53:25Z

Summary

Add a development convention to GEMINI.md regarding packages/core/src/prompts/snippets.legacy.ts.

Details

This update clarifies that snippets.legacy.ts is a snapshot of an older system prompt and its prompting verbiage should be preserved to maintain historical behavior. Structural changes for compilation or simplicity are still allowed.

Related Issues

N/A

How to Validate

Verify the content of GEMINI.md.

Pre-Merge Checklist

Updated relevant documentation and README (if needed)
Added/updated tests (if needed)
Noted breaking changes (if any)
Validated on required platforms/methods:
- MacOS
  - npm run

gemini-code-assist · 2026-02-09T05:53:37Z

Summary of Changes

Hello @NTaylorMullen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new development guideline within GEMINI.md to clarify how to handle changes to the snippets.legacy.ts file. The primary goal is to ensure the historical integrity of an older system prompt's verbiage, while still allowing for necessary structural improvements or compilation fixes. This update helps maintain consistency and understanding for developers working with this specific legacy component.

Highlights

New Development Convention: A new development convention has been added to GEMINI.md specifically for packages/core/src/prompts/snippets.legacy.ts.
Preservation of Legacy Snippets: The convention states that the prompting verbiage in snippets.legacy.ts should be preserved to maintain its historical behavior as a snapshot of an older system prompt.
Allowed Structural Changes: While the verbiage must be preserved, structural changes to snippets.legacy.ts are permitted if they are for compilation purposes or to simplify the code.

Changelog

GEMINI.md
- Added a new section under 'Development Conventions' titled 'Legacy Snippets'.
- Detailed guidelines for modifying packages/core/src/prompts/snippets.legacy.ts, emphasizing preservation of prompting verbiage and allowing structural changes.

Activity

The author has updated relevant documentation and validated the changes on MacOS using npm run as per the pre-merge checklist.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new development convention in GEMINI.md for handling the packages/core/src/prompts/snippets.legacy.ts file. The added documentation clearly states that while the prompting verbiage should remain unchanged to preserve historical behavior, structural modifications for compilation or simplification are permissible. The change is well-documented and improves clarity for future developers working with this legacy component. The implementation is correct and I have no suggestions for improvement.

github-actions · 2026-02-09T05:57:06Z

Size Change: -2 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	23.8 MB	-2 B (0%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

- Document that packages/core/src/prompts/snippets.legacy.ts is a snapshot and prompting verbiage should be preserved.

- Shard 'Slow Test - Win' job in CI to reduce load and timeouts. - Add global 'afterEach' hook to clear 'coreEvents' listeners in 'packages/cli' and 'packages/core' to prevent memory leaks and 'MaxListenersExceededWarning'. - Use 'os.tmpdir()' in 'extension-manager-themes.spec.ts' to fix 'EPERM' error on macOS. Part of #18597

…p and fixing actual leaks - Revert coreEvents.removeAllListeners() in test-setup.ts as it breaks tests sharing the singleton state. - Increase coreEvents max listeners to 100 in test-setup.ts to suppress warnings in large test suites. - Fix process listener leaks in terminalCapabilityManager.ts, gemini.tsx, and sandbox.ts by ensuring they are only added once. Part of #18597

…hread counts - Increase testTimeout to 60s in packages/cli and packages/core. - Reduce min/max threads to 1/4 to prevent resource contention on CI runners. - These changes supplement the listener leak fixes to resolve intermittent CI hangs. Part of #18597

- Switch to pool: 'forks' in both packages/cli and packages/core. - This prevents cross-test state pollution and intermittent silent hangs on resource-constrained CI runners. - Maintain increased timeouts (60s) for further stability. Part of #18597