Code review cleanup for thinking display

[jacob314]

Summary

Code review feedback for thinking bubble display written as a PR.
Fixes #18718

• Thinking Display Logic Refactor: Refactored the ThinkingMessage component to leverage Ink's built-in layout and border capabilities, removing manual text wrapping and terminalWidth prop. The logic for determining inlineThinkingMode was centralized within HistoryItemDisplay by directly accessing settings, eliminating the need to pass it as a prop through multiple components.
• Emoji Handling Simplification: Removed the shouldUseEmoji utility function and its associated logic and tests. The system now consistently uses emoji for indicators, simplifying the codebase by removing conditional rendering based on terminal emoji support.
• Test Suite Modernization: Updated HistoryItemDisplay and ThinkingMessage tests to utilize snapshot testing and createMockSettings for better maintainability and clarity, reflecting the changes in component props and internal logic.

[gemini-cli]

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

[gemini-code-assist]

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the rendering of 'thinking' messages and other UI elements by centralizing configuration logic and simplifying emoji handling. It transitions the ThinkingMessage component to a more robust Ink-based layout system, reducing complexity and improving maintainability across several UI components. The changes aim to make the display more consistent and efficient.

Highlights

• Thinking Display Logic Refactor: Refactored the ThinkingMessage component to leverage Ink's built-in layout and border capabilities, removing manual text wrapping and terminalWidth prop. The logic for determining inlineThinkingMode was centralized within HistoryItemDisplay by directly accessing settings, eliminating the need to pass it as a prop through multiple components.
• Emoji Handling Simplification: Removed the shouldUseEmoji utility function and its associated logic and tests. The system now consistently uses emoji for indicators, simplifying the codebase by removing conditional rendering based on terminal emoji support.
• Test Suite Modernization: Updated HistoryItemDisplay and ThinkingMessage tests to utilize snapshot testing and createMockSettings for better maintainability and clarity, reflecting the changes in component props and internal logic.

Changelog

• packages/cli/src/test-utils/render.tsx
  • Removed shouldUseEmoji mock from test utilities.
• packages/cli/src/ui/components/AlternateBufferQuittingDisplay.tsx
  • Removed useSettings and getInlineThinkingMode imports.
  • Removed inlineThinkingMode prop from HistoryItemDisplay.
• packages/cli/src/ui/components/HistoryItemDisplay.test.tsx
  • Imported createMockSettings.
  • Updated renderWithProviders calls to pass settings via context.
  • Migrated thinking items tests to use snapshot assertions.
• packages/cli/src/ui/components/HistoryItemDisplay.tsx
  • Imported getInlineThinkingMode and useSettings.
  • Removed inlineThinkingMode from HistoryItemDisplayProps.
  • Fetched inlineThinkingMode internally using useSettings.
  • Removed terminalWidth prop from ThinkingMessage component usage.
• packages/cli/src/ui/components/LoadingIndicator.test.tsx
  • Removed terminalUtils import and shouldUseEmojiMock.
  • Removed test case for ASCII fallback thought indicator.
• packages/cli/src/ui/components/LoadingIndicator.tsx
  • Removed shouldUseEmoji import.
  • Hardcoded emoji for the thinking indicator, removing conditional rendering.
• packages/cli/src/ui/components/MainContent.tsx
  • Removed useSettings and getInlineThinkingMode imports.
  • Removed inlineThinkingMode prop from MemoizedHistoryItemDisplay.
• packages/cli/src/ui/components/QuittingDisplay.tsx
  • Removed useSettings and getInlineThinkingMode imports.
  • Removed inlineThinkingMode prop from HistoryItemDisplay.
• packages/cli/src/ui/components/snapshots/HistoryItemDisplay.test.tsx.snap
  • Added new snapshot for HistoryItemDisplay thinking item rendering.
• packages/cli/src/ui/components/messages/ThinkingMessage.test.tsx
  • Removed terminalWidth prop from ThinkingMessage component calls.
  • Updated all test cases to use snapshot assertions for output verification.
• packages/cli/src/ui/components/messages/ThinkingMessage.tsx
  • Removed terminalWidth prop from ThinkingMessageProps.
  • Refactored ThinkingMessage to use Ink's Box component for layout and borders.
  • Moved normalizeEscapedNewlines to textUtils.ts.
  • Removed internal text wrapping and grapheme utility functions.
• packages/cli/src/ui/components/messages/ToolGroupMessage.tsx
  • Adjusted height property of a Box component to 0.
• packages/cli/src/ui/components/messages/snapshots/ThinkingMessage.test.tsx.snap
  • Added new snapshot file for ThinkingMessage component tests.
• packages/cli/src/ui/utils/terminalUtils.test.ts
  • Removed terminalUtils.test.ts file.
• packages/cli/src/ui/utils/terminalUtils.ts
  • Removed shouldUseEmoji function.
• packages/cli/src/ui/utils/textUtils.ts
  • Added normalizeEscapedNewlines utility function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: -3.45 kB (-0.01%)

Total Size: 23.9 MB

Filename	Size	Change
./bundle/gemini.js	23.9 MB	-3.45 kB (-0.01%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request significantly improves the thinking display logic by refactoring to use SettingsContext for inlineThinkingMode, simplifying the ThinkingMessage component, and streamlining the codebase by removing shouldUseEmoji. Regarding security, no vulnerabilities were identified; however, the security review agent was unable to read any of the files in the pull request, which limited the scope of the security analysis.