test(cli): fix AppContainer act() warnings and improve waitFor resilience

[NTaylorMullen]

Summary

Fixes flaky and failing tests in AppContainer.test.tsx by addressing React act() warnings and improving the waitFor utility's resilience when using fake timers.

Details

• Mocked useBanner and useShellInactivityStatus: These hooks were triggering background state updates during rendering, leading to "not wrapped in act()" warnings. Mocking them by default stabilizes the test environment.
• Improved waitFor Utility: Enhanced packages/cli/src/test-utils/async.ts to automatically advance timers using vi.advanceTimersByTimeAsync if vi.isFakeTimers() is true. This ensures that assertions dependent on time (like inactivity status) resolve correctly without manual timer manipulation in every waitFor block.
• CI Resilience: Increased the default waitFor timeout to 2000ms to reduce flakiness in slower environments like Windows CI.
• Test Refactoring: Updated AppContainer.test.tsx to use vi.importActual for terminal title tests that specifically require the real useShellInactivityStatus logic, while keeping the rest of the suite isolated.

Related Issues

N/A (Discovered via CI failure in https://github.com/google-gemini/gemini-cli/actions/runs/21820047149/job/62950816295)

How to Validate

Run the unit tests for the CLI package:

npm test -w @google/gemini-cli -- src/ui/AppContainer.test.tsx

Verify that all 78 tests pass without act() warnings.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @NTaylorMullen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the stability and reliability of the CLI's unit tests, particularly for AppContainer.test.tsx. It addresses persistent "not wrapped in act()" warnings by strategically mocking React hooks and enhances the waitFor utility to seamlessly integrate with fake timers, reducing test flakiness and improving overall test resilience across different environments.

Highlights

• Test Stability: Mocked useBanner and useShellInactivityStatus to prevent "not wrapped in act()" warnings caused by background state updates, ensuring a more stable test environment.
• Improved waitFor Utility: Enhanced the waitFor utility to automatically advance fake timers using vi.advanceTimersByTimeAsync when vi.isFakeTimers() is active, removing the need for manual timer manipulation in tests.
• CI Resilience: Increased the default waitFor timeout from 1000ms to 2000ms to mitigate flakiness in slower CI environments, particularly Windows.
• Targeted Mocking: Refactored AppContainer.test.tsx to use vi.importActual for specific tests that require the real useShellInactivityStatus logic, ensuring accurate testing of terminal title updates while maintaining isolation for other tests.

Changelog

• packages/cli/src/test-utils/async.ts
  • Imported vi from vitest.
  • Increased the default timeout for the waitFor utility from 1000ms to 2000ms.
  • Modified the waitFor utility to conditionally advance timers using vi.advanceTimersByTimeAsync(interval) when vi.isFakeTimers() is active, otherwise falling back to setTimeout(resolve, interval).
• packages/cli/src/ui/AppContainer.test.tsx
  • Added vi.mock implementations for useBanner and useShellInactivityStatus to provide default, stable return values, preventing unwanted side effects during tests.
  • Imported useShellInactivityStatus to allow for proper type mocking.
  • Introduced mockedUseShellInactivityStatus as a mocked variable.
  • Updated the beforeEach block to set a default mock return value for useShellInactivityStatus.
  • In the 'Shell Focus Action Required' test suite, vi.importActual is now used to retrieve the real useShellInactivityStatus implementation, allowing these specific tests to verify actual terminal title updates.

Activity

• The issues addressed by this PR were discovered through CI failures, specifically in a run on GitHub Actions.
• The changes have been validated on MacOS using npm run.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses flakiness and warnings in the AppContainer.test.tsx test suite. The changes are well-thought-out and improve the resilience of the tests. Mocking the useBanner and useShellInactivityStatus hooks by default is a good strategy to prevent unexpected state updates and act() warnings. The enhancement to the waitFor utility to automatically handle fake timers is a significant improvement, making tests that rely on time-based logic cleaner and more reliable. Finally, selectively using the real implementation of useShellInactivityStatus for specific tests that require it is a clean and effective testing pattern. Overall, these changes contribute positively to the stability and maintainability of the test suite.

[github-actions]

Size Change: -2 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.9 MB	-2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}