chore(evals): update validation_fidelity_pre_existing_errors to USUALLY_PASSES

[NTaylorMullen]

Summary

Update the validation_fidelity_pre_existing_errors eval policy from ALWAYS_PASSES to USUALLY_PASSES.

Details

The validation_fidelity_pre_existing_errors test involves non-deterministic agent behavior and complex tool interaction (specifically around handling pre-existing errors during validation). Downgrading the policy to USUALLY_PASSES more accurately reflects its reliability and prevents CI noise while still allowing it to be tracked as a quality metric.

Related Issues

N/A

How to Validate

Run the eval manually (requires RUN_EVALS=true):

npm test -w @google/gemini-cli-integration-tests -- evals/validation_fidelity_pre_existing_errors.eval.ts

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run

[gemini-code-assist]

Summary of Changes

Hello @NTaylorMullen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the passing criteria for a specific evaluation test to more accurately reflect its reliability. By changing the policy from ALWAYS_PASSES to USUALLY_PASSES, the aim is to reduce unnecessary CI failures caused by the test's inherent non-deterministic nature, while still maintaining its role as a quality indicator.

Highlights

• Eval Policy Update: The validation_fidelity_pre_existing_errors eval policy has been updated from ALWAYS_PASSES to USUALLY_PASSES. This change acknowledges the non-deterministic behavior and complex tool interactions of the test.

Changelog

• evals/validation_fidelity_pre_existing_errors.eval.ts
  • Updated the evalTest policy from ALWAYS_PASSES to USUALLY_PASSES to better account for the test's non-deterministic behavior.

Activity

• No specific review comments or activity have been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the validation_fidelity_pre_existing_errors eval policy from ALWAYS_PASSES to USUALLY_PASSES. This is a reasonable change given that the test's outcome can be non-deterministic due to complex agent behavior, which can cause flakiness in CI. The new policy more accurately reflects the test's reliability. The change is correct and well-justified.