Harded code assist converter. by jacob314 · Pull Request #18656 · google-gemini/gemini-cli

jacob314 · 2026-02-09T18:27:53Z

Summary

To Repro, auth with google and verify things work.
We should also rollback on the backend.

gemini-cli · 2026-02-09T18:28:07Z

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

gemini-code-assist · 2026-02-09T18:28:10Z

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the resilience and stability of the code assist converter by making its fromGenerateContentResponse function more robust. It introduces explicit checks for potentially missing or undefined properties within the input response object, such as the main response field and the candidates array. This ensures that the conversion process can proceed without errors, even when dealing with unexpected or incomplete data structures, thereby enhancing the overall reliability of the code assist feature.

Highlights

Robustness Improvement: The fromGenerateContentResponse function has been enhanced to gracefully handle cases where the response property or candidates array might be missing or undefined in the input CaGenerateContentResponse object.
Error Prevention: This change prevents potential runtime errors by ensuring that the candidates property is always initialized as an array, even when the source data is incomplete or malformed.
New Test Coverage: A new unit test has been added to specifically validate the function's ability to handle missing response properties, ensuring the converter's resilience.

Changelog

packages/core/src/code_assist/converter.test.ts
- Added a new test case to verify that fromGenerateContentResponse handles a missing response property gracefully, setting responseId and an empty candidates array.
packages/core/src/code_assist/converter.ts
- Modified fromGenerateContentResponse to check if res.response exists before accessing its properties. If res.response is missing, candidates is initialized as an empty array.
- Updated the assignment of out.candidates to use the nullish coalescing operator (?? []) to ensure it is always an array, even if inres.candidates is undefined.
- Reordered the assignment of out.responseId to occur earlier in the function for consistency.

Activity

No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request hardens the fromGenerateContentResponse function in the code assist converter to gracefully handle malformed API responses where the response field might be missing. This is a good improvement that prevents potential runtime errors. A new unit test is also added to verify this behavior. I have one suggestion to further simplify the implementation for better readability and maintainability.

gemini-code-assist · 2026-02-09T18:29:38Z

packages/core/src/code_assist/converter.ts

+  if (!inres) {
+    out.candidates = [];
+    return out;
+  }
+  out.candidates = inres.candidates ?? [];
  out.automaticFunctionCallingHistory = inres.automaticFunctionCallingHistory;
  out.promptFeedback = inres.promptFeedback;
  out.usageMetadata = inres.usageMetadata;
  out.modelVersion = inres.modelVersion;


While the current implementation is correct, it can be simplified by removing the conditional branch and early return. Using optional chaining (?.) for all property assignments from inres would make the code more concise, readable, and create a single execution path. This reduces complexity and makes the function easier to maintain and less prone to errors in future modifications.

Suggested change

if (!inres) {

out.candidates = [];

return out;

}

out.candidates = inres.candidates ?? [];

out.automaticFunctionCallingHistory = inres.automaticFunctionCallingHistory;

out.promptFeedback = inres.promptFeedback;

out.usageMetadata = inres.usageMetadata;

out.modelVersion = inres.modelVersion;

out.candidates = inres?.candidates ?? [];

out.automaticFunctionCallingHistory = inres?.automaticFunctionCallingHistory;

out.promptFeedback = inres?.promptFeedback;

out.usageMetadata = inres?.usageMetadata;

out.modelVersion = inres?.modelVersion;

github-actions · 2026-02-09T18:30:26Z

Size Change: +67 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	23.8 MB	+67 B (0%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

gundermanc

LGTM.

Validated that it works with my repro.

jbianchini-peya · 2026-02-09T20:32:45Z

skeshive · 2026-02-09T21:06:13Z

/patch stable

github-actions · 2026-02-09T21:06:37Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: stable
Commit: 07056c8f16a9340aedcc716a5c247da07c135cf2
Workflows Created: 1

🔗 Track Progress:

skeshive · 2026-02-09T21:08:38Z

/patch preview

github-actions · 2026-02-09T21:09:06Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: preview
Commit: 07056c8f16a9340aedcc716a5c247da07c135cf2
Workflows Created: 1

🔗 Track Progress:

github-actions · 2026-02-09T21:09:31Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: stable → will publish to npm tag latest
Commit: 07056c8f16a9340aedcc716a5c247da07c135cf2
Hotfix Branch: hotfix/v0.27.3/0.27.4/stable/cherry-pick-07056c8/pr-18656
Hotfix PR: #18671

📝 Next Steps:

Review and approve the hotfix PR: #18671
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #18671

github-actions · 2026-02-09T21:10:21Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: preview → will publish to npm tag preview
Commit: 07056c8f16a9340aedcc716a5c247da07c135cf2
Hotfix Branch: hotfix/v0.28.0-preview.6/0.28.0-preview.7/preview/cherry-pick-07056c8/pr-18656
Hotfix PR: #18672

📝 Next Steps:

Review and approve the hotfix PR: #18672
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #18672

* Fix newline insertion bug in replace tool (google-gemini#18595) * fix(evals): update save_memory evals and simplify tool description (google-gemini#18610) * chore(evals): update validation_fidelity_pre_existing_errors to USUALLY_PASSES (google-gemini#18617) * fix: shorten tool call IDs and fix duplicate tool name in truncated output filenames (google-gemini#18600) * feat(cli): implement atomic writes and safety checks for trusted folders (google-gemini#18406) * Remove relative docs links (google-gemini#18650) * docs: add legacy snippets convention to GEMINI.md (google-gemini#18597) * fix(chore): Support linting for cjs (google-gemini#18639) Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com> * feat: move shell efficiency guidelines to tool description (google-gemini#18614) * Added "" as default value, since getText() used to expect a string only and thus crashed when undefined... Fixes google-gemini#18076 (google-gemini#18099) * Allow @-includes outside of workspaces (with permission) (google-gemini#18470) * chore: make `ask_user` header description more clear (google-gemini#18657) * bug(core): Fix minor bug in migration logic. (google-gemini#18661) * Harded code assist converter. (google-gemini#18656) * refactor(core): model-dependent tool definitions (google-gemini#18563) * feat: enable plan mode experiment in settings (google-gemini#18636) * refactor: push isValidPath() into parsePastedPaths() (google-gemini#18664) * fix(cli): correct 'esc to cancel' position and restore duration display (google-gemini#18534) * feat(cli): add DevTools integration with gemini-cli-devtools (google-gemini#18648) * chore: remove unused exports and redundant hook files (google-gemini#18681) * Fix number of lines being reported in rewind confirmation dialog (google-gemini#18675) * feat(cli): disable folder trust in headless mode (google-gemini#18407) * Disallow unsafe type assertions (google-gemini#18688) * Change event type for release (google-gemini#18693) * feat: handle multiple dynamic context filenames in system prompt (google-gemini#18598) * Properly parse at-commands with narrow non-breaking spaces (google-gemini#18677) * refactor(core): centralize core tool definitions and support model-specific schemas (google-gemini#18662) * feat(core): Render memory hierarchically in context. (google-gemini#18350) * feat: Ctrl+O to expand paste placeholder (google-gemini#18103) * fix(cli): Improve header spacing (google-gemini#18531) * Feature/quota visibility 16795 (google-gemini#18203) * docs: remove TOC marker from Plan Mode header (google-gemini#18678) * Inline thinking bubbles with summary/full modes (google-gemini#18033) Co-authored-by: Jacob Richman <jacob314@gmail.com> * fix(ui): remove redundant newlines in Gemini messages (google-gemini#18538) * test(cli): fix AppContainer act() warnings and improve waitFor resilience (google-gemini#18676) * refactor(core): refine Security & System Integrity section in system prompt (google-gemini#18601) * Fix layout rounding. (google-gemini#18667) * docs(skills): enhance pr-creator safety and interactivity (google-gemini#18616) * test(core): remove hardcoded model from TestRig (google-gemini#18710) * feat(core): optimize sub-agents system prompt intro (google-gemini#18608) * feat(cli): update approval mode labels and shortcuts per latest UX spec (google-gemini#18698) * fix(plan): update persistent approval mode setting (google-gemini#18638) Co-authored-by: Sandy Tao <sandytao520@icloud.com> * fix: move toasts location to left side (google-gemini#18705) * feat(routing): restrict numerical routing to Gemini 3 family (google-gemini#18478) * fix(ide): fix ide nudge setting (google-gemini#18733) * fix(core): standardize tool formatting in system prompts (google-gemini#18615) * chore: consolidate to green in ask user dialog (google-gemini#18734) * feat: add `extensionsExplore` setting to enable extensions explore UI. (google-gemini#18686) * feat(cli): defer devtools startup and integrate with F12 (google-gemini#18695) * ui: update & subdue footer colors and animate progress indicator (google-gemini#18570) * test: add model-specific snapshots for coreTools (google-gemini#18707) Co-authored-by: matt korwel <matt.korwel@gmail.com> * ci: shard windows tests and fix event listener leaks (google-gemini#18670) * fix: allow `ask_user` tool in yolo mode (google-gemini#18541) * feat: redact disabled tools from system prompt (google-gemini#13597) (google-gemini#18613) * Update Gemini.md to use the curent year on creating new files (google-gemini#18460) * Code review cleanup for thinking display (google-gemini#18720) * fix(cli): hide scrollbars when in alternate buffer copy mode (google-gemini#18354) Co-authored-by: Jacob Richman <jacob314@gmail.com> * Fix issues with rip grep (google-gemini#18756) * fix(cli): fix history navigation regression after prompt autocomplete (google-gemini#18752) * chore: cleanup unused and add unlisted dependencies in packages/cli (google-gemini#18749) * Fix issue where Gemini CLI creates tests in a new file (google-gemini#18409) * feat(telemetry): Ensure experiment IDs are included in OpenTelemetry logs (google-gemini#18747) * feat(ux): added text wrapping capabilities to markdown tables (google-gemini#18240) Co-authored-by: jacob314 <jacob314@gmail.com> * Revert "fix(mcp): ensure MCP transport is closed to prevent memory leaks" (google-gemini#18771) * chore(release): bump version to 0.30.0-nightly.20260210.a2174751d (google-gemini#18772) * chore: cleanup unused and add unlisted dependencies in packages/core (google-gemini#18762) * chore(core): update activate_skill prompt verbiage to be more direct (google-gemini#18605) * Add autoconfigure memory usage setting to the dialog (google-gemini#18510) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * fix(core): prevent race condition in policy persistence (google-gemini#18506) Co-authored-by: Allen Hutchison <adh@google.com> * fix(evals): prevent false positive in hierarchical memory test (google-gemini#18777) * test(evals): mark all `save_memory` evals as `USUALLY_PASSES` due to unreliability (google-gemini#18786) * feat(cli): add setting to hide shortcuts hint UI (google-gemini#18562) * feat(core): formalize 5-phase sequential planning workflow (google-gemini#18759) * Introduce limits for search results. (google-gemini#18767) --------- Co-authored-by: Andrew Garrett <andrewgarrett@google.com> Co-authored-by: N. Taylor Mullen <ntaylormullen@google.com> Co-authored-by: Sandy Tao <sandytao520@icloud.com> Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com> Co-authored-by: christine betts <chrstn@uw.edu> Co-authored-by: Aswin Ashok <aswwwin@google.com> Co-authored-by: Abhijith V Ashok <abhi2349jith@gmail.com> Co-authored-by: Tommaso Sciortino <sciortino@gmail.com> Co-authored-by: Jack Wotherspoon <jackwoth@google.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Jacob Richman <jacob314@gmail.com> Co-authored-by: Aishanee Shah <aishaneeshah@gmail.com> Co-authored-by: Jerop Kipruto <jerop@google.com> Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com> Co-authored-by: Christian Gunderman <gundermanc@gmail.com> Co-authored-by: g-samroberts <158088236+g-samroberts@users.noreply.github.com> Co-authored-by: Spencer <spencertang@google.com> Co-authored-by: Dmitry Lyalin <dmitry.lyalin@lyalin.com> Co-authored-by: matt korwel <matt.korwel@gmail.com> Co-authored-by: Shreya Keshive <shreyakeshive@google.com> Co-authored-by: Sri Pasumarthi <111310667+sripasg@users.noreply.github.com> Co-authored-by: Keith Guerin <keithguerin@gmail.com> Co-authored-by: Sehoon Shon <sshon@google.com> Co-authored-by: Adam Weidman <65992621+adamfweidman@users.noreply.github.com> Co-authored-by: Kevin Ramdass <ramdass.kevin@gmail.com> Co-authored-by: Dev Randalpura <devrandalpura@google.com> Co-authored-by: gemini-cli-robot <gemini-cli-robot@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Brad Dux <959674+braddux@users.noreply.github.com> Co-authored-by: Allen Hutchison <adh@google.com> Co-authored-by: Abhijit Balaji <abhijitbalaji@google.com>

Harded code assist converter.

5f61531

jacob314 requested a review from a team as a code owner February 9, 2026 18:27

jacob314 enabled auto-merge February 9, 2026 18:29

gemini-code-assist bot reviewed Feb 9, 2026

View reviewed changes

gemini-cli bot added priority/p0 Critical and urgent (e.g., critical security vulnerability, major breakage). area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality labels Feb 9, 2026

gundermanc approved these changes Feb 9, 2026

View reviewed changes

jacob314 added this pull request to the merge queue Feb 9, 2026

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 9, 2026

jacob314 added this pull request to the merge queue Feb 9, 2026

Merged via the queue into main with commit 07056c8 Feb 9, 2026
29 checks passed

jacob314 deleted the fix_crash branch February 9, 2026 21:05

github-actions bot pushed a commit that referenced this pull request Feb 9, 2026

Harded code assist converter. (#18656)

5b81e93

github-actions bot pushed a commit that referenced this pull request Feb 9, 2026

Harded code assist converter. (#18656)

05149d2

This was referenced Feb 18, 2026

Changelog for v0.29.0 #19361

Merged

Changelog for v0.30.0-preview.5 #20107

Merged

Comments

Conversation

jacob314 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

gemini-cli bot commented Feb 9, 2026

Uh oh!

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

gundermanc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbianchini-peya commented Feb 9, 2026

Uh oh!

Uh oh!

skeshive commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

skeshive commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

github-actions bot commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jacob314 commented Feb 9, 2026 •

edited

Loading