fix: shorten tool call IDs and fix duplicate tool name in truncated output filenames

[SandyTao520]

Summary

Shortened generated callId and fixed double tool name in truncated output filenames (e.g. run_shell_command_run_shell_command_... → run_shell_command_1707400000000_0.txt).

Details

• Changed callId format from {toolName}-{timestamp}-{randomHex} to {toolName}_{timestamp}_{counter}, using an instance-level dedup counter on Turn
• Removed toolName parameter from saveTruncatedToolOutput since the callId already contains it

Related Issues

#18007

How to Validate

• Run npx vitest run packages/core/src/core/turn.test.ts packages/core/src/utils/fileUtils.test.ts packages/core/src/scheduler/tool-executor.test.ts packages/core/src/services/chatCompressionService.test.ts
• All tests should pass (the tool-executor truncation test failure is pre-existing on main)

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-cli]

Hi @SandyTao520, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

[gemini-code-assist]

Summary of Changes

Hello @SandyTao520, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the internal mechanisms for identifying tool calls and naming their truncated output files. It introduces a more compact and deterministic format for callIds, improving their readability and debugging utility. Concurrently, it resolves an issue where tool names were duplicated in the filenames of truncated outputs, leading to cleaner and more efficient file management. These changes enhance the system's robustness and maintainability by refining core identifier and file naming conventions.

Highlights

• Shortened Tool Call IDs: The format for generated callIds has been changed from {toolName}-{timestamp}-{randomHex} to a more concise {toolName}_{timestamp}_{counter}. A new instance-level dedup counter on the Turn class ensures uniqueness even for calls within the same millisecond.
• Fixed Duplicate Tool Name in Truncated Output Filenames: The toolName parameter has been removed from the saveTruncatedToolOutput function. The callId (which now includes the tool name) is directly used for filename generation, eliminating redundant tool name prefixes in truncated output files (e.g., run_shell_command_run_shell_command_... is now run_shell_command_1707400000000_0.txt).
• Refactored saveTruncatedToolOutput Signature: The saveTruncatedToolOutput function no longer requires a separate toolName argument, simplifying its interface and usage across the codebase.

Changelog

• packages/core/src/core/turn.test.ts
  • Updated the regex pattern for callId expectations to align with the new toolName_timestamp_counter format.
• packages/core/src/core/turn.ts
  • Added lastCallTs and callCounter private members to the Turn class to manage unique callId generation.
  • Modified the addPendingToolCall method to implement the new toolName_timestamp_counter callId format, including logic for incrementing the counter for calls within the same millisecond.
• packages/core/src/scheduler/tool-executor.test.ts
  • Adjusted test calls to saveTruncatedToolOutput by removing the now-redundant toolName argument.
• packages/core/src/scheduler/tool-executor.ts
  • Removed the toolName argument from the saveTruncatedToolOutput function call.
• packages/core/src/services/chatCompressionService.test.ts
  • Updated the regex pattern for truncated output filenames to reflect that the tool name is no longer a separate prefix.
• packages/core/src/services/chatCompressionService.ts
  • Removed the toolName argument from the saveTruncatedToolOutput function call.
• packages/core/src/utils/fileUtils.test.ts
  • Updated test cases for saveTruncatedToolOutput to remove the toolName parameter and validate the new filename format.
  • Adjusted expected filenames in tests to ensure proper sanitization and the absence of duplicate tool names.
• packages/core/src/utils/fileUtils.ts
  • Modified the saveTruncatedToolOutput function signature to remove the toolName parameter.
  • Updated the filename generation logic to use only the id (which now contains the tool name) for creating the output file name, preventing redundant tool name prefixes.

Activity

• Tests were added/updated to cover the changes, as indicated by the pre-merge checklist.
• The author noted that all tests should pass, with a pre-existing failure in tool-executor truncation tests on the main branch.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-cli]

Thank you for linking an issue! This pull request has been automatically reopened.

[gemini-code-assist]

Code Review

This pull request shortens tool call IDs and fixes an issue with duplicate tool names in truncated output filenames. The changes look good overall, but there's a regression in how truncated history files are named during chat compression, which I've flagged as a high-severity issue. My review includes a suggestion to fix this while keeping the benefits of the rest of the changes.

[github-actions]

Size Change: +50 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.8 MB	+50 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}