-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v11.14.0 proposal #27163
v11.14.0 proposal #27163
Commits on Mar 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 62f9049 - Browse repository at this point
Copy the full SHA 62f9049View commit details
Commits on Mar 30, 2019
-
src: fix warnings around node_options
* header explicit usage, order, and reduce use of `*-inl.h` * pointer -> const reference when possible * no variable recyclicng * `std::begin/end` prefered over `instance.begin/end` * `USE` for explicit unused resaults Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e6c1ad5 - Browse repository at this point
Copy the full SHA e6c1ad5View commit details -
src: forbid access to CLI options before bootstrapping is done
PR-URL: #26476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 63e7cc7 - Browse repository at this point
Copy the full SHA 63e7cc7View commit details -
src: refactor coverage connection
- Refactor the C++ class to be resuable for other types of profiles - Move the try-catch block around coverage collection callback to be inside the callback to silence potential JSON or write errors. - Use Function::Call instead of MakeCallback to call the coverage message callback since it does not actually need async hook handling. This way we no longer needs to disable the async hooks when writing the coverage results. - Renames `lib/internal/coverage-gen/with_profiler.js` to `lib/internal/profiler.js` because it is now the only way to generate coverage. PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ab70c96 - Browse repository at this point
Copy the full SHA ab70c96View commit details -
test: show stderr on v8 coverage test failures
PR-URL: #26513 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 03bd649 - Browse repository at this point
Copy the full SHA 03bd649View commit details -
process: delay process.argv[0] and process.argv0 handling
Since these depends on process runtime states, delay them until pre-execution. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for d4f9509 - Browse repository at this point
Copy the full SHA d4f9509View commit details -
process: create legacy process properties during pre-execution
Shim legacy process object properties of CLI options during pre-execution instead of serializing them during bootstrap. PR-URL: #26517 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 75c5d9c - Browse repository at this point
Copy the full SHA 75c5d9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a29a94 - Browse repository at this point
Copy the full SHA 5a29a94View commit details -
src: apply clang-tidy rule modernize-make-unique
PR-URL: #26493 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for c51cc9e - Browse repository at this point
Copy the full SHA c51cc9eView commit details -
embedding: refactor public
ArrayBufferAllocator
APIUse a RAII approach by default, and make it possible for embedders to use the `ArrayBufferAllocator` directly as a V8 `ArrayBuffer::Allocator`, e.g. when passing to `Isolate::CreateParams` manually. PR-URL: #26525 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7671a65 - Browse repository at this point
Copy the full SHA 7671a65View commit details -
embedding: make
NewIsolate()
API more flexibleSplit the API up into its essential parts, namely setting up the creation parameters for the Isolate, creating it, and performing Node.js-specific customization afterwards. PR-URL: #26525 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5e64acd - Browse repository at this point
Copy the full SHA 5e64acdView commit details -
inspector: patch C++ debug options instead of process._breakFirstLine
Instead of patching process._breakFirstLine to inform the JS land to wait for the debugger, check that the JS land has not yet serialized the options and then patch the debug options from C++. The changes will be carried into JS later during option serialization. PR-URL: #26602 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 1b45704 - Browse repository at this point
Copy the full SHA 1b45704View commit details -
util: require
isNativeError
from internalBindingPR-URL: #23081 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 169f3f7 - Browse repository at this point
Copy the full SHA 169f3f7View commit details -
util: extract uncurryThis function for reuse
PR-URL: #23081 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 21486e5 - Browse repository at this point
Copy the full SHA 21486e5View commit details -
child_process: reduce internal usage of public require of util
PR-URL: #26769 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 4defe47 - Browse repository at this point
Copy the full SHA 4defe47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44450ef - Browse repository at this point
Copy the full SHA 44450efView commit details -
timers: deprecate active() and _unrefActive()
Another nail in the coffin here, farewell ye ol C-style apis. These apis caused numerous other issues that required far too many safeguards. This gets us one step closer to not having to worry about those issues anymore. Refs: #18066 Refs: #20298 PR-URL: #26760 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b24e45a - Browse repository at this point
Copy the full SHA b24e45aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d9f819 - Browse repository at this point
Copy the full SHA 5d9f819View commit details -
fs: reduce usage of require('util')
PR-URL: #26783 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bb9f1cc - Browse repository at this point
Copy the full SHA bb9f1ccView commit details -
process: handle --expose-internals during pre-execution
Instead of relying on the value of the CLI option when executing bootstrap/loaders.js. PR-URL: #26759 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for a03552d - Browse repository at this point
Copy the full SHA a03552dView commit details -
console: remove unreachable code
In the current code, line 497 checks if `item` is `null` or `undefined`. However, `item` is guaranteed to be a non-null object or function at that point. * Lines 484/485 set `primitive` to `true` if `item` is null or undefined. * Line 486 skips line 497 if `primitive` is true (which it will always be if `item` is null or undefined) and `properties` is undefined. So the only way to get to line 497 when `item` is null or undefined is if `properties` is specified. * Line 494 skips line 497 if `primitive` is true (which it will always be if `item` is null or undefined) and `properties` are specified (which will always be the case or else this `else` block is skipped.) Here are the current lines 484 through 497: const primitive = item === null || (typeof item !== 'function' && typeof item !== 'object'); if (properties === undefined && primitive) { hasPrimitives = true; valuesKeyArray[i] = _inspect(item); } else { const keys = properties || ObjectKeys(item); for (const key of keys) { if (map[key] === undefined) map[key] = []; if ((primitive && properties) || !hasOwnProperty(item, key)) map[key][i] = ''; else map[key][i] = item == null ? item : _inspect(item[key]); This change removes the unnecessary ternary in that final line, simplifying it to: map[key][i] = _inspect(item[key]); PR-URL: #26906 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e43dbaa - Browse repository at this point
Copy the full SHA e43dbaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e845e - Browse repository at this point
Copy the full SHA 80e845eView commit details -
src: delete unreachable code in heap_utils.cc
PR-URL: #26815 Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c1def07 - Browse repository at this point
Copy the full SHA c1def07View commit details -
src: tidy up include headers in env.cc
PR-URL: #26815 Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ea7e2c0 - Browse repository at this point
Copy the full SHA ea7e2c0View commit details -
src: delete unused field in class ModuleWrap
PR-URL: #26815 Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c824127 - Browse repository at this point
Copy the full SHA c824127View commit details -
src: use deleted function for class BaseObject
PR-URL: #26815 Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c969731 - Browse repository at this point
Copy the full SHA c969731View commit details -
src: fix task release in cares_wrap.cc
PR-URL: #26815 Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6bfb17f - Browse repository at this point
Copy the full SHA 6bfb17fView commit details -
src: delete useless code in cares_wrap.cc
PR-URL: #26815 Reviewed-By: Refael Ackermann <refack@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0427354 - Browse repository at this point
Copy the full SHA 0427354View commit details -
test: refactor path parse test
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module. PR-URL: #26912 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for a1cf745 - Browse repository at this point
Copy the full SHA a1cf745View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd006e1 - Browse repository at this point
Copy the full SHA bd006e1View commit details -
util: improve proxy inspection
This makes sure the brace is actually handled as any other brace. It was handled differently so far than any other brace and that had an impact on how the output would be formatted. PR-URL: #26919 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1b08e62 - Browse repository at this point
Copy the full SHA 1b08e62View commit details -
worker: allow execArgv and eval in combination
It was likely an oversight that `execArgv` was only read when no filename/URL was provided. PR-URL: #26533 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 682b410 - Browse repository at this point
Copy the full SHA 682b410View commit details -
errors: make range mandatory in ERR_OUT_OF_RANGE
So far the range argument was allowed to be undefined. This is not used in the codebase anymore and therefore it is best to make it mandatory for the best user experience. PR-URL: #26924 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for c756b84 - Browse repository at this point
Copy the full SHA c756b84View commit details -
doc: remove reference to "credentials object"
The reference is confusing because the object is actually of class SecureContext. There is no object with class "credentials". See: #20432 (comment) PR-URL: #26908 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 17bff5c - Browse repository at this point
Copy the full SHA 17bff5cView commit details -
doc: correct typo: cert.issuerCertificate
- docs incorrectly mention issuerCert, should be issuerCertificate Fix for Commit: a856406c2dc#diff-f6e3a86962eaf0897ab59e88b418e64fR678 Fix for PR: #24358
Configuration menu - View commit details
-
Copy full SHA for a821a96 - Browse repository at this point
Copy the full SHA a821a96View commit details
Commits on Apr 8, 2019
-
crypto: allow undefined for saltLength and padding
PR-URL: #26921 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 98552f3 - Browse repository at this point
Copy the full SHA 98552f3View commit details -
benchmark: remove unused field in class BenchmarkProgress
PR-URL: #26925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for de93737 - Browse repository at this point
Copy the full SHA de93737View commit details -
doc: change links to https in benchmark guide
PR-URL: #26925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 25d5198 - Browse repository at this point
Copy the full SHA 25d5198View commit details -
benchmark: tidy up eslint ignore in foreach-bench.js
PR-URL: #26925 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5512ecb - Browse repository at this point
Copy the full SHA 5512ecbView commit details -
test: do not require flags when executing a file
Instead of throwing an error in case a flag is missing, just start a `child_process` that includes all flags. This improves the situation for all developers in case they want to just plainly run a test. Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: #26858 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 2ef1bd9 - Browse repository at this point
Copy the full SHA 2ef1bd9View commit details -
The hasCrypto check should be checked before anything else to prevent overhead in case it's not falsy. Otherwise the file would be read without any further benefit. PR-URL: #26858 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for edad9af - Browse repository at this point
Copy the full SHA edad9afView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd6381b - Browse repository at this point
Copy the full SHA fd6381bView commit details -
util: fix map entries inspection
This makes sure the arrays returned by Map#entries() are handled as any other array instead of just visualizing the entries as array. Therefore options should have an impact on the arrays. PR-URL: #26918 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 1aa6e99 - Browse repository at this point
Copy the full SHA 1aa6e99View commit details -
A couple of code parts could not be reached due to resolving the path in the beginning. That "normalizes" the path in a way that some code branches became obsolete. PR-URL: #26916 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b62739c - Browse repository at this point
Copy the full SHA b62739cView commit details -
dns: remove dns.promises experimental warning
PR-URL: #26592 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d3c1de3 - Browse repository at this point
Copy the full SHA d3c1de3View commit details -
dns: make dns.promises enumerable
PR-URL: #26592 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for ac12109 - Browse repository at this point
Copy the full SHA ac12109View commit details -
doc: move dns.promises to stable status
PR-URL: #26592 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 4a7a84a - Browse repository at this point
Copy the full SHA 4a7a84aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d76c30c - Browse repository at this point
Copy the full SHA d76c30cView commit details -
test: add known_issues test for fs.copyFile()
On macOS, fs.copyFile() may not respect file permissions. There is a PR for libuv that should fix this, but until it lands and we can either float a patch or upgrade libuv, have a known_issues test. Ref: #26936 Ref: libuv/libuv#2233 PR-URL: #26939 Refs: #26936 Refs: libuv/libuv#2233 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 9330d7e - Browse repository at this point
Copy the full SHA 9330d7eView commit details -
build: add a
Prepare ccache
job in TravisCombined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes). Add a job to Travis that compiles Node.js but doesnt run any tests to populate the ccache. Introduce staging and move the `Test Suite` job into a later stage so that it can use the populated ccache. PR-URL: #27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 769d12c - Browse repository at this point
Copy the full SHA 769d12cView commit details -
build: fix skipping of flaky tests on Travis
`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use `CI_JS_SUITES` instead. PR-URL: #27002 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 6cbd6b5 - Browse repository at this point
Copy the full SHA 6cbd6b5View commit details -
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt
If Debugger.setAsyncCallStackDepth is sent during bootstrap, we cannot immediately call into JS to enable the hooks, which could interrupt the JS execution of bootstrap. So instead we save the notification in the inspector agent if it's sent in the middle of bootstrap, and process the notification later here. Refs: #26798 PR-URL: #26935 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e776b01 - Browse repository at this point
Copy the full SHA e776b01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 760d089 - Browse repository at this point
Copy the full SHA 760d089View commit details -
doc: remove "How is an LTS release cut?" section
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document. PR-URL: #26955 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 28efecc - Browse repository at this point
Copy the full SHA 28efeccView commit details -
url: add ws: and wss: to slashedProtocol set
Fix cases where the pathname is incorrectly parsed as `null`. PR-URL: #26941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 8798db3 - Browse repository at this point
Copy the full SHA 8798db3View commit details -
doc: update changelog for v10.x LTS
PR-URL: #26931 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 17cc117 - Browse repository at this point
Copy the full SHA 17cc117View commit details -
util: add subclass and null prototype support for errors in inspect
This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive. PR-URL: #26923 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 0f615d4 - Browse repository at this point
Copy the full SHA 0f615d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aea4d1 - Browse repository at this point
Copy the full SHA 0aea4d1View commit details -
build: remove unused label from vcbuild.bat
Remove the :wix-not-found label and harmonize the spelling of "WiX". PR-URL: #26901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 7fe43bd - Browse repository at this point
Copy the full SHA 7fe43bdView commit details -
tools: update dependencies in lint-md-cli-rollup
Summary + Update `@zeit/ncc` to `^0.16.1` from `^0.15.2` + Update `unified-engine` to `^6.0.1` from `^5.1.0` + Run `npm audit fix` + Run `npm run build-node` Refs: + https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0 + https://github.com/unifiedjs/unified-engine/releases/tag/6.0.1 + https://github.com/zeit/ncc/releases/tag/0.16.0 + https://github.com/zeit/ncc/releases/tag/0.16.1 PR-URL: #26889 Refs: https://github.com/unifiedjs/unified-engine/releases/tag/6.0.0 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for dc9ce86 - Browse repository at this point
Copy the full SHA dc9ce86View commit details
Commits on Apr 9, 2019
-
test: simplify for loop in test-buffer-zero-fill-cli.js
PR-URL: #26799 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e5181f8 - Browse repository at this point
Copy the full SHA e5181f8View commit details -
readline: replace quadratic regex with linear one
Simplify regular expression in _wordLeft and _deleteWordLeft readline methods. PR-URL: #26778 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 78fad32 - Browse repository at this point
Copy the full SHA 78fad32View commit details -
src: allow per-Environment set of env vars
Abstract the `process.env` backing mechanism in C++ to allow different kinds of backing stores for `process.env` for different Environments. PR-URL: #26544 Fixes: #24947 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d3840bc - Browse repository at this point
Copy the full SHA d3840bcView commit details -
src: implement generic backend for process.env
Allow a generic string-based backing store, with no significance to the remainder of the process, as a store for `process.env`. PR-URL: #26544 Fixes: #24947 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 729e2f2 - Browse repository at this point
Copy the full SHA 729e2f2View commit details -
worker: use copy of process.env
Instead of sharing the OS-backed store for all `process.env` instances, create a copy of `process.env` for every worker that is created. The copies do not interact. Native-addons do not see modifications to `process.env` from Worker threads, but child processes started from Workers do default to the Worker’s copy of `process.env`. This makes Workers behave like child processes as far as `process.env` is concerned, and an option corresponding to the `child_process` module’s `env` option is added to the constructor. Fixes: #24947 PR-URL: #26544 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 8bd7909 - Browse repository at this point
Copy the full SHA 8bd7909View commit details -
This simplifies loading the experimental modules. Instead of always checking for them we should eagerly load the functions in case the experimental modules flag is passed through. PR-URL: #26974 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3c92926 - Browse repository at this point
Copy the full SHA 3c92926View commit details -
stream: do not unconditionally call
_read()
onresume()
`readable.resume()` calls `.read(0)`, which in turn previously set `needReadable = true`, and so a subsequent `.read()` call would call `_read()` even though enough data was already available. This can lead to elevated memory usage, because calling `_read()` when enough data is in the readable buffer means that backpressure is not being honoured. Fixes: #26957 PR-URL: #26965 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for ea47189 - Browse repository at this point
Copy the full SHA ea47189View commit details -
build,win: silence MSVC warning C4129 for V8
Currently we get 13,799 of those per build PR-URL: #27017 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b64b223 - Browse repository at this point
Copy the full SHA b64b223View commit details -
child_process: doc deprecate ChildProcess._channel
This was eligible to begin deprecation in Node 8. PR-URL: #26982 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 2396743 - Browse repository at this point
Copy the full SHA 2396743View commit details -
doc: change code lang and update it with latest Node.js
PR-URL: #26987 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 7a39196 - Browse repository at this point
Copy the full SHA 7a39196View commit details -
src: add missing uv_fs_req_cleanup()
This cleans up after the uv_fs_realpath() call a few lines up. PR-URL: #27004 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for fbdead7 - Browse repository at this point
Copy the full SHA fbdead7View commit details -
PR-URL: #27024 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 06dce39 - Browse repository at this point
Copy the full SHA 06dce39View commit details -
src: fix warning on mismatched fn signature
Add the missing `void* priv` to node_report's Initialize(). PR-URL: #26950 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d0ee1a3 - Browse repository at this point
Copy the full SHA d0ee1a3View commit details -
test: remove unused triggerAsyncId param in test
PR-URL: #26800 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 8258f07 - Browse repository at this point
Copy the full SHA 8258f07View commit details -
tools: update ESLint to 5.16.0
Update ESLint to 5.16.0 PR-URL: #27005 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 7cbe121 - Browse repository at this point
Copy the full SHA 7cbe121View commit details
Commits on Apr 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 57207e7 - Browse repository at this point
Copy the full SHA 57207e7View commit details -
doc: add information about modules cache behavior
This publicly documents that adding native module names will resolve the added entry instead of the native module. It also updates the description why extensions are deprecated. PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 0b94aec - Browse repository at this point
Copy the full SHA 0b94aecView commit details -
doc: move "Prints: ..." under the code
PR-URL: #27035 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 64a74d5 - Browse repository at this point
Copy the full SHA 64a74d5View commit details -
dns: refactor lib/internal/dns/utils.js
* alphabetize contenst of `resolverKeys` array * less line-wrapping for increased code clarity PR-URL: #27006 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 96e429a - Browse repository at this point
Copy the full SHA 96e429aView commit details -
test: add IPv6 brackets but no port to test-dns
Add a test case to test-dns to check that supply an IPv6 host with brackets but no explicit port to `dns.setServers()` yields expected results. This is the final bit of test coverage missing for lib/internal/dns/utils.js. PR-URL: #27006 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a0b0e42 - Browse repository at this point
Copy the full SHA a0b0e42View commit details -
build,meta: tweak Travis config
* Add `lint-py-build` to get `lint-ci` to lint python * Add compile V8 job * Make compilation verbose * Test with `test-ci` PR-URL: #26969 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b766c06 - Browse repository at this point
Copy the full SHA b766c06View commit details -
src: remove internal includes from node_crypto.h
Remove headers used by node_crypto.cc that were included in node_crypto.h. The header file should only include what it uses itself. PR-URL: #26966 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5102d69 - Browse repository at this point
Copy the full SHA 5102d69View commit details -
doc: improve the doc of the 'information' event
- Add missing argument - Reword a sentence - Rename the `res` argument to `info` in the example to avoid confusion PR-URL: #27009 Fixes: #26905 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 4c96ef7 - Browse repository at this point
Copy the full SHA 4c96ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 687348a - Browse repository at this point
Copy the full SHA 687348aView commit details -
fs: remove experimental warning for fs.promises
This has been warning for long enough, without any API changes in the last few months. PR-URL: #26581 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for ccd3b74 - Browse repository at this point
Copy the full SHA ccd3b74View commit details -
PR-URL: #27007 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5945cf0 - Browse repository at this point
Copy the full SHA 5945cf0View commit details -
test: remove test-trace-events-api-worker-disabled from flaky
PR-URL: #27020 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 38da9be - Browse repository at this point
Copy the full SHA 38da9beView commit details -
PR-URL: #26888 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 054cf7b - Browse repository at this point
Copy the full SHA 054cf7bView commit details -
doc: remove description duplication in buffer.md
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5fdee11 - Browse repository at this point
Copy the full SHA 5fdee11View commit details -
doc: fix possible typo in buffer.md
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for fd3b031 - Browse repository at this point
Copy the full SHA fd3b031View commit details -
doc: add missing types in buffer.md
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 944ce7b - Browse repository at this point
Copy the full SHA 944ce7bView commit details -
doc: unify number/integer types in buffer.md
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5fd4053 - Browse repository at this point
Copy the full SHA 5fd4053View commit details -
doc: fix error notes in
Buffer.from()
variantsMake notes about `TypeError` conditions in `Buffer.from()` variants more accurate. PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3a35d8a - Browse repository at this point
Copy the full SHA 3a35d8aView commit details -
doc: add note about Buffer octets integer coercion
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for f9ef9eb - Browse repository at this point
Copy the full SHA f9ef9ebView commit details -
doc: mark optional parameters in buffer.md
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for ea75d43 - Browse repository at this point
Copy the full SHA ea75d43View commit details -
doc: add notes about negative offsets in buffer.md
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 19ccee0 - Browse repository at this point
Copy the full SHA 19ccee0View commit details -
doc: unify periods in comments in buffer.md
"Prints: ..." comments were excepted to avoid confusion. PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 221bcfb - Browse repository at this point
Copy the full SHA 221bcfbView commit details -
doc: unify link formatting in buffer.md
PR-URL: #27030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 00eef26 - Browse repository at this point
Copy the full SHA 00eef26View commit details -
util:
inspect()
should not exceedbreakLength
Using `util.inspect()` with the `compact` option set to a number could result in output that exceeded the `breakLength` option. This change makes sure that limit is taken into account. PR-URL: #26914 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for e40bfd8 - Browse repository at this point
Copy the full SHA e40bfd8View commit details -
src: elevate v8::Task namespace
PR-URL: #26909 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a318cbc - Browse repository at this point
Copy the full SHA a318cbcView commit details -
path: refactor for less indentation
This just switches the statements in a way that it reduces the overall indentation. The function has a very deep indentation in general and this should improve the readability. PR-URL: #26917 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for addc73a - Browse repository at this point
Copy the full SHA addc73aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 316372c - Browse repository at this point
Copy the full SHA 316372cView commit details -
process: run RunBootstrapping in CreateEnvironment
Also creates `CreateMainEnvironment` to encapsulate the code creating the main environment from the provided Isolate data and arguments. PR-URL: #26788 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for fec9f76 - Browse repository at this point
Copy the full SHA fec9f76View commit details -
The diagnostic report currently contains command line information, and the environment, which contains the PWD environment variable. This combination covers the majority of cases, but it would be useful to have the result of uv_cwd() as an additional data point. This commit adds that information. PR-URL: #27022 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d3c1481 - Browse repository at this point
Copy the full SHA d3c1481View commit details -
doc: remove unnecessary intro in governance doc
The introductory paragraph in GOVERNANCE.md does not add anything that isn't obvious from the document itself. Remove it. PR-URL: #27036 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 0fc5dcc - Browse repository at this point
Copy the full SHA 0fc5dccView commit details -
doc: document the 'pause' and 'resume' events
PR-URL: #26999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 26af6fb - Browse repository at this point
Copy the full SHA 26af6fbView commit details -
stream: make Symbol.asyncIterator support stable
PR-URL: #26989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0ac41fc - Browse repository at this point
Copy the full SHA 0ac41fcView commit details -
readline: make Symbol.asyncIterator support stable
PR-URL: #26989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6d39460 - Browse repository at this point
Copy the full SHA 6d39460View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58da879 - Browse repository at this point
Copy the full SHA 58da879View commit details -
test: make module test pass with NODE_PENDING_DEPRECATION
Some people set the `NODE_PENDING_DEPRECATION` environment variable globally. This makes the test added in 115f0f5 pass when that is the case. Refs: #26823 PR-URL: #27019 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3fce303 - Browse repository at this point
Copy the full SHA 3fce303View commit details -
deps: update nghttp2 to 1.37.0
PR-URL: #26990 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3e4c03d - Browse repository at this point
Copy the full SHA 3e4c03dView commit details -
src: apply clang-tidy rule bugprone-incorrect-roundings
PR-URL: #26885 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 438bc52 - Browse repository at this point
Copy the full SHA 438bc52View commit details -
process: store argv in Environment
This gets rid of Environment::ExecutionMode as well now that we use the original arguments to determine execution mode. PR-URL: #26945 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 1bbe5b3 - Browse repository at this point
Copy the full SHA 1bbe5b3View commit details -
build: only emit download ICU warnings once
The check that the user specified `icu` in `--download` only needs to be done once and not for each entry in `tools/icu/current_ver.dep`. Fixes: #26860 PR-URL: #27031 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a58437d - Browse repository at this point
Copy the full SHA a58437dView commit details -
doc: fix default maxBuffer size
Correctly document the default maxBuffer size for execSync, execFileSync, and spawnSync. It is 200 * 1024, not Infinity. Add tests to verify behaviour is as documented. PR-URL: #22894 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 7547d8e - Browse repository at this point
Copy the full SHA 7547d8eView commit details -
meta: move ofrobots to TSC emeritus
PR-URL: #27076 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 2f1da92 - Browse repository at this point
Copy the full SHA 2f1da92View commit details -
src: use sizeof(var) instead of sizeof(type)
Change `memset(&s, 0, sizeof(type))` to `memset(&s, 0, sizeof(s))`. The former is dangerous when the type of `s` changes. PR-URL: #27038 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a21bee7 - Browse repository at this point
Copy the full SHA a21bee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c62b1a2 - Browse repository at this point
Copy the full SHA c62b1a2View commit details -
benchmark: improve module-loader benchmark
Add more benchmark options to properly verify the gains. This makes sure the benchmark also tests requiring the same module again instead of only loading each module only once. PR-URL: #26970 Refs: #25362 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 4c7a2f1 - Browse repository at this point
Copy the full SHA 4c7a2f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdb0d84 - Browse repository at this point
Copy the full SHA cdb0d84View commit details -
module: add path to the module object
This adds the `path` property to the module object. It contains the current directory as path. That is necessary to add an extra caching layer. It also makes sure the `id` uses a default in case it's not set. Otherwise the `path.dirname(id)` command could fail. PR-URL: #26970 Refs: #25362 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 8f6921e - Browse repository at this point
Copy the full SHA 8f6921eView commit details -
module: add extra caching layer
This adds an extra modules caching layer that operates on the parent's `path` property and the current require argument. That together can be used as unique identifier to speed up loading the same module more than once. It is a cache on top of the current modules cache. It has the nice feature that this cache does not only work in the same file but it works for the whole current directory. So if the same file is loaded in any other file from the same directory, it will also hit this cache instead of having to resolve the file again. To keep it backwards compatible with the old modules cache, it detects invalidation of that cache. PR-URL: #26970 Refs: #25362 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5917f4d - Browse repository at this point
Copy the full SHA 5917f4dView commit details -
buffer: fix concat error message
The list argument may only be of type array, not of any other type as it actually suggests. PR-URL: #27050 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 36714e1 - Browse repository at this point
Copy the full SHA 36714e1View commit details -
deps: add ARM64 Windows support in openssl
This adds ARM64 Windows support in the OpenSSL build system. Since OpenSSL's ARM64 Windows support does not have support for ASM-- that is, VC-WIN64-ARM inherits from VC-noCE-common which has no ASM files--`openssl_no_asm.gypi` is always used for building. This essentially forces the 'no-asm' Configure flag. PR-URL: #26001 Fixes: #25998 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for cee079f - Browse repository at this point
Copy the full SHA cee079fView commit details -
deps: add ARM64 Windows configurations in openssl
This change adds the generated files required for building OpenSSL for Node.js for ARM64 Windows. I did this on a VM running Ubuntu 18.04. The basic workflow is to cd to deps/openssl/config and run `make`, installing any needed packages until all architectures build correctly. Note that OpenSSL 1.1.1 does not support ASM on ARM64 Windows, so this change also supports only no-asm on ARM64 Windows. PR-URL: #26001 Fixes: #25998 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for ddf7477 - Browse repository at this point
Copy the full SHA ddf7477View commit details -
querystring: simplify stringify method
PR-URL: #26591 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 038b778 - Browse repository at this point
Copy the full SHA 038b778View commit details -
src: prevent crash in TTYWrap::Initialize
When console.log is called for the first time it initializes TTYWrap object. However, if there is not enough space on the V8 stack, creating function template fails and triggers empty maybe local exception. PR-URL: #26832 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 70d9f32 - Browse repository at this point
Copy the full SHA 70d9f32View commit details -
crypto: fix crash of encrypted private key export without cipher
PR-URL: #27041 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 066cd60 - Browse repository at this point
Copy the full SHA 066cd60View commit details -
async_hooks: minor cleanup and improvements
Cleanup some code and make the emit hooks very slightly faster. PR-URL: #27034 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for d688a93 - Browse repository at this point
Copy the full SHA d688a93View commit details -
build: fix inspector dependency resolution
It was reported that parallel builds on Windows sometimes error because of missing intermediate files. On closer inspection I noticed that some files are copied from src/ to the intermediate build directory in a way where they don't participate in dependency resolution. Put another way, the build system doesn't know to wait for the copy to complete because we don't tell it to. Fix that by not copying around files but instead making the script that processes them a little smarter about where to find them and where to store the results. PR-URL: #27026 Fixes: #27025 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for b502873 - Browse repository at this point
Copy the full SHA b502873View commit details -
crypto: fix crash of encrypted private key export without cipher
PR-URL: #27041 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for a00d840 - Browse repository at this point
Copy the full SHA a00d840View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75e8377 - Browse repository at this point
Copy the full SHA 75e8377View commit details
Commits on Apr 11, 2019
-
2019-04-11, Version 11.14.0 (Current)
Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163
Configuration menu - View commit details
-
Copy full SHA for cd026f8 - Browse repository at this point
Copy the full SHA cd026f8View commit details