refactor(eslint/func-names): clean up implementation and improve documentation #13601

antoinezanardi · 2025-09-08T21:01:30Z

Refactor and Standardize: `eslint/func-names`

This PR refactors the implementation of the func-names rule to make the codebase more idiomatic Rust, improving readability, maintainability, and alignment with Rust best practices.

In addition, the rule documentation has been standardized and enhanced following the documentation skeleton described in #13389.

Changes included

Refactored rule logic with clearer naming, early returns, and idiomatic Rust patterns (if let, Option, Iterator, etc.).
Improved structure for better readability and maintainability.
Focused on optimization and performances.
Standardized rule documentation for consistency across the linter rules.

Note

This PR is focused solely on refactoring and documentation; no test behavior is modified.

graphite-app · 2025-09-08T21:01:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Copilot

Pull Request Overview

This PR refactors the func-names ESLint rule implementation to improve code quality and documentation. The refactoring moves from verbose imperative patterns to idiomatic Rust code using modern patterns like if let, early returns, and iterator methods.

Restructured configuration handling with cleaner types and better separation of concerns
Replaced verbose logic with concise functional patterns and iterator methods
Expanded documentation with comprehensive examples and detailed option descriptions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/rules/eslint/func_names.rs

codspeed-hq · 2025-09-08T21:06:56Z

CodSpeed Instrumentation Performance Report

Merging #13601 will not alter performance

_{Comparing antoinezanardi:refactor/eslint/func-names (33ff9ee) with main (a8675f4)}

Summary

✅ 37 untouched

crates/oxc_linter/src/rules/eslint/func_names.rs

camc314

thank you!

…mentation

…mprove readability

… readability

…rtion

- Fix has_object_assignment_target_name to properly check if the specific function matches - Reorganize imports to follow conventional order (std first, then external crates) - Rename verbose function name for better readability

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 8, 2025 21:01

antoinezanardi requested a review from camc314 as a code owner September 8, 2025 21:01

github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 8, 2025

Copilot AI reviewed Sep 8, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/func_names.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/rules/eslint/func_names.rs Outdated Show resolved Hide resolved

graphite-app bot reviewed Sep 8, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/func_names.rs Show resolved Hide resolved

graphite-app bot reviewed Sep 8, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/func_names.rs Show resolved Hide resolved

camc314 force-pushed the refactor/eslint/func-names branch from 770d896 to c49dc68 Compare September 12, 2025 08:07

camc314 approved these changes Sep 12, 2025

View reviewed changes

antoinezanardi and others added 6 commits September 15, 2025 20:28

refactor(eslint/func-names): clean up implementation and improve docu…

f8c3452

…mentation

refactor(eslint/func-names): simplify invalid function handling and i…

827ea71

…mprove readability

refactor(eslint/func-names): simplify invalid function handling and i…

c112c9f

…mprove readability

refactor(eslint/func-names): improve function name handling logic and…

1f6bbe0

… readability

refactor(eslint/func-names): use interpolation for function name inse…

19bbc95

…rtion

Boshen force-pushed the refactor/eslint/func-names branch from c49dc68 to 33ff9ee Compare September 15, 2025 12:28

camc314 approved these changes Sep 16, 2025

View reviewed changes

camc314 merged commit 7f4e2fe into oxc-project:main Sep 16, 2025
25 checks passed

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(eslint/func-names): clean up implementation and improve documentation #13601

refactor(eslint/func-names): clean up implementation and improve documentation #13601

antoinezanardi commented Sep 8, 2025

Uh oh!

graphite-app bot commented Sep 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

camc314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

refactor(eslint/func-names): clean up implementation and improve documentation #13601

refactor(eslint/func-names): clean up implementation and improve documentation #13601

Conversation

antoinezanardi commented Sep 8, 2025

Refactor and Standardize: eslint/func-names

Changes included

Uh oh!

graphite-app bot commented Sep 8, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13601 will not alter performance

Summary

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Refactor and Standardize: `eslint/func-names`

codspeed-hq bot commented Sep 8, 2025 •

edited

Loading