refactor(linter): derive inmpls for `PartialEq`, `Eq` over manual ones #13828

camc314 · 2025-09-16T16:16:53Z

No description provided.

camc314 · 2025-09-16T16:17:08Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-16T16:22:57Z

CodSpeed Instrumentation Performance Report

Merging #13828 will not alter performance

_{Comparing c/09-17-refactor_linter_derive_inmpls_for_partialeq_eq_over_manual_ones (395d40d) with main (1c43c7c)¹}

Summary

✅ 37 untouched

No successful run was found on main (395d40d) during the generation of this report, so 1c43c7c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull Request Overview

This PR refactors the linter code to use derived implementations of PartialEq and Eq traits instead of manual implementations for better maintainability and consistency.

Removes manual PartialEq implementations for Fix and PossibleFixes structs
Adds derived PartialEq and Eq traits to Message, Fix, and PossibleFixes structs
Simplifies the codebase by leveraging Rust's automatic trait derivation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/tsgolint.rs	Removes manual `PartialEq` implementation for `PossibleFixes` in test module
crates/oxc_linter/src/fixer/mod.rs	Adds derived `Eq` and `PartialEq` traits to `Message` struct
crates/oxc_linter/src/fixer/fix.rs	Adds derived `PartialEq` and `Eq` traits to `Fix` and `PossibleFixes` structs, removes manual `PartialEq` implementation for `Fix`

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/fixer/mod.rs

camc314 · 2025-09-16T16:43:26Z

Merge activity

Sep 16, 4:43 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 16, 4:43 PM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 16, 4:51 PM UTC: Merged by the Graphite merge queue.

#13828)

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

camc314 mentioned this pull request Sep 16, 2025

test(linter): add debug assertions for skipping rules #13724

Merged

camc314 mentioned this pull request Sep 16, 2025

fix(linter): keep message when merging composite fixes #13827

Merged

github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 16, 2025

camc314 self-assigned this Sep 16, 2025

camc314 marked this pull request as ready for review September 16, 2025 16:18

camc314 force-pushed the c/09-17-refactor_linter_derive_inmpls_for_partialeq_eq_over_manual_ones branch from 3a73d7c to f87153b Compare September 16, 2025 16:32

camc314 requested a review from Copilot September 16, 2025 16:42

graphite-app bot changed the base branch from c/09-17-fix_linter_keep_message_when_merging_composite_fixes to graphite-base/13828 September 16, 2025 16:42

Copilot AI reviewed Sep 16, 2025

View reviewed changes

crates/oxc_linter/src/fixer/mod.rs Show resolved Hide resolved

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

graphite-app bot changed the base branch from graphite-base/13828 to main September 16, 2025 16:47

refactor(linter): derive inmpls for PartialEq, Eq over manual ones (

395d40d

#13828)

graphite-app bot force-pushed the c/09-17-refactor_linter_derive_inmpls_for_partialeq_eq_over_manual_ones branch from f87153b to 395d40d Compare September 16, 2025 16:47

graphite-app bot merged commit 395d40d into main Sep 16, 2025
25 checks passed

graphite-app bot deleted the c/09-17-refactor_linter_derive_inmpls_for_partialeq_eq_over_manual_ones branch September 16, 2025 16:51

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(linter): derive inmpls for `PartialEq`, `Eq` over manual ones #13828

refactor(linter): derive inmpls for `PartialEq`, `Eq` over manual ones #13828

Uh oh!

camc314 commented Sep 16, 2025

Uh oh!

camc314 commented Sep 16, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

camc314 commented Sep 16, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

refactor(linter): derive inmpls for PartialEq, Eq over manual ones #13828

refactor(linter): derive inmpls for PartialEq, Eq over manual ones #13828

Uh oh!

Conversation

camc314 commented Sep 16, 2025

Uh oh!

camc314 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13828 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

camc314 commented Sep 16, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

refactor(linter): derive inmpls for `PartialEq`, `Eq` over manual ones #13828

refactor(linter): derive inmpls for `PartialEq`, `Eq` over manual ones #13828

camc314 commented Sep 16, 2025 •

edited

Loading

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

camc314 commented Sep 16, 2025 •

edited by graphite-app bot

Loading