fix(linter): keep message when merging composite fixes #13827

camc314 · 2025-09-16T16:16:50Z

No description provided.

camc314 · 2025-09-16T16:17:07Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR fixes an issue in the linter's composite fix functionality to preserve fix messages when merging multiple fixes into one. The change ensures that when multiple fixes are combined, the message from the first fix with a message is retained in the resulting merged fix.

Extracts and stores the first available fix message during the merging process
Applies the stored message to the final merged fix using the with_message method

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/fixer/fix.rs

codspeed-hq · 2025-09-16T16:22:32Z

CodSpeed Instrumentation Performance Report

Merging #13827 will not alter performance

_{Comparing c/09-17-fix_linter_keep_message_when_merging_composite_fixes (1c43c7c) with main (7d0b8a1)¹}

Summary

✅ 37 untouched

No successful run was found on main (1c43c7c) during the generation of this report, so 7d0b8a1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

camc314 · 2025-09-16T16:41:58Z

Merge activity

Sep 16, 4:41 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 16, 4:42 PM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 16, 4:46 PM UTC: Merged by the Graphite merge queue.

camc314 · 2025-09-16T16:42:09Z

@Sysix do you mind reviewing this retrospectively? Thanks

Sysix · 2025-09-16T16:56:20Z

LGTM!

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Sep 16, 2025

This was referenced Sep 16, 2025

test(linter): add debug assertions for skipping rules #13724

Merged

refactor(linter): derive inmpls for PartialEq, Eq over manual ones #13828

Merged

camc314 assigned Sysix Sep 16, 2025

camc314 requested a review from Sysix September 16, 2025 16:18

camc314 marked this pull request as ready for review September 16, 2025 16:18

Copilot AI review requested due to automatic review settings September 16, 2025 16:18

Copilot AI reviewed Sep 16, 2025

View reviewed changes

crates/oxc_linter/src/fixer/fix.rs Outdated Show resolved Hide resolved

graphite-app bot reviewed Sep 16, 2025

View reviewed changes

crates/oxc_linter/src/fixer/fix.rs Outdated Show resolved Hide resolved

camc314 force-pushed the c/09-17-fix_linter_keep_message_when_merging_composite_fixes branch from 3f75bbc to 11ba361 Compare September 16, 2025 16:33

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

fix(linter): keep message when merging composite fixes (#13827)

1c43c7c

graphite-app bot force-pushed the c/09-17-fix_linter_keep_message_when_merging_composite_fixes branch from 11ba361 to 1c43c7c Compare September 16, 2025 16:42

graphite-app bot merged commit 1c43c7c into main Sep 16, 2025
25 checks passed

graphite-app bot deleted the c/09-17-fix_linter_keep_message_when_merging_composite_fixes branch September 16, 2025 16:46

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter): keep message when merging composite fixes #13827

fix(linter): keep message when merging composite fixes #13827

Uh oh!

camc314 commented Sep 16, 2025

Uh oh!

camc314 commented Sep 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

camc314 commented Sep 16, 2025 •

edited by graphite-app bot

Loading

Uh oh!

camc314 commented Sep 16, 2025

Uh oh!

Uh oh!

Sysix commented Sep 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(linter): keep message when merging composite fixes #13827

fix(linter): keep message when merging composite fixes #13827

Uh oh!

Conversation

camc314 commented Sep 16, 2025

Uh oh!

camc314 commented Sep 16, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13827 will not alter performance

Summary

Footnotes

Uh oh!

camc314 commented Sep 16, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

camc314 commented Sep 16, 2025

Uh oh!

Uh oh!

Sysix commented Sep 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

camc314 commented Sep 16, 2025 •

edited by graphite-app bot

Loading