fix(linter/plugins): more graceful exit for `--experimental-js-plugins` CLI option #13688

overlookmotel · 2025-09-11T13:04:56Z

--experimental-js-plugins option is not supported in oxlint at present. Exit more gracefully if it's used.

overlookmotel · 2025-09-11T13:05:17Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR improves error handling for the --experimental-js-plugins CLI option in oxlint by replacing a panic with a graceful error exit when JS plugins are requested but not supported.

Replaces an assertion that would panic with conditional error handling
Adds a user-friendly error message when JS plugins are used without proper support
Returns appropriate error code instead of crashing the application

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

apps/oxlint/src/lib.rs

overlookmotel · 2025-09-11T13:14:12Z

Merge activity

Sep 11, 1:14 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 11, 1:14 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Sep 11, 1:19 PM UTC: Merged by the Graphite merge queue.

…s` CLI option (#13688) `--experimental-js-plugins` option is not supported in `oxlint` at present. Exit more gracefully if it's used.

This comment is no longer correct after #13688. I should have removed it in that PR.

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-cli Area - CLI C-bug Category - Bug labels Sep 11, 2025

overlookmotel mentioned this pull request Sep 11, 2025

fix(linter/plugins): exit early if JS plugins enabled on unsupported platforms #13689

Merged

overlookmotel force-pushed the 09-11-fix_linter_plugins_more_graceful_exit_for_--experimental-js-plugins_cli_option branch from 736cca4 to c7cc8e3 Compare September 11, 2025 13:09

overlookmotel marked this pull request as ready for review September 11, 2025 13:09

overlookmotel requested a review from camc314 as a code owner September 11, 2025 13:09

Copilot AI review requested due to automatic review settings September 11, 2025 13:09

Copilot AI reviewed Sep 11, 2025

View reviewed changes

apps/oxlint/src/lib.rs Show resolved Hide resolved

camc314 approved these changes Sep 11, 2025

View reviewed changes

overlookmotel self-assigned this Sep 11, 2025

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025

fix(linter/plugins): more graceful exit for `--experimental-js-plugin…

68a2280

…s` CLI option (#13688) `--experimental-js-plugins` option is not supported in `oxlint` at present. Exit more gracefully if it's used.

graphite-app bot force-pushed the 09-11-fix_linter_plugins_more_graceful_exit_for_--experimental-js-plugins_cli_option branch from c7cc8e3 to 68a2280 Compare September 11, 2025 13:14

graphite-app bot merged commit 68a2280 into main Sep 11, 2025
17 checks passed

graphite-app bot deleted the 09-11-fix_linter_plugins_more_graceful_exit_for_--experimental-js-plugins_cli_option branch September 11, 2025 13:19

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025

overlookmotel mentioned this pull request Sep 11, 2025

fix(linter/plugins): remove outdated comment #13691

Merged

overlookmotel added a commit that referenced this pull request Sep 11, 2025

fix(linter/plugins): remove outdated comment (#13691)

09428f6

This comment is no longer correct after #13688. I should have removed it in that PR.

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter/plugins): more graceful exit for `--experimental-js-plugins` CLI option #13688

fix(linter/plugins): more graceful exit for `--experimental-js-plugins` CLI option #13688

Uh oh!

overlookmotel commented Sep 11, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

overlookmotel commented Sep 11, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(linter/plugins): more graceful exit for --experimental-js-plugins CLI option #13688

fix(linter/plugins): more graceful exit for --experimental-js-plugins CLI option #13688

Uh oh!

Conversation

overlookmotel commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

overlookmotel commented Sep 11, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(linter/plugins): more graceful exit for `--experimental-js-plugins` CLI option #13688

fix(linter/plugins): more graceful exit for `--experimental-js-plugins` CLI option #13688

overlookmotel commented Sep 11, 2025 •

edited

Loading

overlookmotel commented Sep 11, 2025 •

edited

Loading

overlookmotel commented Sep 11, 2025 •

edited by graphite-app bot

Loading